From patchwork Thu Nov 7 13:52:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Brodkin X-Patchwork-Id: 289344 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 94F072C0086 for ; Fri, 8 Nov 2013 01:00:13 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A36744A387; Thu, 7 Nov 2013 15:00:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZBKFn8egzrw5; Thu, 7 Nov 2013 15:00:05 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 640E34A34D; Thu, 7 Nov 2013 14:59:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9ADC94A380 for ; Thu, 7 Nov 2013 14:59:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qcqWxb3qt5Sy for ; Thu, 7 Nov 2013 14:59:43 +0100 (CET) X-Greylist: delayed 456 seconds by postgrey-1.27 at theia; Thu, 07 Nov 2013 14:59:39 CET X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 BL_NJABL=SKIP(-1.5) (only DNSBL check requested) Received: from kiruna.synopsys.com (us01smtp2.synopsys.com [198.182.44.80]) by theia.denx.de (Postfix) with ESMTP id BD6D84A34B for ; Thu, 7 Nov 2013 14:59:38 +0100 (CET) Received: from WBSNus02mta1 (us02secmta1.synopsys.com [10.12.235.96]) by kiruna.synopsys.com (Postfix) with ESMTP id EE75AF2B4; Thu, 7 Nov 2013 05:52:40 -0800 (PST) Received: from us02secmta1.internal.synopsys.com (us02secmta1.internal.synopsys.com [127.0.0.1]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id DB1FD4E213; Thu, 7 Nov 2013 05:52:40 -0800 (PST) Received: from mailhost.synopsys.com (mailhost3.synopsys.com [10.12.238.238]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id A71884E202; Thu, 7 Nov 2013 05:52:40 -0800 (PST) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 953F011F; Thu, 7 Nov 2013 05:52:40 -0800 (PST) Received: from abrodkin-8560l.internal.synopsys.com (abrodkin-8560l.internal.synopsys.com [10.121.8.102]) by mailhost.synopsys.com (Postfix) with ESMTP id 64FFC11A; Thu, 7 Nov 2013 05:52:37 -0800 (PST) From: Alexey Brodkin To: u-boot@lists.denx.de Date: Thu, 7 Nov 2013 17:52:33 +0400 Message-Id: <1383832353-12055-1-git-send-email-abrodkin@synopsys.com> X-Mailer: git-send-email 1.8.4.2 Cc: Stefan Roese , Armando Visconti , Alexey Brodkin , Tom Rix , Tom Rini , Mischa Jonker Subject: [U-Boot] [PATCH] designware_i2c: remove 10msec delay in i2c_xfer_finish X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de This delay applies to any data transfer on I2C bus. For example 1kB data read with per-byte access (which happens if environment is stored in I2C EEPROM) takes more than 10 seconds. Moreover data bus driver has to care about bus state and data transfer, but not about internal states of attached devices. Signed-off-by: Alexey Brodkin Cc: Tom Rini cc: Armando Visconti Cc: Stefan Roese Cc: Albert ARIBAUD Cc: Heiko Schocher Cc: Vipin KUMAR Cc: Tom Rix Cc: Mischa Jonker --- drivers/i2c/designware_i2c.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c index c5c6015..cb2ac04 100644 --- a/drivers/i2c/designware_i2c.c +++ b/drivers/i2c/designware_i2c.c @@ -249,9 +249,6 @@ static int i2c_xfer_finish(void) i2c_flush_rxfifo(); - /* Wait for read/write operation to complete on actual memory */ - udelay(10000); - return 0; }