| Message ID | 1376725174.15462.1.camel@phoenix |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Dear Axel Lin, > Use default_serial_puts() instead of its own implementation. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Thanks, Acked-by: Marek Vasut <marex@denx.de> > --- > drivers/serial/arm_dcc.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/serial/arm_dcc.c b/drivers/serial/arm_dcc.c > index 29d9295..5dfb02f 100644 > --- a/drivers/serial/arm_dcc.c > +++ b/drivers/serial/arm_dcc.c > @@ -123,12 +123,6 @@ static void arm_dcc_putc(char ch) > write_dcc(ch); > } > > -static void arm_dcc_puts(const char *s) > -{ > - while (*s) > - arm_dcc_putc(*s++); > -} > - > static int arm_dcc_tstc(void) > { > register unsigned int reg; > @@ -148,7 +142,7 @@ static struct serial_device arm_dcc_drv = { > .stop = NULL, > .setbrg = arm_dcc_setbrg, > .putc = arm_dcc_putc, > - .puts = arm_dcc_puts, > + .puts = default_serial_puts, > .getc = arm_dcc_getc, > .tstc = arm_dcc_tstc, > }; Best regards, Marek Vasut
On 08/18/2013 10:19 PM, Marek Vasut wrote: > Dear Axel Lin, > >> Use default_serial_puts() instead of its own implementation. >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> > > Thanks, > > Acked-by: Marek Vasut <marex@denx.de> Ah yeah. Acked-by: Michal Simek <monstr@monstr.eu> Tom: Can you please apply this patch directly to your tree? Thanks, Michal
On Sat, Aug 17, 2013 at 03:39:34PM +0800, Axel Lin wrote: > Use default_serial_puts() instead of its own implementation. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Applied to u-boot/master, thanks!
diff --git a/drivers/serial/arm_dcc.c b/drivers/serial/arm_dcc.c index 29d9295..5dfb02f 100644 --- a/drivers/serial/arm_dcc.c +++ b/drivers/serial/arm_dcc.c @@ -123,12 +123,6 @@ static void arm_dcc_putc(char ch) write_dcc(ch); } -static void arm_dcc_puts(const char *s) -{ - while (*s) - arm_dcc_putc(*s++); -} - static int arm_dcc_tstc(void) { register unsigned int reg; @@ -148,7 +142,7 @@ static struct serial_device arm_dcc_drv = { .stop = NULL, .setbrg = arm_dcc_setbrg, .putc = arm_dcc_putc, - .puts = arm_dcc_puts, + .puts = default_serial_puts, .getc = arm_dcc_getc, .tstc = arm_dcc_tstc, };
Use default_serial_puts() instead of its own implementation. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/serial/arm_dcc.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)