From patchwork Thu Jun 13 03:24:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 250960 X-Patchwork-Delegate: albert.aribaud@free.fr Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 7F4702C00A6 for ; Thu, 13 Jun 2013 13:25:34 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6B6CC4A03F; Thu, 13 Jun 2013 05:25:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NDktydXhCofT; Thu, 13 Jun 2013 05:25:27 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 056514A02C; Thu, 13 Jun 2013 05:25:20 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id AD3194A02A for ; Thu, 13 Jun 2013 05:25:13 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rE9owtJCBWZv for ; Thu, 13 Jun 2013 05:25:07 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 BL_NJABL=SKIP(-1.5) (only DNSBL check requested) Received: from mail-ob0-f176.google.com (mail-ob0-f176.google.com [209.85.214.176]) by theia.denx.de (Postfix) with ESMTPS id 79DEE4A025 for ; Thu, 13 Jun 2013 05:25:04 +0200 (CEST) Received: by mail-ob0-f176.google.com with SMTP id v19so14205834obq.21 for ; Wed, 12 Jun 2013 20:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=RfZRzWEIyi9W2eTXyujOIN1oysDbAyA/uIRMNUUjYHA=; b=Lvdt/cgT6W90X79me+YpY6qxUQe0D7eTKaXyaFS83zz+LjTUyb5mrdoNnGLicShtLQ GBsbLF8DuF9K9ZGyXSTRgM9ZdZlFW5qYAVQ5xqdegO7S3Zq22JFvLDJizmGrtz9P27zm 9R6FT3VGm/Lm+eR/rJuyiVsFbnwI+Y9pfXJ6fqEeAkwBnHKPIscG3AlZhPmVSFRzvK3Q it7CbL70Yk4FO3ud7cpk5p4twNEPp1s0lV2On1xOyhtfvbmL+9Do94YVKWkma3spI4BH tWjYPyfLDnxp4LVRDWFlQaKrqIiU1k9f5vwTSCdZtKZjdmikQxv3fUAXMR7YfmCC3uOp K16w== X-Received: by 10.60.116.164 with SMTP id jx4mr17407059oeb.29.1371093903632; Wed, 12 Jun 2013 20:25:03 -0700 (PDT) Received: from rob-laptop.grandenetworks.net (65-36-73-129.dyn.grandenetworks.net. [65.36.73.129]) by mx.google.com with ESMTPSA id oe10sm37501996oeb.6.2013.06.12.20.25.02 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Jun 2013 20:25:03 -0700 (PDT) From: Rob Herring To: u-boot@lists.denx.de, albert.u.boot@aribaud.net, trini@ti.com Date: Wed, 12 Jun 2013 22:24:45 -0500 Message-Id: <1371093894-16424-1-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.8.1.2 Cc: Rob Herring Subject: [U-Boot] [PATCH v2 01/10] ARM: move interrupt_init to before relocation X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Rob Herring interrupt_init also sets up the abort stack, but is not setup before relocation. So any aborts during relocation will hang and not print out any useful information. Fix this by moving the interrupt_init to after the stack setup in board_init_f. Signed-off-by: Rob Herring --- v2: - Remove interrupt_init from board_init_r arch/arm/lib/board.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 09ab4ad..c90843e 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -447,6 +447,7 @@ void board_init_f(ulong bootflag) addr_sp += 128; /* leave 32 words for abort-stack */ gd->irq_sp = addr_sp; #endif + interrupt_init(); debug("New Stack Pointer is: %08lx\n", addr_sp); @@ -648,8 +649,6 @@ void board_init_r(gd_t *id, ulong dest_addr) misc_init_r(); #endif - /* set up exceptions */ - interrupt_init(); /* enable exceptions */ enable_interrupts();