diff mbox

[U-Boot] davinci: Fix Ethernet driver interface warning

Message ID 1337615641-26077-1-git-send-email-joe.hershberger@ni.com
State Accepted
Commit bbcdefb343037cbcf3486c29fd29c4319761eab6
Delegated to: Joe Hershberger
Headers show

Commit Message

Joe Hershberger May 21, 2012, 3:54 p.m. UTC
Fixes:
davinci_emac.c: In function 'davinci_emac_initialize':
davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default]

Tested on da850_am18xxevm

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
---
 drivers/net/davinci_emac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Joe Hershberger May 21, 2012, 8:07 p.m. UTC | #1
Hi Tom,

On Mon, May 21, 2012 at 10:54 AM, Joe Hershberger
<joe.hershberger@ni.com> wrote:
> Fixes:
> davinci_emac.c: In function 'davinci_emac_initialize':
> davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default]
>
> Tested on da850_am18xxevm
>
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>

I'll apply this through the net branch.

Thanks,
-Joe
Tom Rini May 21, 2012, 8:23 p.m. UTC | #2
On 05/21/2012 01:07 PM, Joe Hershberger wrote:
> Hi Tom,
>
> On Mon, May 21, 2012 at 10:54 AM, Joe Hershberger
> <joe.hershberger@ni.com>  wrote:
>> Fixes:
>> davinci_emac.c: In function 'davinci_emac_initialize':
>> davinci_emac.c:796:12: warning: assignment from incompatible pointer type [enabled by default]
>>
>> Tested on da850_am18xxevm
>>
>> Signed-off-by: Joe Hershberger<joe.hershberger@ni.com>
>> Cc: Joe Hershberger<joe.hershberger@gmail.com>
>
> I'll apply this through the net branch.

OK, thanks.  Please take it from me in patchwork too :)
Joe Hershberger May 21, 2012, 8:27 p.m. UTC | #3
On Mon, May 21, 2012 at 3:23 PM, Tom Rini <trini@ti.com> wrote:
> On 05/21/2012 01:07 PM, Joe Hershberger wrote:
>>
>> Hi Tom,
>>
>> On Mon, May 21, 2012 at 10:54 AM, Joe Hershberger
>> <joe.hershberger@ni.com>  wrote:
>>>
>>> Fixes:
>>> davinci_emac.c: In function 'davinci_emac_initialize':
>>> davinci_emac.c:796:12: warning: assignment from incompatible pointer type
>>> [enabled by default]
>>>
>>> Tested on da850_am18xxevm
>>>
>>> Signed-off-by: Joe Hershberger<joe.hershberger@ni.com>
>>> Cc: Joe Hershberger<joe.hershberger@gmail.com>
>>
>>
>> I'll apply this through the net branch.
>
>
> OK, thanks.  Please take it from me in patchwork too :)

Applied, thanks.

-Joe
diff mbox

Patch

diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index fbd0f1b..e471d2c 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -637,7 +637,7 @@  static int tx_send_loop = 0;
  * positive number (number of bytes transmitted) or negative for error
  */
 static int davinci_eth_send_packet (struct eth_device *dev,
-					volatile void *packet, int length)
+					void *packet, int length)
 {
 	int ret_status = -1;
 	int index;