| Message ID | 1334593850-26270-1-git-send-email-agust@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
Hi Anatolij, > Fix: > onenand_base.c: In function 'onenand_probe': > onenand_base.c:2577:6: warning: variable 'maf_id' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: Lukasz Majewski <l.majewski@samsung.com> > --- > drivers/mtd/onenand/onenand_base.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/onenand/onenand_base.c > b/drivers/mtd/onenand/onenand_base.c index 480ae7a..229682c 100644 > --- a/drivers/mtd/onenand/onenand_base.c > +++ b/drivers/mtd/onenand/onenand_base.c > @@ -2574,7 +2574,7 @@ static int onenand_chip_probe(struct mtd_info > *mtd) int onenand_probe(struct mtd_info *mtd) > { > struct onenand_chip *this = mtd->priv; > - int maf_id, dev_id, ver_id; > + int dev_id, ver_id; > int density; > int ret; > > @@ -2583,7 +2583,6 @@ int onenand_probe(struct mtd_info *mtd) > return ret; > > /* Read manufacturer and device IDs from Register */ > - maf_id = this->read_word(this->base + > ONENAND_REG_MANUFACTURER_ID); dev_id = this->read_word(this->base + > ONENAND_REG_DEVICE_ID); ver_id = this->read_word(this->base + > ONENAND_REG_VERSION_ID); this->technology = > this->read_word(this->base + ONENAND_REG_TECHNOLOGY); Is this a regression for -rc or the current master branch (recently Wolfgang has pull some onenand related code)?
Hi Lukasz, On Tue, 17 Apr 2012 13:15:41 +0200 Lukasz Majewski <l.majewski@samsung.com> wrote: ... > Is this a regression for -rc or the current master branch (recently > Wolfgang has pull some onenand related code)? This patch should be applied to current master. Since Wolfgang has pulled u-boot-onenand.git, I see this warning when compiling with GCC 4.6.x. Thanks, Anatolij
Hi Anatolij, > Hi Lukasz, > > On Tue, 17 Apr 2012 13:15:41 +0200 > Lukasz Majewski <l.majewski@samsung.com> wrote: > ... > > Is this a regression for -rc or the current master branch (recently > > Wolfgang has pull some onenand related code)? > > This patch should be applied to current master. Since Wolfgang has > pulled u-boot-onenand.git, I see this warning when compiling with > GCC 4.6.x. > > Thanks, > Anatolij Mine fault - I was looking into -rc1 :-) Acked-by: Lukasz Majewski <l.majewski@samsung.com> Test HW: S5PC110 GONI: Tested-by: Lukasz Majewski <l.majewski@samsung.com>
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 480ae7a..229682c 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -2574,7 +2574,7 @@ static int onenand_chip_probe(struct mtd_info *mtd) int onenand_probe(struct mtd_info *mtd) { struct onenand_chip *this = mtd->priv; - int maf_id, dev_id, ver_id; + int dev_id, ver_id; int density; int ret; @@ -2583,7 +2583,6 @@ int onenand_probe(struct mtd_info *mtd) return ret; /* Read manufacturer and device IDs from Register */ - maf_id = this->read_word(this->base + ONENAND_REG_MANUFACTURER_ID); dev_id = this->read_word(this->base + ONENAND_REG_DEVICE_ID); ver_id = this->read_word(this->base + ONENAND_REG_VERSION_ID); this->technology = this->read_word(this->base + ONENAND_REG_TECHNOLOGY);
Fix: onenand_base.c: In function 'onenand_probe': onenand_base.c:2577:6: warning: variable 'maf_id' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin <agust@denx.de> Cc: Lukasz Majewski <l.majewski@samsung.com> --- drivers/mtd/onenand/onenand_base.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)