| Message ID | 1329292203-27855-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
Hello Nobuhiro, Nobuhiro Iwamatsu wrote: > This provide bit control functions as clrbits_*, setbits_* and > clrsetbits_*. > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> > --- > arch/sh/include/asm/io.h | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) Beside one minor comment: Acked-by: Heiko Schocher <hs@denx.de> > diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h > index ca598a6..79cb098 100644 > --- a/arch/sh/include/asm/io.h > +++ b/arch/sh/include/asm/io.h > @@ -237,6 +237,43 @@ static inline void sync(void) > { > } > > + > +/* Clear and set bits in one shot. These macros can be used to clear and Wrong comment style, please fix. [...] bye, Heiko
Hi, Hello. Thanks for your review. I resend revised patch with your Acked-by. Best regards, Nobuhiro 2012/2/15 Heiko Schocher <hs@denx.de>: > Hello Nobuhiro, > > Nobuhiro Iwamatsu wrote: >> This provide bit control functions as clrbits_*, setbits_* and >> clrsetbits_*. >> >> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> >> --- >> arch/sh/include/asm/io.h | 37 +++++++++++++++++++++++++++++++++++++ >> 1 files changed, 37 insertions(+), 0 deletions(-) > > Beside one minor comment: > > Acked-by: Heiko Schocher <hs@denx.de> > >> diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h >> index ca598a6..79cb098 100644 >> --- a/arch/sh/include/asm/io.h >> +++ b/arch/sh/include/asm/io.h >> @@ -237,6 +237,43 @@ static inline void sync(void) >> { >> } >> >> + >> +/* Clear and set bits in one shot. These macros can be used to clear and > > Wrong comment style, please fix. > > [...] > > bye, > Heiko > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h index ca598a6..79cb098 100644 --- a/arch/sh/include/asm/io.h +++ b/arch/sh/include/asm/io.h @@ -237,6 +237,43 @@ static inline void sync(void) { } + +/* Clear and set bits in one shot. These macros can be used to clear and + * set multiple bits in a register using a single call. These macros can + * also be used to set a multiple-bit bit pattern using a mask, by + * specifying the mask in the 'clear' parameter and the new bit pattern + * in the 'set' parameter. + */ + +#define clrbits(type, addr, clear) \ + out_##type((addr), in_##type(addr) & ~(clear)) + +#define setbits(type, addr, set) \ + out_##type((addr), in_##type(addr) | (set)) + +#define clrsetbits(type, addr, clear, set) \ + out_##type((addr), (in_##type(addr) & ~(clear)) | (set)) + +#define clrbits_be32(addr, clear) clrbits(be32, addr, clear) +#define setbits_be32(addr, set) setbits(be32, addr, set) +#define clrsetbits_be32(addr, clear, set) clrsetbits(be32, addr, clear, set) + +#define clrbits_le32(addr, clear) clrbits(le32, addr, clear) +#define setbits_le32(addr, set) setbits(le32, addr, set) +#define clrsetbits_le32(addr, clear, set) clrsetbits(le32, addr, clear, set) + +#define clrbits_be16(addr, clear) clrbits(be16, addr, clear) +#define setbits_be16(addr, set) setbits(be16, addr, set) +#define clrsetbits_be16(addr, clear, set) clrsetbits(be16, addr, clear, set) + +#define clrbits_le16(addr, clear) clrbits(le16, addr, clear) +#define setbits_le16(addr, set) setbits(le16, addr, set) +#define clrsetbits_le16(addr, clear, set) clrsetbits(le16, addr, clear, set) + +#define clrbits_8(addr, clear) clrbits(8, addr, clear) +#define setbits_8(addr, set) setbits(8, addr, set) +#define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set) + /* * Given a physical address and a length, return a virtual address * that can be used to access the memory range with the caching
This provide bit control functions as clrbits_*, setbits_* and clrsetbits_*. Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> --- arch/sh/include/asm/io.h | 37 +++++++++++++++++++++++++++++++++++++ 1 files changed, 37 insertions(+), 0 deletions(-)