| Message ID | 1322930775-4767-4-git-send-email-agust@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Remy Bohmer |
| Headers | show |
Hi, 2011/12/3 Anatolij Gustschin <agust@denx.de>: > Fix: > musb_udc.c: In function 'musb_peri_softconnect': > musb_udc.c:166:14: warning: variable 'intrtx' set but not used > [-Wunused-but-set-variable] > musb_udc.c:166:6: warning: variable 'intrrx' set but not used > [-Wunused-but-set-variable] > musb_udc.c:165:5: warning: variable 'intrusb' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: Remy Bohmer <linux@bohmer.net> > --- > drivers/usb/musb/musb_udc.c | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/musb/musb_udc.c b/drivers/usb/musb/musb_udc.c > index 6f6ed61..09cdec3 100644 > --- a/drivers/usb/musb/musb_udc.c > +++ b/drivers/usb/musb/musb_udc.c > @@ -162,8 +162,6 @@ static void musb_db_regs(void) > static void musb_peri_softconnect(void) > { > u8 power, devctl; > - u8 intrusb; > - u16 intrrx, intrtx; > > /* Power off MUSB */ > power = readb(&musbr->power); > @@ -171,9 +169,9 @@ static void musb_peri_softconnect(void) > writeb(power, &musbr->power); > > /* Read intr to clear */ > - intrusb = readb(&musbr->intrusb); > - intrrx = readw(&musbr->intrrx); > - intrtx = readw(&musbr->intrtx); > + readb(&musbr->intrusb); > + readw(&musbr->intrrx); > + readw(&musbr->intrtx); > > udelay(1000 * 1000); /* 1 sec */ Since it is part of a series with non-USB related changes: Acked-by: Remy Bohmer <linux@bohmer.net> Kind regards, Remy
> Fix: > musb_udc.c: In function 'musb_peri_softconnect': > musb_udc.c:166:14: warning: variable 'intrtx' set but not used > [-Wunused-but-set-variable] > musb_udc.c:166:6: warning: variable 'intrrx' set but not used > [-Wunused-but-set-variable] > musb_udc.c:165:5: warning: variable 'intrusb' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: Remy Bohmer <linux@bohmer.net> > --- > drivers/usb/musb/musb_udc.c | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/musb/musb_udc.c b/drivers/usb/musb/musb_udc.c > index 6f6ed61..09cdec3 100644 > --- a/drivers/usb/musb/musb_udc.c > +++ b/drivers/usb/musb/musb_udc.c > @@ -162,8 +162,6 @@ static void musb_db_regs(void) > static void musb_peri_softconnect(void) > { > u8 power, devctl; > - u8 intrusb; > - u16 intrrx, intrtx; > > /* Power off MUSB */ > power = readb(&musbr->power); > @@ -171,9 +169,9 @@ static void musb_peri_softconnect(void) > writeb(power, &musbr->power); > > /* Read intr to clear */ > - intrusb = readb(&musbr->intrusb); > - intrrx = readw(&musbr->intrrx); > - intrtx = readw(&musbr->intrtx); > + readb(&musbr->intrusb); > + readw(&musbr->intrrx); > + readw(&musbr->intrtx); > > udelay(1000 * 1000); /* 1 sec */ Acked-by: Marek Vasut <marek.vasut@gmail.com>
Dear Anatolij Gustschin, In message <1322930775-4767-4-git-send-email-agust@denx.de> you wrote: > Fix: > musb_udc.c: In function 'musb_peri_softconnect': > musb_udc.c:166:14: warning: variable 'intrtx' set but not used > [-Wunused-but-set-variable] > musb_udc.c:166:6: warning: variable 'intrrx' set but not used > [-Wunused-but-set-variable] > musb_udc.c:165:5: warning: variable 'intrusb' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: Remy Bohmer <linux@bohmer.net> > --- > drivers/usb/musb/musb_udc.c | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/drivers/usb/musb/musb_udc.c b/drivers/usb/musb/musb_udc.c index 6f6ed61..09cdec3 100644 --- a/drivers/usb/musb/musb_udc.c +++ b/drivers/usb/musb/musb_udc.c @@ -162,8 +162,6 @@ static void musb_db_regs(void) static void musb_peri_softconnect(void) { u8 power, devctl; - u8 intrusb; - u16 intrrx, intrtx; /* Power off MUSB */ power = readb(&musbr->power); @@ -171,9 +169,9 @@ static void musb_peri_softconnect(void) writeb(power, &musbr->power); /* Read intr to clear */ - intrusb = readb(&musbr->intrusb); - intrrx = readw(&musbr->intrrx); - intrtx = readw(&musbr->intrtx); + readb(&musbr->intrusb); + readw(&musbr->intrrx); + readw(&musbr->intrtx); udelay(1000 * 1000); /* 1 sec */
Fix: musb_udc.c: In function 'musb_peri_softconnect': musb_udc.c:166:14: warning: variable 'intrtx' set but not used [-Wunused-but-set-variable] musb_udc.c:166:6: warning: variable 'intrrx' set but not used [-Wunused-but-set-variable] musb_udc.c:165:5: warning: variable 'intrusb' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin <agust@denx.de> Cc: Remy Bohmer <linux@bohmer.net> --- drivers/usb/musb/musb_udc.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)