diff mbox

[U-Boot,v2,2/4] tegra2: Call gpio_request for SDMMC GPIOs

Message ID 1317749568-9657-2-git-send-email-swarren@nvidia.com
State Superseded, archived
Delegated to: Tom Warren
Headers show

Commit Message

Stephen Warren Oct. 4, 2011, 5:32 p.m. UTC
Without this, the GPIO_CNF register will not be programmed, and hence the
GPIO signals will not reach the pins; the pinmux's configured function
will be routed to the pins instead.

v2: s/SDMMC4/SDMMC3/ in strings passed to gpio_request().

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 board/nvidia/seaboard/seaboard.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Simon Glass Oct. 4, 2011, 11:56 p.m. UTC | #1
On Tue, Oct 4, 2011 at 10:32 AM, Stephen Warren <swarren@nvidia.com> wrote:
> Without this, the GPIO_CNF register will not be programmed, and hence the
> GPIO signals will not reach the pins; the pinmux's configured function
> will be routed to the pins instead.
>
> v2: s/SDMMC4/SDMMC3/ in strings passed to gpio_request().
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  board/nvidia/seaboard/seaboard.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c
> index bc67d0f..1310e3d 100644
> --- a/board/nvidia/seaboard/seaboard.c
> +++ b/board/nvidia/seaboard/seaboard.c
> @@ -62,9 +62,11 @@ void gpio_config_uart(void)
>  void gpio_config_mmc(void)
>  {
>        /* Set EN_VDDIO_SD (GPIO I6) */
> +       gpio_request(GPIO_PI6, "SDMMC3 power");
>        gpio_direction_output(GPIO_PI6, 1);
>
>        /* Config pin as GPI for Card Detect (GPIO I5) */
> +       gpio_request(GPIO_PI5, "SDMMC3 card detect");
>        gpio_direction_input(GPIO_PI5);
>  }
>
> --
> 1.7.0.4
>
>
diff mbox

Patch

diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c
index bc67d0f..1310e3d 100644
--- a/board/nvidia/seaboard/seaboard.c
+++ b/board/nvidia/seaboard/seaboard.c
@@ -62,9 +62,11 @@  void gpio_config_uart(void)
 void gpio_config_mmc(void)
 {
 	/* Set EN_VDDIO_SD (GPIO I6) */
+	gpio_request(GPIO_PI6, "SDMMC3 power");
 	gpio_direction_output(GPIO_PI6, 1);
 
 	/* Config pin as GPI for Card Detect (GPIO I5) */
+	gpio_request(GPIO_PI5, "SDMMC3 card detect");
 	gpio_direction_input(GPIO_PI5);
 }