From patchwork Fri Apr 1 22:35:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Holler X-Patchwork-Id: 89362 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 46E59B6FAB for ; Sat, 2 Apr 2011 09:36:04 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 00A2E2814B; Sat, 2 Apr 2011 00:36:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wOGFm8uT8mTo; Sat, 2 Apr 2011 00:36:02 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7DAF62812D; Sat, 2 Apr 2011 00:36:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 23BEE2813F for ; Sat, 2 Apr 2011 00:35:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4T5JFEvx2Ol0 for ; Sat, 2 Apr 2011 00:35:59 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail.ahsoftware.de (h1446028.stratoserver.net [85.214.92.142]) by theia.denx.de (Postfix) with ESMTP id 047222812D for ; Sat, 2 Apr 2011 00:35:56 +0200 (CEST) Received: by mail.ahsoftware.de (Postfix, from userid 65534) id C2CC1434835; Sat, 2 Apr 2011 00:35:56 +0200 (CEST) Received: from eiche.ahsoftware (p57B21082.dip0.t-ipconnect.de [87.178.16.130]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.ahsoftware.de (Postfix) with ESMTPSA id 8A652434833; Sat, 2 Apr 2011 00:35:55 +0200 (CEST) Received: from beagle.ahsoftware (conradbt.ahsoftware [192.168.213.4]) by eiche.ahsoftware (Postfix) with ESMTP id 834733FD2F; Sat, 2 Apr 2011 00:35:53 +0200 (CEST) From: Alexander Holler To: u-boot@lists.denx.de Date: Sat, 2 Apr 2011 00:35:44 +0200 Message-Id: <1301697344-4033-1-git-send-email-holler@ahsoftware.de> X-Mailer: git-send-email 1.7.3.4 Subject: [U-Boot] [PATCH] USB: Remove __attribute__ ((packed)) for struct ehci_hccr and ehci_hcor. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Remove __attribute__ ((packed)) to prevent byte access to soc registers in some gcc versions. Having patches to enable ehci for the BeagleBoard lying around for several month, this one was the show-stopper. Credits have to go to Laine Walker-Avina for finding the problem. Signed-off-by: Alexander Holler --- drivers/usb/host/ehci.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index 945ab64..df9f055 100644 --- a/drivers/usb/host/ehci.h +++ b/drivers/usb/host/ehci.h @@ -55,7 +55,7 @@ struct ehci_hccr { #define HCS_N_PORTS(p) (((p) >> 0) & 0xf) uint32_t cr_hccparams; uint8_t cr_hcsp_portrt[8]; -} __attribute__ ((packed)); +}; struct ehci_hcor { uint32_t or_usbcmd; @@ -85,7 +85,7 @@ struct ehci_hcor { #define FLAG_CF (1 << 0) /* true: we'll support "high speed" */ uint32_t or_portsc[CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS]; uint32_t or_systune; -} __attribute__ ((packed)); +}; #define USBMODE 0x68 /* USB Device mode */ #define USBMODE_SDIS (1 << 3) /* Stream disable */