diff mbox

[U-Boot] omap3_beagle: Switch default console from ttyS2 to ttyO2

Message ID 1298018277-7436-1-git-send-email-holler@ahsoftware.de
State Accepted
Delegated to: Sandeep Paulraj
Headers show

Commit Message

Alexander Holler Feb. 18, 2011, 8:37 a.m. UTC
Linux kernels >= 2.6.36 are using ttyOn instead ttySn for the
serials on OMAPs.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
 include/configs/omap3_beagle.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Jason Kridner March 1, 2011, 11:13 p.m. UTC | #1
On Fri, Feb 18, 2011 at 3:37 AM, Alexander Holler <holler@ahsoftware.de> wrote:
> Linux kernels >= 2.6.36 are using ttyOn instead ttySn for the
> serials on OMAPs.
>
> Signed-off-by: Alexander Holler <holler@ahsoftware.de>

Ack.

> ---
>  include/configs/omap3_beagle.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index 5cfa4cb..e442e5b 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -189,7 +189,7 @@
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>        "loadaddr=0x82000000\0" \
>        "usbtty=cdc_acm\0" \
> -       "console=ttyS2,115200n8\0" \
> +       "console=ttyO2,115200n8\0" \
>        "mpurate=500\0" \
>        "vram=12M\0" \
>        "dvimode=1024x768MR-16@60\0" \
> --
> 1.7.3.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Thomas Weber March 2, 2011, 10:50 a.m. UTC | #2
Hello Alexander,
Am 02.03.2011 00:13, schrieb Jason Kridner:
> On Fri, Feb 18, 2011 at 3:37 AM, Alexander Holler <holler@ahsoftware.de> wrote:
>> Linux kernels >= 2.6.36 are using ttyOn instead ttySn for the
>> serials on OMAPs.
>>
>> Signed-off-by: Alexander Holler <holler@ahsoftware.de>
> 
> Ack.
> 
>> ---
>>  include/configs/omap3_beagle.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index 5cfa4cb..e442e5b 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -189,7 +189,7 @@
>>  #define CONFIG_EXTRA_ENV_SETTINGS \
>>        "loadaddr=0x82000000\0" \
>>        "usbtty=cdc_acm\0" \
>> -       "console=ttyS2,115200n8\0" \
>> +       "console=ttyO2,115200n8\0" \
>>        "mpurate=500\0" \
>>        "vram=12M\0" \
>>        "dvimode=1024x768MR-16@60\0" \
>> --
>> 1.7.3.4

can you please do this for all omap3 boards?
Or we have in the end 10 patches for the same problem.

Thomas
Alexander Holler March 2, 2011, 11 a.m. UTC | #3
Hello,

Am 02.03.2011 11:50, schrieb Thomas Weber:
> Hello Alexander,
> Am 02.03.2011 00:13, schrieb Jason Kridner:
>> On Fri, Feb 18, 2011 at 3:37 AM, Alexander Holler<holler@ahsoftware.de>  wrote:
>>> Linux kernels>= 2.6.36 are using ttyOn instead ttySn for the
>>> serials on OMAPs.

...

> can you please do this for all omap3 boards?
> Or we have in the end 10 patches for the same problem.

Sorry, no. I don't know which boards are using which kernel versions and 
there are many boards around with and SDK which are using older kernels. 
I think the time of the change should be decided by every board-maintainer.

Regards,

Alexander
Albert ARIBAUD March 24, 2011, 1:01 p.m. UTC | #4
Cc:ing Dirk as the omap3_beagle maintainer, and Wolfgang for advice.

Le 02/03/2011 12:00, Alexander Holler a écrit :
> Hello,
>
> Am 02.03.2011 11:50, schrieb Thomas Weber:
>> Hello Alexander,
>> Am 02.03.2011 00:13, schrieb Jason Kridner:
>>> On Fri, Feb 18, 2011 at 3:37 AM, Alexander Holler<holler@ahsoftware.de>   wrote:
>>>> Linux kernels>= 2.6.36 are using ttyOn instead ttySn for the
>>>> serials on OMAPs.
>
> ....
>
>> can you please do this for all omap3 boards?
>> Or we have in the end 10 patches for the same problem.
>
> Sorry, no. I don't know which boards are using which kernel versions and
> there are many boards around with and SDK which are using older kernels.
> I think the time of the change should be decided by every board-maintainer.
>
> Regards,
>
> Alexander

Apart from Thomas' question, there seems to be no Nak for this patch -- 
I've taken the liberty to Cc: the board maintainer just in case -- so we 
might as well apply it.

Wolfgang, which tree is this patch supposed to go through? Mine because 
the board is ARM? yours because it is a board, not arch, patch? Or 
whichever?

If mine is ok then I'll apply it to next as in any cas it is not a bugfix.

Amicalement,
Alexander Holler March 24, 2011, 1:51 p.m. UTC | #5
Am 24.03.2011 14:01, schrieb Albert ARIBAUD:
> Cc:ing Dirk as the omap3_beagle maintainer, and Wolfgang for advice.
...
> Apart from Thomas' question, there seems to be no Nak for this patch --
> I've taken the liberty to Cc: the board maintainer just in case -- so we
> might as well apply it.
>
> Wolfgang, which tree is this patch supposed to go through? Mine because
> the board is ARM? yours because it is a board, not arch, patch? Or
> whichever?

Oh, sorry, haven't seen that Dirk is the maintainer, I've only added the 
TI-maintainer to cc, which might be wrong.

Regards,

Alexander Holler
Wolfgang Denk March 24, 2011, 7:36 p.m. UTC | #6
Dear Albert ARIBAUD,

In message <4D8B40BE.9070702@free.fr> you wrote:
>
> Wolfgang, which tree is this patch supposed to go through? Mine because 
> the board is ARM? yours because it is a board, not arch, patch? Or 
> whichever?

Formally it would need Dirk's ACK and then go though the TI tree and
then yours.  Alternatively, Sandeep's ACK would be needed, too.

Best regards,

Wolfgang Denk
Dirk Behme March 24, 2011, 7:55 p.m. UTC | #7
On 02.03.2011 00:13, Jason Kridner wrote:
> On Fri, Feb 18, 2011 at 3:37 AM, Alexander Holler<holler@ahsoftware.de>  wrote:
>> Linux kernels>= 2.6.36 are using ttyOn instead ttySn for the
>> serials on OMAPs.
>>
>> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>
> Ack.

Acked-by: Dirk Behme <dirk.behme@googlemail.com>

>> ---
>>   include/configs/omap3_beagle.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index 5cfa4cb..e442e5b 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -189,7 +189,7 @@
>>   #define CONFIG_EXTRA_ENV_SETTINGS \
>>         "loadaddr=0x82000000\0" \
>>         "usbtty=cdc_acm\0" \
>> -       "console=ttyS2,115200n8\0" \
>> +       "console=ttyO2,115200n8\0" \
>>         "mpurate=500\0" \
>>         "vram=12M\0" \
>>         "dvimode=1024x768MR-16@60\0" \
>> --
>> 1.7.3.4
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
diff mbox

Patch

diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index 5cfa4cb..e442e5b 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -189,7 +189,7 @@ 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"loadaddr=0x82000000\0" \
 	"usbtty=cdc_acm\0" \
-	"console=ttyS2,115200n8\0" \
+	"console=ttyO2,115200n8\0" \
 	"mpurate=500\0" \
 	"vram=12M\0" \
 	"dvimode=1024x768MR-16@60\0" \