| Message ID | 1294152639-27552-2-git-send-email-leiwen@marvell.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
> -----Original Message----- > From: Lei Wen [mailto:leiwen@marvell.com] > Sent: Tuesday, January 04, 2011 8:21 PM > To: u-boot@lists.denx.de; Prafulla Wadaskar; Yu Tang; Ashish Karkare; > Prabhanjan Sarnaik; adrian.wenl@gmail.com > Subject: [U-BOOT] [PATCH 2/6] mv: seperate kirkwood and mmp from common > setting > > Since there are lots of difference between kirkwood and mmp series, What is mmp? > it is better to seperate them but still keep the most common file > shared by all marvell platform in the mv-common configure file. > > This patch move the kirkwood only driver definitoin in mv-common to > the kirkwood.h and it is tested with compilation for armada100 and I think you need to specify config.h instead of Kirkwood.h?? > guruplug. > > Signed-off-by: Lei Wen <leiwen@marvell.com> > --- > arch/arm/include/asm/arch-armada100/config.h | 50 ++++++++ > arch/arm/include/asm/arch-kirkwood/config.h | 170 > ++++++++++++++++++++++++++ > include/configs/aspenite.h | 1 + > include/configs/mv-common.h | 154 +------------------ > ----- > 4 files changed, 223 insertions(+), 152 deletions(-) > create mode 100644 arch/arm/include/asm/arch-armada100/config.h > create mode 100644 arch/arm/include/asm/arch-kirkwood/config.h > > diff --git a/arch/arm/include/asm/arch-armada100/config.h > b/arch/arm/include/asm/arch-armada100/config.h > new file mode 100644 > index 0000000..9c18b1c > --- /dev/null > +++ b/arch/arm/include/asm/arch-armada100/config.h > @@ -0,0 +1,50 @@ > +/* > + * (C) Copyright 2010 > + * Marvell Semiconductor <www.marvell.com> > + * Written-by: Lei Wen <leiwen@marvell.com> > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, > + * MA 02110-1301 USA > + */ > + > +/* > + * This file should be included in board config header file. Should be included to mv-common.h > + * > + * It supports common definations for MMP platform Spell check s/definition/definition/g What is MMP? Replace it with ARMADA100 > + */ > + > +#ifndef _ARMADA100_H > +#define _ARMADA100_H Should be _ARMD1_CONFIG_H > + > +#define CONFIG_ARM926EJS 1 /* Basic Architecture */ > + > +#define CONFIG_SYS_TCLK (14745600) /* NS16550 clk config */ > +#define CONFIG_SYS_HZ_CLOCK (3250000) /* Timer Freq. 3.25MHZ */ > +#define CONFIG_MARVELL_MFP /* Enable mvmfp driver */ > +#define MV_MFPR_BASE ARMD1_MFPR_BASE > +#define MV_UART_CONSOLE_BASE ARMD1_UART1_BASE > +#define CONFIG_SYS_NS16550_IER (1 << 6) /* Bit 6 in UART_IER register > + represents UART Unit Enable */ > +/* > + * There is no internal RAM in ARMADA100, using DRAM > + * TBD: dcache to be used for this > + */ > +#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_TEXT_BASE - > 0x00200000) > +#define CONFIG_NR_DRAM_BANKS_MAX 2 > + > +#endif /* _ARMADA100_H */ > diff --git a/arch/arm/include/asm/arch-kirkwood/config.h > b/arch/arm/include/asm/arch-kirkwood/config.h > new file mode 100644 > index 0000000..0a15e6b > --- /dev/null > +++ b/arch/arm/include/asm/arch-kirkwood/config.h > @@ -0,0 +1,170 @@ > +/* > + * (C) Copyright 2010 > + * Marvell Semiconductor <www.marvell.com> > + * Written-by: Lei Wen <leiwen@marvell.com> > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, > + * MA 02110-1301 USA > + */ > + > +/* > + * This file should be included in board config header file. Ditto > + * > + * It supports common definations for Kirkwood platform Definitions > + * TBD: support for Orion5X platforms This line stands invalid here. > + */ > + > +#ifndef _MV_KIRKWOOD_H > +#define _MV_KIRKWOOD_H Should be _KW_CONFIG_H > + > +#if defined (CONFIG_KW88F6281) > +#include <asm/arch/kw88f6281.h> > +#elif defined (CONFIG_KW88F6192) > +#include <asm/arch/kw88f6192.h> > +#else > +#error "SOC Name not defined" > +#endif /* CONFIG_KW88F6281 */ > + > +#define CONFIG_ARM926EJS 1 /* Basic Architecture */ > + > +#define CONFIG_MD5 /* get_random_hex on krikwood needs MD5 support */ > +#define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */ > +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8 /* Set RGMII Pad voltage to 1.8V > */ > +#define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel > */ > + > +/* > + * By default kwbimage.cfg from board specific folder is used > + * If for some board, different configuration file need to be used, > + * CONFIG_SYS_KWD_CONFIG should be defined in board specific header > file > + */ > +#ifndef CONFIG_SYS_KWD_CONFIG > +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.cfg > +#endif /* CONFIG_SYS_KWD_CONFIG */ > + > +/* Kirkwood has 2k of Security SRAM, use it for SP */ > +#define CONFIG_SYS_INIT_SP_ADDR 0xC8012000 > +#define CONFIG_NR_DRAM_BANKS_MAX 2 > + > +#define CONFIG_I2C_MVTWSI_BASE KW_TWSI_BASE > +#define MV_UART_CONSOLE_BASE KW_UART0_BASE > +#define MV_SATA_BASE KW_SATA_BASE > +#define MV_SATA_PORT0_OFFSET KW_SATA_PORT0_OFFSET > +#define MV_SATA_PORT1_OFFSET KW_SATA_PORT1_OFFSET > + > +/* > + * NAND configuration > + */ > +#ifdef CONFIG_CMD_NAND > +#define CONFIG_NAND_KIRKWOOD > +#define CONFIG_SYS_MAX_NAND_DEVICE 1 > +#define NAND_MAX_CHIPS 1 > +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* MV_DEFADR_NANDF */ > +#define NAND_ALLOW_ERASE_ALL 1 > +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ > +#endif > + I think split below makes more sense- overall objective is to avoid code duplication here. For mv-common.h +/* + * NAND configuration + */ +#ifdef CONFIG_CMD_NAND +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define NAND_MAX_CHIPS 1 +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ +#endif For arch-kirkwood/config.h +/* + * NAND configuration + */ +#ifdef CONFIG_CMD_NAND +#define CONFIG_NAND_KIRKWOOD +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* MV_DEFADR_NANDF */ +#define NAND_ALLOW_ERASE_ALL 1 +#endif > +/* > + * SPI Flash configuration > + */ > +#ifdef CONFIG_CMD_SF > +#define CONFIG_SPI_FLASH 1 > +#define CONFIG_HARD_SPI 1 > +#define CONFIG_KIRKWOOD_SPI 1 > +#define CONFIG_SPI_FLASH_MACRONIX 1 > +#define CONFIG_ENV_SPI_BUS 0 > +#define CONFIG_ENV_SPI_CS 0 > +#define CONFIG_ENV_SPI_MAX_HZ 50000000 /*50Mhz */ > +#endif > + Same applies for rest of the definitions. mv-common.h should represent common definitions for Kirkwood,armada100, and future SoCs based boards so that respective boardconfig header file can be thin. Regards.. Prafulla . .
On Wed, Jan 5, 2011 at 5:40 PM, Prafulla Wadaskar <prafulla@marvell.com> wrote: > > >> -----Original Message----- >> From: Lei Wen [mailto:leiwen@marvell.com] >> Sent: Tuesday, January 04, 2011 8:21 PM >> To: u-boot@lists.denx.de; Prafulla Wadaskar; Yu Tang; Ashish Karkare; >> Prabhanjan Sarnaik; adrian.wenl@gmail.com >> Subject: [U-BOOT] [PATCH 2/6] mv: seperate kirkwood and mmp from common >> setting >> >> Since there are lots of difference between kirkwood and mmp series, > > What is mmp? mmp is what we call it in Linux kernel, as you already use armada, we also could use armada series here. > >> it is better to seperate them but still keep the most common file >> shared by all marvell platform in the mv-common configure file. >> >> This patch move the kirkwood only driver definitoin in mv-common to >> the kirkwood.h and it is tested with compilation for armada100 and > > I think you need to specify config.h instead of Kirkwood.h?? Yes, it should be config.h here. > >> guruplug. >> >> Signed-off-by: Lei Wen <leiwen@marvell.com> >> --- >> arch/arm/include/asm/arch-armada100/config.h | 50 ++++++++ >> arch/arm/include/asm/arch-kirkwood/config.h | 170 >> ++++++++++++++++++++++++++ >> include/configs/aspenite.h | 1 + >> include/configs/mv-common.h | 154 +------------------ >> ----- >> 4 files changed, 223 insertions(+), 152 deletions(-) >> create mode 100644 arch/arm/include/asm/arch-armada100/config.h >> create mode 100644 arch/arm/include/asm/arch-kirkwood/config.h >> >> diff --git a/arch/arm/include/asm/arch-armada100/config.h >> b/arch/arm/include/asm/arch-armada100/config.h >> new file mode 100644 >> index 0000000..9c18b1c >> --- /dev/null >> +++ b/arch/arm/include/asm/arch-armada100/config.h >> @@ -0,0 +1,50 @@ >> +/* >> + * (C) Copyright 2010 >> + * Marvell Semiconductor <www.marvell.com> >> + * Written-by: Lei Wen <leiwen@marvell.com> >> + * >> + * See file CREDITS for list of people who contributed to this >> + * project. >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of >> + * the License, or (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, >> + * MA 02110-1301 USA >> + */ >> + >> +/* >> + * This file should be included in board config header file. > > Should be included to mv-common.h Apply this for the next patch submit... > >> + * >> + * It supports common definations for MMP platform > > Spell check s/definition/definition/g > What is MMP? Replace it with ARMADA100 Apply this for the next patch submit... > >> + */ >> + >> +#ifndef _ARMADA100_H >> +#define _ARMADA100_H > > Should be _ARMD1_CONFIG_H Ok.. > >> + >> +#define CONFIG_ARM926EJS 1 /* Basic Architecture */ >> + >> +#define CONFIG_SYS_TCLK (14745600) /* NS16550 clk config */ >> +#define CONFIG_SYS_HZ_CLOCK (3250000) /* Timer Freq. 3.25MHZ */ >> +#define CONFIG_MARVELL_MFP /* Enable mvmfp driver */ >> +#define MV_MFPR_BASE ARMD1_MFPR_BASE >> +#define MV_UART_CONSOLE_BASE ARMD1_UART1_BASE >> +#define CONFIG_SYS_NS16550_IER (1 << 6) /* Bit 6 in UART_IER register >> + represents UART Unit Enable */ >> +/* >> + * There is no internal RAM in ARMADA100, using DRAM >> + * TBD: dcache to be used for this >> + */ >> +#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_TEXT_BASE - >> 0x00200000) >> +#define CONFIG_NR_DRAM_BANKS_MAX 2 >> + >> +#endif /* _ARMADA100_H */ >> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h >> b/arch/arm/include/asm/arch-kirkwood/config.h >> new file mode 100644 >> index 0000000..0a15e6b >> --- /dev/null >> +++ b/arch/arm/include/asm/arch-kirkwood/config.h >> @@ -0,0 +1,170 @@ >> +/* >> + * (C) Copyright 2010 >> + * Marvell Semiconductor <www.marvell.com> >> + * Written-by: Lei Wen <leiwen@marvell.com> >> + * >> + * See file CREDITS for list of people who contributed to this >> + * project. >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of >> + * the License, or (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, >> + * MA 02110-1301 USA >> + */ >> + >> +/* >> + * This file should be included in board config header file. > > Ditto > >> + * >> + * It supports common definations for Kirkwood platform > > Definitions > >> + * TBD: support for Orion5X platforms > > > This line stands invalid here. > >> + */ >> + >> +#ifndef _MV_KIRKWOOD_H >> +#define _MV_KIRKWOOD_H > > Should be _KW_CONFIG_H Ok.. > >> + >> +#if defined (CONFIG_KW88F6281) >> +#include <asm/arch/kw88f6281.h> >> +#elif defined (CONFIG_KW88F6192) >> +#include <asm/arch/kw88f6192.h> >> +#else >> +#error "SOC Name not defined" >> +#endif /* CONFIG_KW88F6281 */ >> + >> +#define CONFIG_ARM926EJS 1 /* Basic Architecture */ >> + >> +#define CONFIG_MD5 /* get_random_hex on krikwood needs MD5 support */ >> +#define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */ >> +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8 /* Set RGMII Pad voltage to 1.8V >> */ >> +#define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel >> */ >> + >> +/* >> + * By default kwbimage.cfg from board specific folder is used >> + * If for some board, different configuration file need to be used, >> + * CONFIG_SYS_KWD_CONFIG should be defined in board specific header >> file >> + */ >> +#ifndef CONFIG_SYS_KWD_CONFIG >> +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.cfg >> +#endif /* CONFIG_SYS_KWD_CONFIG */ >> + >> +/* Kirkwood has 2k of Security SRAM, use it for SP */ >> +#define CONFIG_SYS_INIT_SP_ADDR 0xC8012000 >> +#define CONFIG_NR_DRAM_BANKS_MAX 2 >> + >> +#define CONFIG_I2C_MVTWSI_BASE KW_TWSI_BASE >> +#define MV_UART_CONSOLE_BASE KW_UART0_BASE >> +#define MV_SATA_BASE KW_SATA_BASE >> +#define MV_SATA_PORT0_OFFSET KW_SATA_PORT0_OFFSET >> +#define MV_SATA_PORT1_OFFSET KW_SATA_PORT1_OFFSET >> + >> +/* >> + * NAND configuration >> + */ >> +#ifdef CONFIG_CMD_NAND >> +#define CONFIG_NAND_KIRKWOOD >> +#define CONFIG_SYS_MAX_NAND_DEVICE 1 >> +#define NAND_MAX_CHIPS 1 >> +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* MV_DEFADR_NANDF */ >> +#define NAND_ALLOW_ERASE_ALL 1 >> +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ >> +#endif >> + > > I think split below makes more sense- overall objective is to avoid code duplication here. > > For mv-common.h > +/* > + * NAND configuration > + */ > +#ifdef CONFIG_CMD_NAND > +#define CONFIG_SYS_MAX_NAND_DEVICE 1 > +#define NAND_MAX_CHIPS 1 > +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ > +#endif > > For arch-kirkwood/config.h > +/* > + * NAND configuration > + */ > +#ifdef CONFIG_CMD_NAND > +#define CONFIG_NAND_KIRKWOOD > +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* MV_DEFADR_NANDF */ > +#define NAND_ALLOW_ERASE_ALL 1 > +#endif > >> +/* >> + * SPI Flash configuration >> + */ >> +#ifdef CONFIG_CMD_SF >> +#define CONFIG_SPI_FLASH 1 >> +#define CONFIG_HARD_SPI 1 >> +#define CONFIG_KIRKWOOD_SPI 1 >> +#define CONFIG_SPI_FLASH_MACRONIX 1 >> +#define CONFIG_ENV_SPI_BUS 0 >> +#define CONFIG_ENV_SPI_CS 0 >> +#define CONFIG_ENV_SPI_MAX_HZ 50000000 /*50Mhz */ >> +#endif >> + > > Same applies for rest of the definitions. > mv-common.h should represent common definitions for Kirkwood,armada100, and future SoCs based boards so that > Yes, agree... Since current armada100 havn't added nand and spi support, how about move those nand and spi definition to kirkwood and then after armada100 add the nand, we reconsider to move back the common back? Especially for those code below, I really believe this should not be put into the common code... #ifndef CONFIG_ARMADA100 /* will be removed latter */-#define CONFIG_CMD_EXT2 #define CONFIG_CMD_JFFS2 #define CONFIG_CMD_FAT #define CONFIG_CMD_UBI #define CONFIG_CMD_UBIFS #define CONFIG_RBTREE #define CONFIG_MTD_DEVICE /* needed for mtdparts commands */ #define CONFIG_MTD_PARTITIONS #define CONFIG_CMD_MTDPARTS #define CONFIG_LZO #endif Best regards, Lei
> -----Original Message----- > From: Lei Wen [mailto:adrian.wenl@gmail.com] > Sent: Wednesday, January 05, 2011 8:59 PM > To: Prafulla Wadaskar > Cc: Lei Wen; u-boot@lists.denx.de; Yu Tang; Ashish Karkare; Prabhanjan > Sarnaik > Subject: Re: [U-BOOT] [PATCH 2/6] mv: seperate kirkwood and mmp from > common setting > ...snip... > >> + * NAND configuration > >> + */ > >> +#ifdef CONFIG_CMD_NAND > >> +#define CONFIG_NAND_KIRKWOOD > >> +#define CONFIG_SYS_MAX_NAND_DEVICE 1 > >> +#define NAND_MAX_CHIPS 1 > >> +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* > MV_DEFADR_NANDF */ > >> +#define NAND_ALLOW_ERASE_ALL 1 > >> +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ > >> +#endif > >> + > > > > I think split below makes more sense- overall objective is to avoid > code duplication here. > > > > For mv-common.h > > +/* > > + * NAND configuration > > + */ > > +#ifdef CONFIG_CMD_NAND > > +#define CONFIG_SYS_MAX_NAND_DEVICE 1 > > +#define NAND_MAX_CHIPS 1 > > +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ > > +#endif > > > > For arch-kirkwood/config.h > > +/* > > + * NAND configuration > > + */ > > +#ifdef CONFIG_CMD_NAND > > +#define CONFIG_NAND_KIRKWOOD > > +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* > MV_DEFADR_NANDF */ > > +#define NAND_ALLOW_ERASE_ALL 1 > > +#endif > > > >> +/* > >> + * SPI Flash configuration > >> + */ > >> +#ifdef CONFIG_CMD_SF > >> +#define CONFIG_SPI_FLASH 1 > >> +#define CONFIG_HARD_SPI 1 > >> +#define CONFIG_KIRKWOOD_SPI 1 > >> +#define CONFIG_SPI_FLASH_MACRONIX 1 > >> +#define CONFIG_ENV_SPI_BUS 0 > >> +#define CONFIG_ENV_SPI_CS 0 > >> +#define CONFIG_ENV_SPI_MAX_HZ 50000000 /*50Mhz > */ > >> +#endif > >> + > > > > Same applies for rest of the definitions. > > mv-common.h should represent common definitions for > Kirkwood,armada100, and future SoCs based boards so that > > > Yes, agree... > Since current armada100 havn't added nand and spi support, how about > move those nand and spi definition to kirkwood and > then after armada100 add the nand, we reconsider to move back the common > back? On the other hand, keep your patch small by not moving this driver specific stuff to arch-kirkwood/config.h. As new common driver will get supported on armada100, we will push them to config.h, this way even future patches will also be smaller. > > Especially for those code below, I really believe this should not be > put into the common code... > #ifndef CONFIG_ARMADA100 /* will be removed latter */-#define > CONFIG_CMD_EXT2 > #define CONFIG_CMD_JFFS2 > #define CONFIG_CMD_FAT > #define CONFIG_CMD_UBI > #define CONFIG_CMD_UBIFS > #define CONFIG_RBTREE > #define CONFIG_MTD_DEVICE /* needed for mtdparts commands > */ > #define CONFIG_MTD_PARTITIONS > #define CONFIG_CMD_MTDPARTS > #define CONFIG_LZO > #endif Well, we can.. only replace #ifndef CONFIG_ARMADA100 with #ifdef CONFIG_SYS_MVFS and define this macro in arch-kirkwood/config.h, this way in future after enabling ide, nand, spi driver support just defining the same macro in armada100/config.h will enable the file system support for armada100 platforms. Regards.. Prafulla . .
Hi Prafula, On Thu, Jan 6, 2011 at 2:23 AM, Prafulla Wadaskar <prafulla@marvell.com> wrote: > > >> -----Original Message----- >> From: Lei Wen [mailto:adrian.wenl@gmail.com] >> Sent: Wednesday, January 05, 2011 8:59 PM >> To: Prafulla Wadaskar >> Cc: Lei Wen; u-boot@lists.denx.de; Yu Tang; Ashish Karkare; Prabhanjan >> Sarnaik >> Subject: Re: [U-BOOT] [PATCH 2/6] mv: seperate kirkwood and mmp from >> common setting >> > ...snip... >> >> + * NAND configuration >> >> + */ >> >> +#ifdef CONFIG_CMD_NAND >> >> +#define CONFIG_NAND_KIRKWOOD >> >> +#define CONFIG_SYS_MAX_NAND_DEVICE 1 >> >> +#define NAND_MAX_CHIPS 1 >> >> +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* >> MV_DEFADR_NANDF */ >> >> +#define NAND_ALLOW_ERASE_ALL 1 >> >> +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ >> >> +#endif >> >> + >> > >> > I think split below makes more sense- overall objective is to avoid >> code duplication here. >> > >> > For mv-common.h >> > +/* >> > + * NAND configuration >> > + */ >> > +#ifdef CONFIG_CMD_NAND >> > +#define CONFIG_SYS_MAX_NAND_DEVICE 1 >> > +#define NAND_MAX_CHIPS 1 >> > +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ >> > +#endif >> > >> > For arch-kirkwood/config.h >> > +/* >> > + * NAND configuration >> > + */ >> > +#ifdef CONFIG_CMD_NAND >> > +#define CONFIG_NAND_KIRKWOOD >> > +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* >> MV_DEFADR_NANDF */ >> > +#define NAND_ALLOW_ERASE_ALL 1 >> > +#endif >> > >> >> +/* >> >> + * SPI Flash configuration >> >> + */ >> >> +#ifdef CONFIG_CMD_SF >> >> +#define CONFIG_SPI_FLASH 1 >> >> +#define CONFIG_HARD_SPI 1 >> >> +#define CONFIG_KIRKWOOD_SPI 1 >> >> +#define CONFIG_SPI_FLASH_MACRONIX 1 >> >> +#define CONFIG_ENV_SPI_BUS 0 >> >> +#define CONFIG_ENV_SPI_CS 0 >> >> +#define CONFIG_ENV_SPI_MAX_HZ 50000000 /*50Mhz >> */ >> >> +#endif >> >> + >> > >> > Same applies for rest of the definitions. >> > mv-common.h should represent common definitions for >> Kirkwood,armada100, and future SoCs based boards so that >> > >> Yes, agree... >> Since current armada100 havn't added nand and spi support, how about >> move those nand and spi definition to kirkwood and >> then after armada100 add the nand, we reconsider to move back the common >> back? > > On the other hand, keep your patch small by not moving this driver specific stuff to arch-kirkwood/config.h. > > As new common driver will get supported on armada100, we will push them to config.h, this way even future patches will also be smaller. > >> >> Especially for those code below, I really believe this should not be >> put into the common code... >> #ifndef CONFIG_ARMADA100 /* will be removed latter */-#define >> CONFIG_CMD_EXT2 >> #define CONFIG_CMD_JFFS2 >> #define CONFIG_CMD_FAT >> #define CONFIG_CMD_UBI >> #define CONFIG_CMD_UBIFS >> #define CONFIG_RBTREE >> #define CONFIG_MTD_DEVICE /* needed for mtdparts commands >> */ >> #define CONFIG_MTD_PARTITIONS >> #define CONFIG_CMD_MTDPARTS >> #define CONFIG_LZO >> #endif > > Well, we can.. > only replace #ifndef CONFIG_ARMADA100 with #ifdef CONFIG_SYS_MVFS and define this macro in arch-kirkwood/config.h, this way in future after enabling ide, nand, spi driver support just defining the same macro in armada100/config.h will enable the file system support for armada100 platforms. I think not all platform under marvell would need to enable all those configure... What if it only want to enable one setting from this big group, like it only want the CONFIG_CMD_FAT, then you need to it set the CONFIG_SYS_MVFS with other unnessary setting enabled... It increase the image file size... and I don't think a bootloader should have full function support that uboot can support... Each board should tailor this fs setting by its willing, not set all by default... For this patch set, if you think it just should keep patch small, I can leave it at this moment. But I think it should be move board specific configure file, like kirkwood/config.h... Thanks, Lei
> -----Original Message----- > From: Lei Wen [mailto:adrian.wenl@gmail.com] > Sent: Thursday, January 06, 2011 8:59 AM > To: Prafulla Wadaskar > Cc: Lei Wen; u-boot@lists.denx.de; Yu Tang; Ashish Karkare; Prabhanjan > Sarnaik > Subject: Re: [U-BOOT] [PATCH 2/6] mv: seperate kirkwood and mmp from > common setting ...snip... > >> put into the common code... > >> #ifndef CONFIG_ARMADA100 /* will be removed latter */-#define > >> CONFIG_CMD_EXT2 > >> #define CONFIG_CMD_JFFS2 > >> #define CONFIG_CMD_FAT > >> #define CONFIG_CMD_UBI > >> #define CONFIG_CMD_UBIFS > >> #define CONFIG_RBTREE > >> #define CONFIG_MTD_DEVICE /* needed for mtdparts > commands > >> */ > >> #define CONFIG_MTD_PARTITIONS > >> #define CONFIG_CMD_MTDPARTS > >> #define CONFIG_LZO > >> #endif > > > > Well, we can.. > > only replace #ifndef CONFIG_ARMADA100 with #ifdef CONFIG_SYS_MVFS and > define this macro in arch-kirkwood/config.h, this way in future after > enabling ide, nand, spi driver support just defining the same macro in > armada100/config.h will enable the file system support for armada100 > platforms. > > I think not all platform under marvell would need to enable all those > configure... > What if it only want to enable one setting from this big group, like > it only want the CONFIG_CMD_FAT, > then you need to it set the CONFIG_SYS_MVFS with other unnessary > setting enabled... Please follow the strategy used to include <config_cmd_default.h> in board config file, further followed by #undef for not needed definitions. Regards.. Prafulla ..
diff --git a/arch/arm/include/asm/arch-armada100/config.h b/arch/arm/include/asm/arch-armada100/config.h new file mode 100644 index 0000000..9c18b1c --- /dev/null +++ b/arch/arm/include/asm/arch-armada100/config.h @@ -0,0 +1,50 @@ +/* + * (C) Copyright 2010 + * Marvell Semiconductor <www.marvell.com> + * Written-by: Lei Wen <leiwen@marvell.com> + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + * MA 02110-1301 USA + */ + +/* + * This file should be included in board config header file. + * + * It supports common definations for MMP platform + */ + +#ifndef _ARMADA100_H +#define _ARMADA100_H + +#define CONFIG_ARM926EJS 1 /* Basic Architecture */ + +#define CONFIG_SYS_TCLK (14745600) /* NS16550 clk config */ +#define CONFIG_SYS_HZ_CLOCK (3250000) /* Timer Freq. 3.25MHZ */ +#define CONFIG_MARVELL_MFP /* Enable mvmfp driver */ +#define MV_MFPR_BASE ARMD1_MFPR_BASE +#define MV_UART_CONSOLE_BASE ARMD1_UART1_BASE +#define CONFIG_SYS_NS16550_IER (1 << 6) /* Bit 6 in UART_IER register + represents UART Unit Enable */ +/* + * There is no internal RAM in ARMADA100, using DRAM + * TBD: dcache to be used for this + */ +#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_TEXT_BASE - 0x00200000) +#define CONFIG_NR_DRAM_BANKS_MAX 2 + +#endif /* _ARMADA100_H */ diff --git a/arch/arm/include/asm/arch-kirkwood/config.h b/arch/arm/include/asm/arch-kirkwood/config.h new file mode 100644 index 0000000..0a15e6b --- /dev/null +++ b/arch/arm/include/asm/arch-kirkwood/config.h @@ -0,0 +1,170 @@ +/* + * (C) Copyright 2010 + * Marvell Semiconductor <www.marvell.com> + * Written-by: Lei Wen <leiwen@marvell.com> + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + * MA 02110-1301 USA + */ + +/* + * This file should be included in board config header file. + * + * It supports common definations for Kirkwood platform + * TBD: support for Orion5X platforms + */ + +#ifndef _MV_KIRKWOOD_H +#define _MV_KIRKWOOD_H + +#if defined (CONFIG_KW88F6281) +#include <asm/arch/kw88f6281.h> +#elif defined (CONFIG_KW88F6192) +#include <asm/arch/kw88f6192.h> +#else +#error "SOC Name not defined" +#endif /* CONFIG_KW88F6281 */ + +#define CONFIG_ARM926EJS 1 /* Basic Architecture */ + +#define CONFIG_MD5 /* get_random_hex on krikwood needs MD5 support */ +#define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */ +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8 /* Set RGMII Pad voltage to 1.8V */ +#define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel */ + +/* + * By default kwbimage.cfg from board specific folder is used + * If for some board, different configuration file need to be used, + * CONFIG_SYS_KWD_CONFIG should be defined in board specific header file + */ +#ifndef CONFIG_SYS_KWD_CONFIG +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.cfg +#endif /* CONFIG_SYS_KWD_CONFIG */ + +/* Kirkwood has 2k of Security SRAM, use it for SP */ +#define CONFIG_SYS_INIT_SP_ADDR 0xC8012000 +#define CONFIG_NR_DRAM_BANKS_MAX 2 + +#define CONFIG_I2C_MVTWSI_BASE KW_TWSI_BASE +#define MV_UART_CONSOLE_BASE KW_UART0_BASE +#define MV_SATA_BASE KW_SATA_BASE +#define MV_SATA_PORT0_OFFSET KW_SATA_PORT0_OFFSET +#define MV_SATA_PORT1_OFFSET KW_SATA_PORT1_OFFSET + +/* + * NAND configuration + */ +#ifdef CONFIG_CMD_NAND +#define CONFIG_NAND_KIRKWOOD +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define NAND_MAX_CHIPS 1 +#define CONFIG_SYS_NAND_BASE 0xD8000000 /* MV_DEFADR_NANDF */ +#define NAND_ALLOW_ERASE_ALL 1 +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ +#endif + +/* + * SPI Flash configuration + */ +#ifdef CONFIG_CMD_SF +#define CONFIG_SPI_FLASH 1 +#define CONFIG_HARD_SPI 1 +#define CONFIG_KIRKWOOD_SPI 1 +#define CONFIG_SPI_FLASH_MACRONIX 1 +#define CONFIG_ENV_SPI_BUS 0 +#define CONFIG_ENV_SPI_CS 0 +#define CONFIG_ENV_SPI_MAX_HZ 50000000 /*50Mhz */ +#endif + +/* + * Ethernet Driver configuration + */ +#ifdef CONFIG_CMD_NET +#define CONFIG_CMD_MII +#define CONFIG_NETCONSOLE /* include NetConsole support */ +#define CONFIG_NET_MULTI /* specify more that one ports available */ +#define CONFIG_MII /* expose smi ove miiphy interface */ +#define CONFIG_MVGBE /* Enable Marvell Gbe Controller Driver */ +#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN /* detect link using phy */ +#define CONFIG_ENV_OVERWRITE /* ethaddr can be reprogrammed */ +#define CONFIG_RESET_PHY_R /* use reset_phy() to init mv8831116 PHY */ +#endif /* CONFIG_CMD_NET */ + +/* + * USB/EHCI + */ +#ifdef CONFIG_CMD_USB +#define CONFIG_USB_EHCI /* Enable EHCI USB support */ +#define CONFIG_USB_EHCI_KIRKWOOD +#define CONFIG_EHCI_IS_TDI +#define CONFIG_USB_STORAGE +#define CONFIG_DOS_PARTITION +#define CONFIG_ISO_PARTITION +#define CONFIG_SUPPORT_VFAT +#endif /* CONFIG_CMD_USB */ + +/* + * IDE Support on SATA ports + */ +#ifdef CONFIG_CMD_IDE +#define __io +#define CONFIG_CMD_EXT2 +#define CONFIG_MVSATA_IDE +#define CONFIG_IDE_PREINIT +#define CONFIG_MVSATA_IDE_USE_PORT1 +/* Needs byte-swapping for ATA data register */ +#define CONFIG_IDE_SWAP_IO +/* Data, registers and alternate blocks are at the same offset */ +#define CONFIG_SYS_ATA_DATA_OFFSET (0x0100) +#define CONFIG_SYS_ATA_REG_OFFSET (0x0100) +#define CONFIG_SYS_ATA_ALT_OFFSET (0x0100) +/* Each 8-bit ATA register is aligned to a 4-bytes address */ +#define CONFIG_SYS_ATA_STRIDE 4 +/* Controller supports 48-bits LBA addressing */ +#define CONFIG_LBA48 +/* CONFIG_CMD_IDE requires some #defines for ATA registers */ +#define CONFIG_SYS_IDE_MAXBUS 2 +#define CONFIG_SYS_IDE_MAXDEVICE 2 +/* ATA registers base is at SATA controller base */ +#define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE +#endif /* CONFIG_CMD_IDE */ + +/* + * I2C related stuff + */ +#ifdef CONFIG_CMD_I2C +#define CONFIG_I2C_MVTWSI +#define CONFIG_SYS_I2C_SLAVE 0x0 +#define CONFIG_SYS_I2C_SPEED 100000 +#endif + +/* + * File system + */ +#define CONFIG_CMD_EXT2 +#define CONFIG_CMD_JFFS2 +#define CONFIG_CMD_FAT +#define CONFIG_CMD_UBI +#define CONFIG_CMD_UBIFS +#define CONFIG_RBTREE +#define CONFIG_MTD_DEVICE /* needed for mtdparts commands */ +#define CONFIG_MTD_PARTITIONS +#define CONFIG_CMD_MTDPARTS +#define CONFIG_LZO + +#endif /* _MV_KIRKWOOD_H */ diff --git a/include/configs/aspenite.h b/include/configs/aspenite.h index 706365f..48706cb 100644 --- a/include/configs/aspenite.h +++ b/include/configs/aspenite.h @@ -53,6 +53,7 @@ * to enable certain macros */ #include "mv-common.h" +#undef CONFIG_ARCH_MISC_INIT /* * Environment variables configurations diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h index 97b6971..c458741 100644 --- a/include/configs/mv-common.h +++ b/include/configs/mv-common.h @@ -37,54 +37,6 @@ * High Level Configuration Options (easy to change) */ #define CONFIG_MARVELL 1 -#define CONFIG_ARM926EJS 1 /* Basic Architecture */ - -/* ====> Kirkwood Platform Common Definations */ -#if defined(CONFIG_KIRKWOOD) -#define CONFIG_MD5 /* get_random_hex on krikwood needs MD5 support */ -#define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */ -#define CONFIG_KIRKWOOD_RGMII_PAD_1V8 /* Set RGMII Pad voltage to 1.8V */ -#define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel */ - -/* - * By default kwbimage.cfg from board specific folder is used - * If for some board, different configuration file need to be used, - * CONFIG_SYS_KWD_CONFIG should be defined in board specific header file - */ -#ifndef CONFIG_SYS_KWD_CONFIG -#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.cfg -#endif /* CONFIG_SYS_KWD_CONFIG */ - -/* Kirkwood has 2k of Security SRAM, use it for SP */ -#define CONFIG_SYS_INIT_SP_ADDR 0xC8012000 -#define CONFIG_NR_DRAM_BANKS_MAX 2 - -#define CONFIG_I2C_MVTWSI_BASE KW_TWSI_BASE -#define MV_UART_CONSOLE_BASE KW_UART0_BASE -#define MV_SATA_BASE KW_SATA_BASE -#define MV_SATA_PORT0_OFFSET KW_SATA_PORT0_OFFSET -#define MV_SATA_PORT1_OFFSET KW_SATA_PORT1_OFFSET - -/* ====> ARMADA100 Platform Common Definations */ -#elif defined (CONFIG_ARMADA100) - -#define CONFIG_SYS_TCLK (14745600) /* NS16550 clk config */ -#define CONFIG_SYS_HZ_CLOCK (3250000) /* Timer Freq. 3.25MHZ */ -#define CONFIG_MARVELL_MFP /* Enable mvmfp driver */ -#define MV_MFPR_BASE ARMD1_MFPR_BASE -#define MV_UART_CONSOLE_BASE ARMD1_UART1_BASE -#define CONFIG_SYS_NS16550_IER (1 << 6) /* Bit 6 in UART_IER register - represents UART Unit Enable */ -/* - * There is no internal RAM in ARMADA100, using DRAM - * TBD: dcache to be used for this - */ -#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_TEXT_BASE - 0x00200000) -#define CONFIG_NR_DRAM_BANKS_MAX 2 - -#else -#error "Unsupported SoC Platform..." -#endif /* * Custom CONFIG_SYS_TEXT_BASE can be done in <board>.h @@ -138,31 +90,6 @@ +sizeof(CONFIG_SYS_PROMPT) + 16) /* Print Buff */ /* - * NAND configuration - */ -#ifdef CONFIG_CMD_NAND -#define CONFIG_NAND_KIRKWOOD -#define CONFIG_SYS_MAX_NAND_DEVICE 1 -#define NAND_MAX_CHIPS 1 -#define CONFIG_SYS_NAND_BASE 0xD8000000 /* MV_DEFADR_NANDF */ -#define NAND_ALLOW_ERASE_ALL 1 -#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ -#endif - -/* - * SPI Flash configuration - */ -#ifdef CONFIG_CMD_SF -#define CONFIG_SPI_FLASH 1 -#define CONFIG_HARD_SPI 1 -#define CONFIG_KIRKWOOD_SPI 1 -#define CONFIG_SPI_FLASH_MACRONIX 1 -#define CONFIG_ENV_SPI_BUS 0 -#define CONFIG_ENV_SPI_CS 0 -#define CONFIG_ENV_SPI_MAX_HZ 50000000 /*50Mhz */ -#endif - -/* * Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (1024 * 1024) /* 1MiB for malloc() */ @@ -176,9 +103,7 @@ #define CONFIG_CMDLINE_EDITING #define CONFIG_CONSOLE_INFO_QUIET /* some code reduction */ #define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */ -#ifndef CONFIG_ARMADA100 /* will be removed latter */ #define CONFIG_ARCH_MISC_INIT /* call arch_misc_init() */ -#endif /* CONFIG_ARMADA100 */ #define CONFIG_BOARD_EARLY_INIT_F /* call board_init_f for early inits */ #define CONFIG_DISPLAY_CPUINFO /* Display cpu info */ #define CONFIG_STACKSIZE 0x00100000 /* regular stack- 1M */ @@ -199,82 +124,7 @@ #endif #endif /* CONFIG_NR_DRAM_BANKS */ -/* - * Ethernet Driver configuration - */ -#ifdef CONFIG_CMD_NET -#define CONFIG_CMD_MII -#define CONFIG_NETCONSOLE /* include NetConsole support */ -#define CONFIG_NET_MULTI /* specify more that one ports available */ -#define CONFIG_MII /* expose smi ove miiphy interface */ -#define CONFIG_MVGBE /* Enable Marvell Gbe Controller Driver */ -#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN /* detect link using phy */ -#define CONFIG_ENV_OVERWRITE /* ethaddr can be reprogrammed */ -#define CONFIG_RESET_PHY_R /* use reset_phy() to init mv8831116 PHY */ -#endif /* CONFIG_CMD_NET */ - -/* - * USB/EHCI - */ -#ifdef CONFIG_CMD_USB -#define CONFIG_USB_EHCI /* Enable EHCI USB support */ -#define CONFIG_USB_EHCI_KIRKWOOD -#define CONFIG_EHCI_IS_TDI -#define CONFIG_USB_STORAGE -#define CONFIG_DOS_PARTITION -#define CONFIG_ISO_PARTITION -#define CONFIG_SUPPORT_VFAT -#endif /* CONFIG_CMD_USB */ - -/* - * IDE Support on SATA ports - */ -#ifdef CONFIG_CMD_IDE -#define __io -#define CONFIG_CMD_EXT2 -#define CONFIG_MVSATA_IDE -#define CONFIG_IDE_PREINIT -#define CONFIG_MVSATA_IDE_USE_PORT1 -/* Needs byte-swapping for ATA data register */ -#define CONFIG_IDE_SWAP_IO -/* Data, registers and alternate blocks are at the same offset */ -#define CONFIG_SYS_ATA_DATA_OFFSET (0x0100) -#define CONFIG_SYS_ATA_REG_OFFSET (0x0100) -#define CONFIG_SYS_ATA_ALT_OFFSET (0x0100) -/* Each 8-bit ATA register is aligned to a 4-bytes address */ -#define CONFIG_SYS_ATA_STRIDE 4 -/* Controller supports 48-bits LBA addressing */ -#define CONFIG_LBA48 -/* CONFIG_CMD_IDE requires some #defines for ATA registers */ -#define CONFIG_SYS_IDE_MAXBUS 2 -#define CONFIG_SYS_IDE_MAXDEVICE 2 -/* ATA registers base is at SATA controller base */ -#define CONFIG_SYS_ATA_BASE_ADDR MV_SATA_BASE -#endif /* CONFIG_CMD_IDE */ - -/* - * I2C related stuff - */ -#ifdef CONFIG_CMD_I2C -#define CONFIG_I2C_MVTWSI -#define CONFIG_SYS_I2C_SLAVE 0x0 -#define CONFIG_SYS_I2C_SPEED 100000 -#endif - -/* - * File system - */ -#ifndef CONFIG_ARMADA100 /* will be removed latter */ -#define CONFIG_CMD_EXT2 -#define CONFIG_CMD_JFFS2 -#define CONFIG_CMD_FAT -#define CONFIG_CMD_UBI -#define CONFIG_CMD_UBIFS -#define CONFIG_RBTREE -#define CONFIG_MTD_DEVICE /* needed for mtdparts commands */ -#define CONFIG_MTD_PARTITIONS -#define CONFIG_CMD_MTDPARTS -#define CONFIG_LZO -#endif /* CONFIG_ARMADA100 */ +/* ====> Include platform Common Definations */ +#include <asm/arch/config.h> #endif /* _MV_COMMON_H */
Since there are lots of difference between kirkwood and mmp series, it is better to seperate them but still keep the most common file shared by all marvell platform in the mv-common configure file. This patch move the kirkwood only driver definitoin in mv-common to the kirkwood.h and it is tested with compilation for armada100 and guruplug. Signed-off-by: Lei Wen <leiwen@marvell.com> --- arch/arm/include/asm/arch-armada100/config.h | 50 ++++++++ arch/arm/include/asm/arch-kirkwood/config.h | 170 ++++++++++++++++++++++++++ include/configs/aspenite.h | 1 + include/configs/mv-common.h | 154 +----------------------- 4 files changed, 223 insertions(+), 152 deletions(-) create mode 100644 arch/arm/include/asm/arch-armada100/config.h create mode 100644 arch/arm/include/asm/arch-kirkwood/config.h