From patchwork Sat Sep 4 07:12:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Albert ARIBAUD X-Patchwork-Id: 71839 X-Patchwork-Delegate: albert.aribaud@free.fr Return-Path: X-Original-To: wd@gemini.denx.de Delivered-To: wd@gemini.denx.de Received: from diddl.denx.de (diddl.denx.de [10.0.0.6]) by gemini.denx.de (Postfix) with ESMTP id 12E58153782 for ; Sat, 4 Sep 2010 09:14:33 +0200 (CEST) Received: from diddl.denx.de (localhost.localdomain [127.0.0.1]) by diddl.denx.de (Postfix) with ESMTP id F2FB330E5E2E for ; Sat, 4 Sep 2010 09:14:32 +0200 (MEST) Received: from pop.mnet-online.de by diddl.denx.de with POP3 (fetchmail-6.3.17) for (single-drop); Sat, 04 Sep 2010 09:14:32 +0200 (MEST) Received: from murder ([192.168.8.180]) by backend2 (Cyrus v2.2.12) with LMTPA; Sat, 04 Sep 2010 09:12:55 +0200 X-Sieve: CMU Sieve 2.2 Received: from mail.m-online.net (localhost [127.0.0.1]) by frontend1.mail.m-online.net (Cyrus v2.2.12) with LMTPA; Sat, 04 Sep 2010 09:12:52 +0200 Received: from scanner-1.m-online.net (scanner-1.mail.m-online.net [192.168.8.165]) by mail.m-online.net (Postfix) with ESMTP id ECC9D1C00162; Sat, 4 Sep 2010 09:12:52 +0200 (CEST) Received: from mxin-3.m-online.net ([192.168.6.165]) by scanner-1.m-online.net (scanner-1.m-online.net [192.168.8.165]) (amavisd-new, port 10026) with ESMTP id 29853-02-6; Sat, 4 Sep 2010 09:12:50 +0200 (CEST) Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by mxin-3.m-online.net (Postfix) with ESMTP id 8E4F046F3F6; Sat, 4 Sep 2010 09:12:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4D45128137; Sat, 4 Sep 2010 09:12:42 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jlufTfL6VNXf; Sat, 4 Sep 2010 09:12:42 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C0A39280FB; Sat, 4 Sep 2010 09:12:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 16C58280CB for ; Sat, 4 Sep 2010 09:12:35 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E2KTARkyszdH for ; Sat, 4 Sep 2010 09:12:33 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from smtp4-g21.free.fr (smtp4-g21.free.fr [212.27.42.4]) by theia.denx.de (Postfix) with ESMTP id 066C72810B for ; Sat, 4 Sep 2010 09:12:31 +0200 (CEST) Received: from localhost.localdomain (unknown [82.235.144.2]) by smtp4-g21.free.fr (Postfix) with ESMTP id D61AD4C8142 for ; Sat, 4 Sep 2010 09:12:28 +0200 (CEST) From: Albert Aribaud To: u-boot@lists.denx.de Date: Sat, 4 Sep 2010 09:12:25 +0200 Message-Id: <1283584346-20384-1-git-send-email-albert.aribaud@free.fr> X-Mailer: git-send-email 1.7.0.4 Subject: [U-Boot] [PATCH 1/2] edminiv2.h: fix GPIO output value settings X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Virus-Scanned: by amavisd-new at m-online.net Wrong output value was harmless as long as orion5x did not use it. Upcoming patch fixes orion5x, thus must fix edminiv2 config as well. Also update comments to clarify edminiv2 GPIO directions and values. Signed-off-by: Albert Aribaud --- include/configs/edminiv2.h | 20 +++++++++++++------- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/include/configs/edminiv2.h b/include/configs/edminiv2.h index ccfc660..586ce06 100644 --- a/include/configs/edminiv2.h +++ b/include/configs/edminiv2.h @@ -52,10 +52,10 @@ #define CONFIG_SYS_HZ 1000 /* - * Board-specific values for Orion5x MPP low level init: + * Board-specific MPP settings for Orion5x: * - MPPs 12 to 15 are SATA LEDs (mode 5) * - Others are GPIO/unused (mode 3 for MPP0, mode 5 for - * MPP16 to MPP19, mode 0 for others + * MPP16 to MPP19, mode 0 for others) */ #define ORION5X_MPP0_7 0x00000003 @@ -63,18 +63,24 @@ #define ORION5X_MPP16_23 0x00005555 /* - * Board-specific values for Orion5x GPIO low level init: + * Board-specific GPIO directions for Orion5x: * - GPIO3 is input (RTC interrupt) - * - GPIO16 is Power LED control (0 = on, 1 = off) + * - GPIO16 is Power LED control (BEWARE: 0 = ON, 1 = OFF) * - GPIO17 is Power LED source select (0 = CPLD, 1 = GPIO16) * - GPIO18 is Power Button status (0 = Released, 1 = Pressed) * - Last GPIO is 26, further bits are supposed to be 0. - * Enable mask has ones for INPUT, 0 for OUTPUT. - * Default is LED ON. + * (Reminder: each enable bit is 1 for INPUT, 0 for OUTPUT) */ #define ORION5X_GPIO_OUT_ENABLE 0x03fcffff -#define ORION5X_GPIO_OUT_VALUE 0x03fcffff + +/* + * Board-specific GPIO output values for Orion5x: + * - GPIO16 (Power LED control) = 0 (on) + * - GPIO17 (is Power LED source) = 1 (GPIO16) + */ + +#define ORION5X_GPIO_OUT_VALUE 0x00020000 /* * NS16550 Configuration