| Message ID | 0327c772937aaa2162faf7c53a53d005fc2bb399.1610957483.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 4e3fc5efeb70857ef2f9a2afd0a587c032c9a07b |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v2] env: Remove all dependencies for SYS_REDUNDAND_ENVIRONMENT | expand |
On Mon, Jan 18, 2021 at 09:11:26AM +0100, Michal Simek wrote: > CONFIG_SYS_REDUNDAND_ENVIRONMENT is changing in env_internal.h how u-boot > works with variables. struct environment_s has one byte flags property > which also affects ENV_SIZE macro. > > I have reached the case where CONFIG_ENV_IS_NOWHERE is default setup > but custom scripts can be designed in a way that u-boot is asked to > import/export variables from/to file which can be in certain format. > That's why also for this configuration make sense to enable > CONFIG_SYS_REDUNDAND_ENVIRONMENT because it depends on environment file > format. > > The patch is removing dependency on this configuration to support selecting > environment file format without any specific dependency where variables are > stored. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Tom Rini <trini@konsulko.com>
po 18. 1. 2021 v 9:11 odesÃlatel Michal Simek <michal.simek@xilinx.com> napsal: > > CONFIG_SYS_REDUNDAND_ENVIRONMENT is changing in env_internal.h how u-boot > works with variables. struct environment_s has one byte flags property > which also affects ENV_SIZE macro. > > I have reached the case where CONFIG_ENV_IS_NOWHERE is default setup > but custom scripts can be designed in a way that u-boot is asked to > import/export variables from/to file which can be in certain format. > That's why also for this configuration make sense to enable > CONFIG_SYS_REDUNDAND_ENVIRONMENT because it depends on environment file > format. > > The patch is removing dependency on this configuration to support selecting > environment file format without any specific dependency where variables are > stored. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Changes in v2: > - Extend Kconfig help message to cover binary environment handling > > env/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/env/Kconfig b/env/Kconfig > index 67ce93061b7d..b473d7cfe1e9 100644 > --- a/env/Kconfig > +++ b/env/Kconfig > @@ -411,13 +411,14 @@ config ENV_IS_IN_UBI > > config SYS_REDUNDAND_ENVIRONMENT > bool "Enable redundant environment support" > - depends on ENV_IS_IN_EEPROM || ENV_IS_IN_FLASH || ENV_IS_IN_MMC || \ > - ENV_IS_IN_NAND || ENV_IS_IN_SPI_FLASH || ENV_IS_IN_UBI > help > Normally, the environemt is stored in a single location. By > selecting this option, you can then define where to hold a redundant > copy of the environment data, so that there is a valid backup copy in > case there is a power failure during a "saveenv" operation. > + Also this config changes the binary environment structure handling > + which is used by env import/export commands which are independent of > + storing variables to redundant location on a non volatile device. > > config ENV_FAT_INTERFACE > string "Name of the block device for the environment" > -- > 2.30.0 > Applied. M
diff --git a/env/Kconfig b/env/Kconfig index 67ce93061b7d..b473d7cfe1e9 100644 --- a/env/Kconfig +++ b/env/Kconfig @@ -411,13 +411,14 @@ config ENV_IS_IN_UBI config SYS_REDUNDAND_ENVIRONMENT bool "Enable redundant environment support" - depends on ENV_IS_IN_EEPROM || ENV_IS_IN_FLASH || ENV_IS_IN_MMC || \ - ENV_IS_IN_NAND || ENV_IS_IN_SPI_FLASH || ENV_IS_IN_UBI help Normally, the environemt is stored in a single location. By selecting this option, you can then define where to hold a redundant copy of the environment data, so that there is a valid backup copy in case there is a power failure during a "saveenv" operation. + Also this config changes the binary environment structure handling + which is used by env import/export commands which are independent of + storing variables to redundant location on a non volatile device. config ENV_FAT_INTERFACE string "Name of the block device for the environment"
CONFIG_SYS_REDUNDAND_ENVIRONMENT is changing in env_internal.h how u-boot works with variables. struct environment_s has one byte flags property which also affects ENV_SIZE macro. I have reached the case where CONFIG_ENV_IS_NOWHERE is default setup but custom scripts can be designed in a way that u-boot is asked to import/export variables from/to file which can be in certain format. That's why also for this configuration make sense to enable CONFIG_SYS_REDUNDAND_ENVIRONMENT because it depends on environment file format. The patch is removing dependency on this configuration to support selecting environment file format without any specific dependency where variables are stored. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- Changes in v2: - Extend Kconfig help message to cover binary environment handling env/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)