mbox series

[0/4] mailbox: mpfs-mbox: fixes and syscon support

Message ID 20260518141712.3597880-1-jamie.gibbons@microchip.com
Headers show
Series mailbox: mpfs-mbox: fixes and syscon support | expand

Message

Jamie Gibbons May 18, 2026, 2:17 p.m. UTC 
Hi all,

This series updates the Microchip PolarFire SoC (MPFS) mailbox driver in
U-Boot.

The first three patches contain a set of bug fixes and cleanups to the
existing driver, fixing MMIO size calculations, and removing invalid
mailbox channel and private-data handling. These changes are independent
of any devicetree updates and fix issues present in the legacy driver.

The final patch adds support for the corrected, syscon-based devicetree
bindings for the MPFS mailbox. Linux has moved to this binding to more
accurately model the hardware, and U-Boot already supports the same
approach for the MPFS clock controller. This patch updates the mailbox
driver accordingly, while retaining support for the legacy binding for
backwards compatibility.

The final patch is required ASAP as boot is currently broken on master
for MPFS generic boards.

Tested on a PolarFire SoC Icicle Kit ES.

Thanks,
Jamie

Jamie Gibbons (4):
  mailbox: mpfs-mbox: fix MMIO mapping calculation
  mailbox: mpfs-mbox: fix Driver Model private data handling
  mailbox: mpfs-mbox: fix driver bug and cleanup
  mailbox: mpfs-mbox: support new syscon based devicetree configuration

 drivers/mailbox/Kconfig     |   2 +
 drivers/mailbox/mpfs-mbox.c | 106 ++++++++++++++++++++++++------------
 2 files changed, 74 insertions(+), 34 deletions(-)

Comments

Conor Dooley May 19, 2026, 4:24 p.m. UTC | #1 
On Mon, May 18, 2026 at 03:17:08PM +0100, Jamie Gibbons wrote:
> Hi all,
> 
> This series updates the Microchip PolarFire SoC (MPFS) mailbox driver in
> U-Boot.
> 
> The first three patches contain a set of bug fixes and cleanups to the
> existing driver, fixing MMIO size calculations, and removing invalid
> mailbox channel and private-data handling. These changes are independent
> of any devicetree updates and fix issues present in the legacy driver.
> 
> The final patch adds support for the corrected, syscon-based devicetree
> bindings for the MPFS mailbox. Linux has moved to this binding to more
> accurately model the hardware, and U-Boot already supports the same
> approach for the MPFS clock controller. This patch updates the mailbox
> driver accordingly, while retaining support for the legacy binding for
> backwards compatibility.
> 
> The final patch is required ASAP as boot is currently broken on master
> for MPFS generic boards.
> 
> Tested on a PolarFire SoC Icicle Kit ES.
> 
> Thanks,
> Jamie
> 
> Jamie Gibbons (4):
>   mailbox: mpfs-mbox: fix MMIO mapping calculation
>   mailbox: mpfs-mbox: fix Driver Model private data handling
>   mailbox: mpfs-mbox: fix driver bug and cleanup
>   mailbox: mpfs-mbox: support new syscon based devicetree configuration

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Conor Dooley June 8, 2026, 9:13 p.m. UTC | #2 
Tom,

On Tue, May 19, 2026 at 05:24:30PM +0100, Conor Dooley wrote:
> On Mon, May 18, 2026 at 03:17:08PM +0100, Jamie Gibbons wrote:
> > Hi all,
> > 
> > This series updates the Microchip PolarFire SoC (MPFS) mailbox driver in
> > U-Boot.
> > 
> > The first three patches contain a set of bug fixes and cleanups to the
> > existing driver, fixing MMIO size calculations, and removing invalid
> > mailbox channel and private-data handling. These changes are independent
> > of any devicetree updates and fix issues present in the legacy driver.
> > 
> > The final patch adds support for the corrected, syscon-based devicetree
> > bindings for the MPFS mailbox. Linux has moved to this binding to more
> > accurately model the hardware, and U-Boot already supports the same
> > approach for the MPFS clock controller. This patch updates the mailbox
> > driver accordingly, while retaining support for the legacy binding for
> > backwards compatibility.
> > 
> > The final patch is required ASAP as boot is currently broken on master
> > for MPFS generic boards.
> > 
> > Tested on a PolarFire SoC Icicle Kit ES.
> > 
> > Thanks,
> > Jamie
> > 
> > Jamie Gibbons (4):
> >   mailbox: mpfs-mbox: fix MMIO mapping calculation
> >   mailbox: mpfs-mbox: fix Driver Model private data handling
> >   mailbox: mpfs-mbox: fix driver bug and cleanup
> >   mailbox: mpfs-mbox: support new syscon based devicetree configuration
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Would you be able to grab this please? Your current mainline branch is
failing to boot because the last dt-rebasing version jump brought in a
changed dts from linux that requires the syscon-based devicetree setup.

Thanks,
Conor.
Tom Rini June 9, 2026, 1:41 a.m. UTC | #3 
On Mon, 18 May 2026 15:17:08 +0100, Jamie Gibbons wrote:

> This series updates the Microchip PolarFire SoC (MPFS) mailbox driver in
> U-Boot.
> 
> The first three patches contain a set of bug fixes and cleanups to the
> existing driver, fixing MMIO size calculations, and removing invalid
> mailbox channel and private-data handling. These changes are independent
> of any devicetree updates and fix issues present in the legacy driver.
> 
> [...]

Applied to u-boot/master, thanks!

[1/4] mailbox: mpfs-mbox: fix MMIO mapping calculation
      commit: a05adbb9b30115ef7d04668d35650f311458dd2d
[2/4] mailbox: mpfs-mbox: fix Driver Model private data handling
      commit: 1173e02c9880d9f7d1bf15308490493332b03a61
[3/4] mailbox: mpfs-mbox: fix driver bug and cleanup
      commit: 763435d0e3124539dc36c730c3832a1b4162d3f7
[4/4] mailbox: mpfs-mbox: support new syscon based devicetree configuration
      commit: 6c128738240d7e3a6020676501ad382af3359f3e