| Message ID | 20240320090214.40465-1-ada@thorsis.com |
|---|---|
| Headers | show |
| Series | mtd: nand: raw: Collected improvements | expand |
Hi Alexander, On Wed, Mar 20, 2024 at 10:02 AM Alexander Dahl <ada@thorsis.com> wrote: > > Hello everyone, > > while working on NAND flash support for a custom board based on the at91 > SAM9X60 SoC I stumbled over some issues in the raw nand subsystem. > > Four of six patches are minor fixes. > > Patch 4 introduces a new subcommand for the new atmel nand controller > driver. Patch 6 introduces a new subcommand for the nand command to > override ONFI timing mode. Both are are for debugging purposes only and > thus optional, and need to be enabled through menu. Both helped me a > lot when investigating issues. > > Series is based on upstream next branch, but should also apply to master > cleanly. > > Greets > Alex > > v1: > > Link: https://lore.kernel.org/u-boot/20240307091014.39796-1-ada@thorsis.com/T/#t > > v2: > > - rebased on recent next > - collected tags > - improved patch 4 after feedback from Mihai > - added new patch 5 with another help text fix > - added new patch 6 with a new debug command > - reworded cover letter > > See per patch changes in patches for more detailed changes. > > Alexander Dahl (6): > mtd: nand: raw: Use macro nand_to_mtd() where appropriate > mtd: nand: raw: Port another option flag from Linux > mtd: nand: raw: Fix (most) Kconfig indentation > mtd: nand: raw: atmel: Introduce optional debug commands > mtd: nand: raw: atmel: Fix comment in timings preparation > cmd: nand: Add new optional sub-command 'onfi' > > cmd/Kconfig | 10 + > cmd/nand.c | 61 ++++ > drivers/mtd/nand/raw/Kconfig | 115 +++---- > drivers/mtd/nand/raw/atmel/nand-controller.c | 299 ++++++++++++++++++- > drivers/mtd/nand/raw/nand_base.c | 8 +- > include/linux/mtd/rawnand.h | 8 + > 6 files changed, 441 insertions(+), 60 deletions(-) > > > base-commit: f048104999db28d49362201eaebfc91adb14f47c > -- > 2.39.2 > Applied to nand-next the first 4 patches. For the others, we will conduct further testing before applying them. Thanks and regards, Dario
Hello Dario, Am Sun, Apr 14, 2024 at 03:41:38PM +0200 schrieb Dario Binacchi: > Hi Alexander, > > On Wed, Mar 20, 2024 at 10:02 AM Alexander Dahl <ada@thorsis.com> wrote: > > > > Hello everyone, > > > > while working on NAND flash support for a custom board based on the at91 > > SAM9X60 SoC I stumbled over some issues in the raw nand subsystem. > > > > Four of six patches are minor fixes. > > > > Patch 4 introduces a new subcommand for the new atmel nand controller > > driver. Patch 6 introduces a new subcommand for the nand command to > > override ONFI timing mode. Both are are for debugging purposes only and > > thus optional, and need to be enabled through menu. Both helped me a > > lot when investigating issues. > > > > Series is based on upstream next branch, but should also apply to master > > cleanly. > > > > Greets > > Alex > > > > v1: > > > > Link: https://lore.kernel.org/u-boot/20240307091014.39796-1-ada@thorsis.com/T/#t > > > > v2: > > > > - rebased on recent next > > - collected tags > > - improved patch 4 after feedback from Mihai > > - added new patch 5 with another help text fix > > - added new patch 6 with a new debug command > > - reworded cover letter > > > > See per patch changes in patches for more detailed changes. > > > > Alexander Dahl (6): > > mtd: nand: raw: Use macro nand_to_mtd() where appropriate > > mtd: nand: raw: Port another option flag from Linux > > mtd: nand: raw: Fix (most) Kconfig indentation > > mtd: nand: raw: atmel: Introduce optional debug commands > > mtd: nand: raw: atmel: Fix comment in timings preparation > > cmd: nand: Add new optional sub-command 'onfi' > > > > cmd/Kconfig | 10 + > > cmd/nand.c | 61 ++++ > > drivers/mtd/nand/raw/Kconfig | 115 +++---- > > drivers/mtd/nand/raw/atmel/nand-controller.c | 299 ++++++++++++++++++- > > drivers/mtd/nand/raw/nand_base.c | 8 +- > > include/linux/mtd/rawnand.h | 8 + > > 6 files changed, 441 insertions(+), 60 deletions(-) > > > > > > base-commit: f048104999db28d49362201eaebfc91adb14f47c > > -- > > 2.39.2 > > > Applied to nand-next the first 4 patches. > For the others, we will conduct further testing before applying them. Thanks so far. :-) I have another fix for the atmel raw nand driver, which I forgot to send with this series. I could add it to v3. Or should I send it separately? Greets Alex
Hello Alexander, On Mon, Apr 15, 2024 at 8:13 AM Alexander Dahl <ada@thorsis.com> wrote: > > Hello Dario, > > Am Sun, Apr 14, 2024 at 03:41:38PM +0200 schrieb Dario Binacchi: > > Hi Alexander, > > > > On Wed, Mar 20, 2024 at 10:02 AM Alexander Dahl <ada@thorsis.com> wrote: > > > > > > Hello everyone, > > > > > > while working on NAND flash support for a custom board based on the at91 > > > SAM9X60 SoC I stumbled over some issues in the raw nand subsystem. > > > > > > Four of six patches are minor fixes. > > > > > > Patch 4 introduces a new subcommand for the new atmel nand controller > > > driver. Patch 6 introduces a new subcommand for the nand command to > > > override ONFI timing mode. Both are are for debugging purposes only and > > > thus optional, and need to be enabled through menu. Both helped me a > > > lot when investigating issues. > > > > > > Series is based on upstream next branch, but should also apply to master > > > cleanly. > > > > > > Greets > > > Alex > > > > > > v1: > > > > > > Link: https://lore.kernel.org/u-boot/20240307091014.39796-1-ada@thorsis.com/T/#t > > > > > > v2: > > > > > > - rebased on recent next > > > - collected tags > > > - improved patch 4 after feedback from Mihai > > > - added new patch 5 with another help text fix > > > - added new patch 6 with a new debug command > > > - reworded cover letter > > > > > > See per patch changes in patches for more detailed changes. > > > > > > Alexander Dahl (6): > > > mtd: nand: raw: Use macro nand_to_mtd() where appropriate > > > mtd: nand: raw: Port another option flag from Linux > > > mtd: nand: raw: Fix (most) Kconfig indentation > > > mtd: nand: raw: atmel: Introduce optional debug commands > > > mtd: nand: raw: atmel: Fix comment in timings preparation > > > cmd: nand: Add new optional sub-command 'onfi' > > > > > > cmd/Kconfig | 10 + > > > cmd/nand.c | 61 ++++ > > > drivers/mtd/nand/raw/Kconfig | 115 +++---- > > > drivers/mtd/nand/raw/atmel/nand-controller.c | 299 ++++++++++++++++++- > > > drivers/mtd/nand/raw/nand_base.c | 8 +- > > > include/linux/mtd/rawnand.h | 8 + > > > 6 files changed, 441 insertions(+), 60 deletions(-) > > > > > > > > > base-commit: f048104999db28d49362201eaebfc91adb14f47c > > > -- > > > 2.39.2 > > > > > Applied to nand-next the first 4 patches. > > For the others, we will conduct further testing before applying them. > > Thanks so far. :-) > > I have another fix for the atmel raw nand driver, which I forgot to > send with this series. I could add it to v3. Of course, feel free to add it to version 3. Thanks and regards, Dario > Or should I send it > separately? > > Greets > Alex