mbox series

[v2,00/16] Sync NXP LS1028A-RDB device trees between U-Boot and Linux

Message ID 20211207202023.2054282-1-vladimir.oltean@nxp.com
Headers show
Series Sync NXP LS1028A-RDB device trees between U-Boot and Linux | expand

Message

Vladimir Oltean Dec. 7, 2021, 8:20 p.m. UTC
The changes were intended to be minimal, but unfortunately I discovered
some other stuff as well:
- we need to make some changes to the compatible strings of RTC devices
  and I2C muxes. This has ramifications to other NXP boards which were
  also updated.
- I broke Ethernet on LS1028A boards through a patch that is currently
  in Ramon's tree.

Therefore this patch set is a bit larger than would be otherwise
expected.

The Linux device tree changes have just been posted by me here and are
currently in flight, but they are rather small so I don't expect too
much pushback on them:
https://lore.kernel.org/linux-arm-kernel/20211202141528.2450169-5-vladimir.oltean@nxp.com/T/#m6f63c92e75fa79a01144b2c2c6dc4776e7971395

I've also triggered an Azure CI build with these changes:
https://github.com/u-boot/u-boot/pull/102
and it appears that 2 tests fail due to external causes:
1. https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3283&view=logs&jobId=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&j=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&t=c864b9c4-48aa-5e04-3916-54070f85e156
2. https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3283&view=logs&j=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&t=c864b9c4-48aa-5e04-3916-54070f85e156&l=27

Unable to find image 'trini/u-boot-gitlab-ci-runner:focal-20211006-14Nov2021' locally
docker: Error response from daemon: Head "https://registry-1.docker.io/v2/trini/u-boot-gitlab-ci-runner/manifests/focal-20211006-14Nov2021": received unexpected HTTP status: 502 Bad Gateway.

The other tests seem to pass.

Cc: Heiko Schocher <hs@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Ramon Fried <rfried.dev@gmail.com>

Vladimir Oltean (16):
  i2c: muxes: pca954x: add PCA9847 variant
  rtc: pcf2127: sync with Linux compatible strings
  arm: dts: ls1088a-qds: use Linux compatible string for RTC
  arm: dts: ls1088a-rdb: use Linux compatible string for RTC
  arm: dts: lx2160a-qds: use Linux compatible string for RTC
  arm: dts: ls1028a-qds: use Linux compatible string for RTC
  arm: dts: ls1028a-rdb: use Linux compatible string for RTC
  arm: dts: lx2160a-rdb: use Linux compatible string for RTC
  rtc: pcf2127: remove U-Boot specific compatible string
  arm: dts: ls1028a-rdb: sort nodes alphabetically
  arm: dts: ls1028a-rdb: sync Ethernet device tree nodes with Linux
  arm: dts: ls1028a-rdb: disable DSPI nodes
  arm: dts: ls1028a-rdb: disable I2C buses 1 through 7
  arm: dts: ls1028a-rdb: enable PCIe controllers from U-Boot dtsi
  arm: dts: ls1028a-rdb: sync device tree with Linux
  arm: dts: ls1028a-qds: declare in-band autoneg for Ethernet ports

 .../dts/fsl-ls1028a-qds-1xxx-sch-30842.dtsi   |   1 +
 .../dts/fsl-ls1028a-qds-8xxx-sch-24801.dtsi   |   1 +
 .../fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi  |   4 +
 .../dts/fsl-ls1028a-qds-9999-sch-24801.dtsi   |   4 +
 .../fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi  |   4 +
 .../fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi  |   4 +
 arch/arm/dts/fsl-ls1028a-qds.dtsi             |   2 +-
 arch/arm/dts/fsl-ls1028a-rdb-u-boot.dtsi      |  15 +
 arch/arm/dts/fsl-ls1028a-rdb.dts              | 295 ++++++++++++------
 arch/arm/dts/fsl-ls1088a-qds.dtsi             |   2 +-
 arch/arm/dts/fsl-ls1088a-rdb.dts              |   2 +-
 arch/arm/dts/fsl-lx2160a-qds.dtsi             |   2 +-
 arch/arm/dts/fsl-lx2160a-rdb.dts              |   2 +-
 drivers/i2c/muxes/pca954x.c                   |   9 +-
 drivers/rtc/pcf2127.c                         |   4 +-
 15 files changed, 242 insertions(+), 109 deletions(-)
 create mode 100644 arch/arm/dts/fsl-ls1028a-rdb-u-boot.dtsi

Comments

Vladimir Oltean Dec. 14, 2021, 2:38 p.m. UTC | #1
Hi Priyanka,

On Tue, Dec 07, 2021 at 10:20:07PM +0200, Vladimir Oltean wrote:
> The changes were intended to be minimal, but unfortunately I discovered
> some other stuff as well:
> - we need to make some changes to the compatible strings of RTC devices
>   and I2C muxes. This has ramifications to other NXP boards which were
>   also updated.
> - I broke Ethernet on LS1028A boards through a patch that is currently
>   in Ramon's tree.
> 
> Therefore this patch set is a bit larger than would be otherwise
> expected.
> 
> The Linux device tree changes have just been posted by me here and are
> currently in flight, but they are rather small so I don't expect too
> much pushback on them:
> https://lore.kernel.org/linux-arm-kernel/20211202141528.2450169-5-vladimir.oltean@nxp.com/T/#m6f63c92e75fa79a01144b2c2c6dc4776e7971395
> 
> I've also triggered an Azure CI build with these changes:
> https://github.com/u-boot/u-boot/pull/102
> and it appears that 2 tests fail due to external causes:
> 1. https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3283&view=logs&jobId=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&j=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&t=c864b9c4-48aa-5e04-3916-54070f85e156
> 2. https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3283&view=logs&j=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&t=c864b9c4-48aa-5e04-3916-54070f85e156&l=27
> 
> Unable to find image 'trini/u-boot-gitlab-ci-runner:focal-20211006-14Nov2021' locally
> docker: Error response from daemon: Head "https://registry-1.docker.io/v2/trini/u-boot-gitlab-ci-runner/manifests/focal-20211006-14Nov2021": received unexpected HTTP status: 502 Bad Gateway.
> 
> The other tests seem to pass.

The Linux side of device tree patches were merged today, and I see
you've reviewed the U-Boot side of changes too. Could you please pick
them up?
Priyanka Jain Dec. 23, 2021, 6:34 a.m. UTC | #2
>-----Original Message-----
>From: Vladimir Oltean <vladimir.oltean@nxp.com>
>Sent: Tuesday, December 14, 2021 8:09 PM
>To: Priyanka Jain <priyanka.jain@nxp.com>; u-boot@lists.denx.de
>Cc: Michael Walle <michael@walle.cc>; Tom Rini <trini@konsulko.com>; Leo Li
><leoyang.li@nxp.com>; Heiko Schocher <hs@denx.de>; Simon Glass
><sjg@chromium.org>; Ramon Fried <rfried.dev@gmail.com>
>Subject: Re: [PATCH v2 00/16] Sync NXP LS1028A-RDB device trees between U-
>Boot and Linux
>
>Hi Priyanka,
>
>On Tue, Dec 07, 2021 at 10:20:07PM +0200, Vladimir Oltean wrote:
>> The changes were intended to be minimal, but unfortunately I
>> discovered some other stuff as well:
>> - we need to make some changes to the compatible strings of RTC devices
>>   and I2C muxes. This has ramifications to other NXP boards which were
>>   also updated.
>> - I broke Ethernet on LS1028A boards through a patch that is currently
>>   in Ramon's tree.
>>
>> Therefore this patch set is a bit larger than would be otherwise
>> expected.
>>
>> The Linux device tree changes have just been posted by me here and are
>> currently in flight, but they are rather small so I don't expect too
>> much pushback on them:
>> https://lore.kernel.org/linux-arm-kernel/20211202141528.2450169-5-vlad
>> imir.oltean@nxp.com/T/#m6f63c92e75fa79a01144b2c2c6dc4776e7971395
>>
>> I've also triggered an Azure CI build with these changes:
>> https://github.com/u-boot/u-boot/pull/102
>> and it appears that 2 tests fail due to external causes:
>> 1.
>> https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3283&view=l
>> ogs&jobId=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&j=5fafc5b9-a417-5c75-4c
>> 48-15c7f941e4ee&t=c864b9c4-48aa-5e04-3916-54070f85e156
>> 2.
>> https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3283&view=l
>> ogs&j=5fafc5b9-a417-5c75-4c48-15c7f941e4ee&t=c864b9c4-48aa-5e04-3916-
>5
>> 4070f85e156&l=27
>>
>> Unable to find image
>> 'trini/u-boot-gitlab-ci-runner:focal-20211006-14Nov2021' locally
>> docker: Error response from daemon: Head "https://registry-
>1.docker.io/v2/trini/u-boot-gitlab-ci-runner/manifests/focal-20211006-
>14Nov2021": received unexpected HTTP status: 502 Bad Gateway.
>>
>> The other tests seem to pass.
>
>The Linux side of device tree patches were merged today, and I see you've
>reviewed the U-Boot side of changes too. Could you please pick them up?

Yes, I will pick the series as part of next pull-request for 2022.04

Regards
Priyanka
Vladimir Oltean Dec. 23, 2021, 12:44 p.m. UTC | #3
On Thu, Dec 23, 2021 at 06:34:13AM +0000, Priyanka Jain wrote:
> >The Linux side of device tree patches were merged today, and I see you've
> >reviewed the U-Boot side of changes too. Could you please pick them up?
> 
> Yes, I will pick the series as part of next pull-request for 2022.04

Thanks. Could you also delete the '#include "fsl-ls1028a-rdb-u-boot.dtsi"'
line from patch 14/16 like Michael suggested, or should I resend for that?
Michael Walle Dec. 23, 2021, 12:47 p.m. UTC | #4
Am 2021-12-23 13:44, schrieb Vladimir Oltean:
> On Thu, Dec 23, 2021 at 06:34:13AM +0000, Priyanka Jain wrote:
>> >The Linux side of device tree patches were merged today, and I see you've
>> >reviewed the U-Boot side of changes too. Could you please pick them up?
>> 
>> Yes, I will pick the series as part of next pull-request for 2022.04
> 
> Thanks. Could you also delete the '#include 
> "fsl-ls1028a-rdb-u-boot.dtsi"'
> line from patch 14/16 like Michael suggested, or should I resend for 
> that?

Patch 15/16 is also affected? I guess you took the linux dts and added
that include line afterwards? that shouldn't be necessary.

-michael
Vladimir Oltean Dec. 23, 2021, 12:49 p.m. UTC | #5
On Thu, Dec 23, 2021 at 01:47:48PM +0100, Michael Walle wrote:
> Am 2021-12-23 13:44, schrieb Vladimir Oltean:
> > On Thu, Dec 23, 2021 at 06:34:13AM +0000, Priyanka Jain wrote:
> > > >The Linux side of device tree patches were merged today, and I see you've
> > > >reviewed the U-Boot side of changes too. Could you please pick them up?
> > > 
> > > Yes, I will pick the series as part of next pull-request for 2022.04
> > 
> > Thanks. Could you also delete the '#include
> > "fsl-ls1028a-rdb-u-boot.dtsi"'
> > line from patch 14/16 like Michael suggested, or should I resend for
> > that?
> 
> Patch 15/16 is also affected? I guess you took the linux dts and added
> that include line afterwards? that shouldn't be necessary.

Alright, I'll send v3 later today or tomorrow.