mbox series

[v3,00/10] AM642-EVM: Add USB support

Message ID 20210604163043.12811-1-a-govindraju@ti.com
Headers show
Series AM642-EVM: Add USB support | expand

Message

Aswath Govindraju June 4, 2021, 4:30 p.m. UTC
The following series of patches add support for the following
- Kconfig symbol for giving the load address for ATF
- USB Mass storage boot mode in AM642-EVM
- DFU boot mode in AM642-EVM
- Host and peripheral modes for AM642-EVM in U-Boot
- Set the USB PHY core voltage to 0.85V

changes since v2,
- Increased the max size of ATF in patch 9
- Added reviewed-by from Suman Anna in patch 1
- Reworded the subject of patch 8

changes since v1,
- Corrected the default load address of ATF to
  0x70000000

Aswath Govindraju (10):
  tools: k3_fit_atf: Add support for providing ATF load address using a
    Kconfig symbol
  arm: mach-k3: am642_init: Add support for USB boot mode
  arm: mach-k3: am642_init: Do USB fixups to facilitate host and device
    boot modes
  board: ti: am64x: Set the core voltage of USB PHY to 0.85V
  arm: dts: k3-am64-main: Add USB DT nodes
  arm: dts: k3-am642-*-evm: Add USB support
  arm: dts: k3-am642-evm-u-boot: Add U-Boot tags and fix the dr_mode to
    peripheral for USB subsystem
  configs: am64x_evm_*_defconfig: Rearrange the components in SRAM to
    satisfy the limitations for USB DFU boot mode
  arm: dts: k3-am64-main: Update the location of ATF in SRAM and
    increase its max size
  configs: am64: Enable configs to support USB host and device modes

 arch/arm/dts/k3-am64-main.dtsi                | 32 ++++++++++++-
 arch/arm/dts/k3-am642-evm-u-boot.dtsi         | 13 ++++++
 arch/arm/dts/k3-am642-evm.dts                 | 18 ++++++++
 arch/arm/dts/k3-am642-r5-evm.dts              | 18 ++++++++
 arch/arm/mach-k3/Kconfig                      |  7 +++
 arch/arm/mach-k3/am642_init.c                 | 46 ++++++++++++++++++-
 arch/arm/mach-k3/config.mk                    |  1 +
 arch/arm/mach-k3/include/mach/am64_hardware.h | 11 +++--
 arch/arm/mach-k3/include/mach/am64_spl.h      |  6 ++-
 board/ti/am64x/evm.c                          | 14 ++++++
 configs/am64x_evm_a53_defconfig               | 40 ++++++++++++++++
 configs/am64x_evm_r5_defconfig                | 38 +++++++++++++--
 include/configs/am64x_evm.h                   | 15 +++++-
 tools/k3_fit_atf.sh                           |  9 ++--
 14 files changed, 251 insertions(+), 17 deletions(-)

Comments

Praneeth Bajjuri June 4, 2021, 4:48 p.m. UTC | #1
On 6/4/21 11:30 AM, Aswath Govindraju wrote:
> The following series of patches add support for the following
> - Kconfig symbol for giving the load address for ATF
> - USB Mass storage boot mode in AM642-EVM
> - DFU boot mode in AM642-EVM
> - Host and peripheral modes for AM642-EVM in U-Boot
> - Set the USB PHY core voltage to 0.85V
> 
> changes since v2,
> - Increased the max size of ATF in patch 9

Please confirm if this is tested on ATF 2.5 too.


> - Added reviewed-by from Suman Anna in patch 1
> - Reworded the subject of patch 8
> 
> changes since v1,
> - Corrected the default load address of ATF to
>    0x70000000
> 
> Aswath Govindraju (10):
>    tools: k3_fit_atf: Add support for providing ATF load address using a
>      Kconfig symbol
>    arm: mach-k3: am642_init: Add support for USB boot mode
>    arm: mach-k3: am642_init: Do USB fixups to facilitate host and device
>      boot modes
>    board: ti: am64x: Set the core voltage of USB PHY to 0.85V
>    arm: dts: k3-am64-main: Add USB DT nodes
>    arm: dts: k3-am642-*-evm: Add USB support
>    arm: dts: k3-am642-evm-u-boot: Add U-Boot tags and fix the dr_mode to
>      peripheral for USB subsystem
>    configs: am64x_evm_*_defconfig: Rearrange the components in SRAM to
>      satisfy the limitations for USB DFU boot mode
>    arm: dts: k3-am64-main: Update the location of ATF in SRAM and
>      increase its max size
>    configs: am64: Enable configs to support USB host and device modes
> 
>   arch/arm/dts/k3-am64-main.dtsi                | 32 ++++++++++++-
>   arch/arm/dts/k3-am642-evm-u-boot.dtsi         | 13 ++++++
>   arch/arm/dts/k3-am642-evm.dts                 | 18 ++++++++
>   arch/arm/dts/k3-am642-r5-evm.dts              | 18 ++++++++
>   arch/arm/mach-k3/Kconfig                      |  7 +++
>   arch/arm/mach-k3/am642_init.c                 | 46 ++++++++++++++++++-
>   arch/arm/mach-k3/config.mk                    |  1 +
>   arch/arm/mach-k3/include/mach/am64_hardware.h | 11 +++--
>   arch/arm/mach-k3/include/mach/am64_spl.h      |  6 ++-
>   board/ti/am64x/evm.c                          | 14 ++++++
>   configs/am64x_evm_a53_defconfig               | 40 ++++++++++++++++
>   configs/am64x_evm_r5_defconfig                | 38 +++++++++++++--
>   include/configs/am64x_evm.h                   | 15 +++++-
>   tools/k3_fit_atf.sh                           |  9 ++--
>   14 files changed, 251 insertions(+), 17 deletions(-)
>
Aswath Govindraju June 4, 2021, 4:49 p.m. UTC | #2
Hi Praneeth,

On 04/06/21 10:18 pm, Praneeth Bajjuri wrote:
> 
> 
> On 6/4/21 11:30 AM, Aswath Govindraju wrote:
>> The following series of patches add support for the following
>> - Kconfig symbol for giving the load address for ATF
>> - USB Mass storage boot mode in AM642-EVM
>> - DFU boot mode in AM642-EVM
>> - Host and peripheral modes for AM642-EVM in U-Boot
>> - Set the USB PHY core voltage to 0.85V
>>
>> changes since v2,
>> - Increased the max size of ATF in patch 9
> 
> Please confirm if this is tested on ATF 2.5 too.
> 

Sorry, for not mentioning it.

Yes, this series was tested using ATF 2.5.

Thanks,
Aswath

> 
>> - Added reviewed-by from Suman Anna in patch 1
>> - Reworded the subject of patch 8
>>
>> changes since v1,
>> - Corrected the default load address of ATF to
>>    0x70000000
>>
>> Aswath Govindraju (10):
>>    tools: k3_fit_atf: Add support for providing ATF load address using a
>>      Kconfig symbol
>>    arm: mach-k3: am642_init: Add support for USB boot mode
>>    arm: mach-k3: am642_init: Do USB fixups to facilitate host and device
>>      boot modes
>>    board: ti: am64x: Set the core voltage of USB PHY to 0.85V
>>    arm: dts: k3-am64-main: Add USB DT nodes
>>    arm: dts: k3-am642-*-evm: Add USB support
>>    arm: dts: k3-am642-evm-u-boot: Add U-Boot tags and fix the dr_mode to
>>      peripheral for USB subsystem
>>    configs: am64x_evm_*_defconfig: Rearrange the components in SRAM to
>>      satisfy the limitations for USB DFU boot mode
>>    arm: dts: k3-am64-main: Update the location of ATF in SRAM and
>>      increase its max size
>>    configs: am64: Enable configs to support USB host and device modes
>>
>>   arch/arm/dts/k3-am64-main.dtsi                | 32 ++++++++++++-
>>   arch/arm/dts/k3-am642-evm-u-boot.dtsi         | 13 ++++++
>>   arch/arm/dts/k3-am642-evm.dts                 | 18 ++++++++
>>   arch/arm/dts/k3-am642-r5-evm.dts              | 18 ++++++++
>>   arch/arm/mach-k3/Kconfig                      |  7 +++
>>   arch/arm/mach-k3/am642_init.c                 | 46 ++++++++++++++++++-
>>   arch/arm/mach-k3/config.mk                    |  1 +
>>   arch/arm/mach-k3/include/mach/am64_hardware.h | 11 +++--
>>   arch/arm/mach-k3/include/mach/am64_spl.h      |  6 ++-
>>   board/ti/am64x/evm.c                          | 14 ++++++
>>   configs/am64x_evm_a53_defconfig               | 40 ++++++++++++++++
>>   configs/am64x_evm_r5_defconfig                | 38 +++++++++++++--
>>   include/configs/am64x_evm.h                   | 15 +++++-
>>   tools/k3_fit_atf.sh                           |  9 ++--
>>   14 files changed, 251 insertions(+), 17 deletions(-)
>>
Praneeth Bajjuri June 4, 2021, 4:53 p.m. UTC | #3
Aswath, Suman, Dave, Gowtham, Vignesh

On 6/4/21 11:49 AM, Aswath Govindraju wrote:
> Hi Praneeth,
> 
> On 04/06/21 10:18 pm, Praneeth Bajjuri wrote:
>>
>>
>> On 6/4/21 11:30 AM, Aswath Govindraju wrote:
>>> The following series of patches add support for the following
>>> - Kconfig symbol for giving the load address for ATF
>>> - USB Mass storage boot mode in AM642-EVM
>>> - DFU boot mode in AM642-EVM
>>> - Host and peripheral modes for AM642-EVM in U-Boot
>>> - Set the USB PHY core voltage to 0.85V
>>>
>>> changes since v2,
>>> - Increased the max size of ATF in patch 9
>>
>> Please confirm if this is tested on ATF 2.5 too.
>>
> 
> Sorry, for not mentioning it.
> 
> Yes, this series was tested using ATF 2.5.

Ok , pulling to ti-u-boot.

Aswath:
1. Please send the updated series to upstream u-boot as well.
2. post the kernel dts change to mainline as well.

Vignesh,
Assuming you are pulling the KIG patch too.

Suman/Dave/Gowtham,
Assuming you are pulling the kernel patch too.



> 
> Thanks,
> Aswath
> 
>>
>>> - Added reviewed-by from Suman Anna in patch 1
>>> - Reworded the subject of patch 8
>>>
>>> changes since v1,
>>> - Corrected the default load address of ATF to
>>>     0x70000000
>>>
>>> Aswath Govindraju (10):
>>>     tools: k3_fit_atf: Add support for providing ATF load address using a
>>>       Kconfig symbol
>>>     arm: mach-k3: am642_init: Add support for USB boot mode
>>>     arm: mach-k3: am642_init: Do USB fixups to facilitate host and device
>>>       boot modes
>>>     board: ti: am64x: Set the core voltage of USB PHY to 0.85V
>>>     arm: dts: k3-am64-main: Add USB DT nodes
>>>     arm: dts: k3-am642-*-evm: Add USB support
>>>     arm: dts: k3-am642-evm-u-boot: Add U-Boot tags and fix the dr_mode to
>>>       peripheral for USB subsystem
>>>     configs: am64x_evm_*_defconfig: Rearrange the components in SRAM to
>>>       satisfy the limitations for USB DFU boot mode
>>>     arm: dts: k3-am64-main: Update the location of ATF in SRAM and
>>>       increase its max size
>>>     configs: am64: Enable configs to support USB host and device modes
>>>
>>>    arch/arm/dts/k3-am64-main.dtsi                | 32 ++++++++++++-
>>>    arch/arm/dts/k3-am642-evm-u-boot.dtsi         | 13 ++++++
>>>    arch/arm/dts/k3-am642-evm.dts                 | 18 ++++++++
>>>    arch/arm/dts/k3-am642-r5-evm.dts              | 18 ++++++++
>>>    arch/arm/mach-k3/Kconfig                      |  7 +++
>>>    arch/arm/mach-k3/am642_init.c                 | 46 ++++++++++++++++++-
>>>    arch/arm/mach-k3/config.mk                    |  1 +
>>>    arch/arm/mach-k3/include/mach/am64_hardware.h | 11 +++--
>>>    arch/arm/mach-k3/include/mach/am64_spl.h      |  6 ++-
>>>    board/ti/am64x/evm.c                          | 14 ++++++
>>>    configs/am64x_evm_a53_defconfig               | 40 ++++++++++++++++
>>>    configs/am64x_evm_r5_defconfig                | 38 +++++++++++++--
>>>    include/configs/am64x_evm.h                   | 15 +++++-
>>>    tools/k3_fit_atf.sh                           |  9 ++--
>>>    14 files changed, 251 insertions(+), 17 deletions(-)
>>>
>
Praneeth Bajjuri June 7, 2021, 4:16 a.m. UTC | #4
On 6/4/21 11:53 AM, Praneeth Bajjuri wrote:
> Aswath, Suman, Dave, Gowtham, Vignesh
> 
> On 6/4/21 11:49 AM, Aswath Govindraju wrote:
>> Hi Praneeth,
>>
>> On 04/06/21 10:18 pm, Praneeth Bajjuri wrote:
>>>
>>>
>>> On 6/4/21 11:30 AM, Aswath Govindraju wrote:
>>>> The following series of patches add support for the following
>>>> - Kconfig symbol for giving the load address for ATF
>>>> - USB Mass storage boot mode in AM642-EVM
>>>> - DFU boot mode in AM642-EVM
>>>> - Host and peripheral modes for AM642-EVM in U-Boot
>>>> - Set the USB PHY core voltage to 0.85V
>>>>
>>>> changes since v2,
>>>> - Increased the max size of ATF in patch 9
>>>
>>> Please confirm if this is tested on ATF 2.5 too.
>>>
>>
>> Sorry, for not mentioning it.
>>
>> Yes, this series was tested using ATF 2.5.
> 
> Ok , pulling to ti-u-boot.
> 
> Aswath:
> 1. Please send the updated series to upstream u-boot as well.
> 2. post the kernel dts change to mainline as well.
> 
> Vignesh,
> Assuming you are pulling the KIG patch too.
> 
> Suman/Dave/Gowtham,
> Assuming you are pulling the kernel patch too.

Please ignore this mail. was reviewing product baseline for same feature.

> 
> 
> 
>>
>> Thanks,
>> Aswath
>>
>>>
>>>> - Added reviewed-by from Suman Anna in patch 1
>>>> - Reworded the subject of patch 8
>>>>
>>>> changes since v1,
>>>> - Corrected the default load address of ATF to
>>>>     0x70000000
>>>>
>>>> Aswath Govindraju (10):
>>>>     tools: k3_fit_atf: Add support for providing ATF load address 
>>>> using a
>>>>       Kconfig symbol
>>>>     arm: mach-k3: am642_init: Add support for USB boot mode
>>>>     arm: mach-k3: am642_init: Do USB fixups to facilitate host and 
>>>> device
>>>>       boot modes
>>>>     board: ti: am64x: Set the core voltage of USB PHY to 0.85V
>>>>     arm: dts: k3-am64-main: Add USB DT nodes
>>>>     arm: dts: k3-am642-*-evm: Add USB support
>>>>     arm: dts: k3-am642-evm-u-boot: Add U-Boot tags and fix the 
>>>> dr_mode to
>>>>       peripheral for USB subsystem
>>>>     configs: am64x_evm_*_defconfig: Rearrange the components in SRAM to
>>>>       satisfy the limitations for USB DFU boot mode
>>>>     arm: dts: k3-am64-main: Update the location of ATF in SRAM and
>>>>       increase its max size
>>>>     configs: am64: Enable configs to support USB host and device modes
>>>>
>>>>    arch/arm/dts/k3-am64-main.dtsi                | 32 ++++++++++++-
>>>>    arch/arm/dts/k3-am642-evm-u-boot.dtsi         | 13 ++++++
>>>>    arch/arm/dts/k3-am642-evm.dts                 | 18 ++++++++
>>>>    arch/arm/dts/k3-am642-r5-evm.dts              | 18 ++++++++
>>>>    arch/arm/mach-k3/Kconfig                      |  7 +++
>>>>    arch/arm/mach-k3/am642_init.c                 | 46 
>>>> ++++++++++++++++++-
>>>>    arch/arm/mach-k3/config.mk                    |  1 +
>>>>    arch/arm/mach-k3/include/mach/am64_hardware.h | 11 +++--
>>>>    arch/arm/mach-k3/include/mach/am64_spl.h      |  6 ++-
>>>>    board/ti/am64x/evm.c                          | 14 ++++++
>>>>    configs/am64x_evm_a53_defconfig               | 40 ++++++++++++++++
>>>>    configs/am64x_evm_r5_defconfig                | 38 +++++++++++++--
>>>>    include/configs/am64x_evm.h                   | 15 +++++-
>>>>    tools/k3_fit_atf.sh                           |  9 ++--
>>>>    14 files changed, 251 insertions(+), 17 deletions(-)
>>>>
>>
Aswath Govindraju June 9, 2021, 12:30 p.m. UTC | #5
Hi,

On 04/06/21 10:00 pm, Aswath Govindraju wrote:
> The following series of patches add support for the following
> - Kconfig symbol for giving the load address for ATF
> - USB Mass storage boot mode in AM642-EVM
> - DFU boot mode in AM642-EVM
> - Host and peripheral modes for AM642-EVM in U-Boot
> - Set the USB PHY core voltage to 0.85V
> 
> changes since v2,
> - Increased the max size of ATF in patch 9
> - Added reviewed-by from Suman Anna in patch 1
> - Reworded the subject of patch 8
> 
> changes since v1,
> - Corrected the default load address of ATF to
>   0x70000000
> 

Sorry, forgot to mention earlier,

Patch 10 is dependent on,
https://patchwork.ozlabs.org/project/uboot/list/?series=246663

The above patch is now applied to u-boot/next


Thanks,
Aswath

> Aswath Govindraju (10):
>   tools: k3_fit_atf: Add support for providing ATF load address using a
>     Kconfig symbol
>   arm: mach-k3: am642_init: Add support for USB boot mode
>   arm: mach-k3: am642_init: Do USB fixups to facilitate host and device
>     boot modes
>   board: ti: am64x: Set the core voltage of USB PHY to 0.85V
>   arm: dts: k3-am64-main: Add USB DT nodes
>   arm: dts: k3-am642-*-evm: Add USB support
>   arm: dts: k3-am642-evm-u-boot: Add U-Boot tags and fix the dr_mode to
>     peripheral for USB subsystem
>   configs: am64x_evm_*_defconfig: Rearrange the components in SRAM to
>     satisfy the limitations for USB DFU boot mode
>   arm: dts: k3-am64-main: Update the location of ATF in SRAM and
>     increase its max size
>   configs: am64: Enable configs to support USB host and device modes
> 
>  arch/arm/dts/k3-am64-main.dtsi                | 32 ++++++++++++-
>  arch/arm/dts/k3-am642-evm-u-boot.dtsi         | 13 ++++++
>  arch/arm/dts/k3-am642-evm.dts                 | 18 ++++++++
>  arch/arm/dts/k3-am642-r5-evm.dts              | 18 ++++++++
>  arch/arm/mach-k3/Kconfig                      |  7 +++
>  arch/arm/mach-k3/am642_init.c                 | 46 ++++++++++++++++++-
>  arch/arm/mach-k3/config.mk                    |  1 +
>  arch/arm/mach-k3/include/mach/am64_hardware.h | 11 +++--
>  arch/arm/mach-k3/include/mach/am64_spl.h      |  6 ++-
>  board/ti/am64x/evm.c                          | 14 ++++++
>  configs/am64x_evm_a53_defconfig               | 40 ++++++++++++++++
>  configs/am64x_evm_r5_defconfig                | 38 +++++++++++++--
>  include/configs/am64x_evm.h                   | 15 +++++-
>  tools/k3_fit_atf.sh                           |  9 ++--
>  14 files changed, 251 insertions(+), 17 deletions(-)
>
Lokesh Vutla June 9, 2021, 4:55 p.m. UTC | #6
On Fri, 4 Jun 2021 22:00:30 +0530, Aswath Govindraju wrote:
> The following series of patches add support for the following
> - Kconfig symbol for giving the load address for ATF
> - USB Mass storage boot mode in AM642-EVM
> - DFU boot mode in AM642-EVM
> - Host and peripheral modes for AM642-EVM in U-Boot
> - Set the USB PHY core voltage to 0.85V
> 
> [...]
 
Applied to https://source.denx.de/u-boot/custodians/u-boot-ti.git master, thanks!
[01/10] tools: k3_fit_atf: Add support for providing ATF load address using a Kconfig symbol
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/0c51509224
[02/10] arm: mach-k3: am642_init: Add support for USB boot mode
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/3ae127c4e2
[03/10] arm: mach-k3: am642_init: Do USB fixups to facilitate host and device boot modes
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/669a03e0ff
[04/10] board: ti: am64x: Set the core voltage of USB PHY to 0.85V
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/397d7b0fae
[05/10] arm: dts: k3-am64-main: Add USB DT nodes
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/cdb738411f
[06/10] arm: dts: k3-am642-*-evm: Add USB support
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/7803a5bda9
[07/10] arm: dts: k3-am642-evm-u-boot: Add U-Boot tags and fix the dr_mode to peripheral for USB subsystem
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/1c8b404b88
[08/10] configs: am64x_evm_*_defconfig: Rearrange the components in SRAM to satisfy the limitations for USB DFU boot mode
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/26f32c32b2
[09/10] arm: dts: k3-am64-main: Update the location of ATF in SRAM and increase its max size
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/defd62ca13
[10/10] configs: am64: Enable configs to support USB host and device modes
        https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/ce7ad57390
 
--
Thanks and Regards,
Lokesh