mbox series

[v2,00/21] Add support for MMC higher speed modes for TI's am65x, j721e and j7200 platforms

Message ID 20201016110855.26078-1-faiz_abbas@ti.com
Headers show
Series Add support for MMC higher speed modes for TI's am65x, j721e and j7200 platforms | expand

Message

Faiz Abbas Oct. 16, 2020, 11:08 a.m. UTC
The following patches add support for higher speeds in the SD card and
eMMC for TI's am65x, j721e, j7200 platforms.

With these patches, the following max speeds are supported:
j721e: DDR50, HS200
j7200: SDR104, HS200
am65x: SDR104*, HS200

v2:
1. Added patches to support UHS modes for the SD card even in am654x platforms.
2. Fixed an issue with patch 1 that was breaking builds on some platforms.

* There's an issue with the am65x base board such that the power cycle
circuit to the card takes way longer than the wait time in mmc core.
Until this is fixed, am654x-evm and -idk will only support High speed mode
at 3.3V (see patch 20) but this shouldn't block us from adding UHS modes in the
dtsi as well as in the configs so other boards can still take advantage of the
higher speed. UHS modes have been tested by adding the appropriate delay in the
power cycle circuit.

Link to v1:
https://patchwork.ozlabs.org/project/uboot/list/?series=206622

Faiz Abbas (21):
  mmc: sdhci: Add helper functions for UHS modes
  mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of
    ios_post()
  mmc: am654_sdhci: Convert flag fields to BIT macro
  mmc: am654_sdhci: Add flag for PHY calibration
  mmc: am654_sdhci: Add support for AM65x SR2.0
  mmc: am654_sdhci: Add support for input tap delay
  mmc: am654_sdhci: Add support for writing to clkbuf_sel
  mmc: am654_sdhci: Add support for software tuning
  mmc: am654_sdhci: Fix HISPD bit configuration in some lower speed
    modes
  mmc: am654_sdhci: Use sdhci_set_control_reg()
  arm: dts: k3-am65: Fix mmc nodes
  arm: dts: k3-j721e-main: Update otap-delay values
  arm: dts: k3-j721e-common-proc-board: Add support for UHS modes for SD
    card
  arm: dts: k3-j7200-main: Add support for gpio0
  arm: dts: k3-j7200-common-proc-board: Enable support for UHS modes
  configs: j721e_evm: Add support for UHS modes
  configs: j7200_evm: Add support for UHS modes
  i2c: Makefile: Add SPL_DM_I2C_GPIO
  arm: dts: k3-am65-main: Add itapdly and clkbuf-sel values
  arm: dts: k3-am654-base-board: Limit Sd card to High speed modes
  configs: am65x_evm: Add configs for UHS modes

 arch/arm/dts/k3-am65-main.dtsi                |  31 ++
 arch/arm/dts/k3-am654-base-board-u-boot.dtsi  |  67 +--
 arch/arm/dts/k3-am654-base-board.dts          |  26 ++
 arch/arm/dts/k3-am654-r5-base-board.dts       |  20 +-
 arch/arm/dts/k3-j7200-common-proc-board.dts   |  49 ++-
 arch/arm/dts/k3-j7200-main.dtsi               |  23 ++
 .../arm/dts/k3-j7200-r5-common-proc-board.dts |  15 +
 arch/arm/dts/k3-j721e-common-proc-board.dts   |  32 ++
 arch/arm/dts/k3-j721e-main.dtsi               |   8 +-
 configs/am65x_evm_a53_defconfig               |   8 +
 configs/am65x_evm_r5_defconfig                |   2 +
 configs/j7200_evm_a72_defconfig               |   8 +
 configs/j7200_evm_r5_defconfig                |   1 +
 configs/j721e_evm_a72_defconfig               |   8 +
 configs/j721e_evm_r5_defconfig                |   1 +
 drivers/i2c/Makefile                          |   2 +-
 drivers/mmc/Kconfig                           |   1 +
 drivers/mmc/am654_sdhci.c                     | 384 +++++++++++++-----
 drivers/mmc/sdhci.c                           |  51 +++
 include/sdhci.h                               |   1 +
 20 files changed, 564 insertions(+), 174 deletions(-)

Comments

Peng Fan Oct. 19, 2020, 6:46 a.m. UTC | #1
> Subject: [PATCH v2 00/21] Add support for MMC higher speed modes for TI's
> am65x, j721e and j7200 platforms

For the mmc driver part, 

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> 
> The following patches add support for higher speeds in the SD card and eMMC
> for TI's am65x, j721e, j7200 platforms.
> 
> With these patches, the following max speeds are supported:
> j721e: DDR50, HS200
> j7200: SDR104, HS200
> am65x: SDR104*, HS200
> 
> v2:
> 1. Added patches to support UHS modes for the SD card even in am654x
> platforms.
> 2. Fixed an issue with patch 1 that was breaking builds on some platforms.
> 
> * There's an issue with the am65x base board such that the power cycle
> circuit to the card takes way longer than the wait time in mmc core.
> Until this is fixed, am654x-evm and -idk will only support High speed mode at
> 3.3V (see patch 20) but this shouldn't block us from adding UHS modes in the
> dtsi as well as in the configs so other boards can still take advantage of the
> higher speed. UHS modes have been tested by adding the appropriate delay in
> the power cycle circuit.
> 
> Link to v1:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D206622&amp;
> data=04%7C01%7Cpeng.fan%40nxp.com%7C60aff07a45894e36209308d871c
> 3e441%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6373844334
> 69526801%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=bRq92%2
> FV4JzEhNipqsw5%2BqsgTOfJPqsmaSe3%2BkmnU3%2BU%3D&amp;reserved
> =0
> 
> Faiz Abbas (21):
>   mmc: sdhci: Add helper functions for UHS modes
>   mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of
>     ios_post()
>   mmc: am654_sdhci: Convert flag fields to BIT macro
>   mmc: am654_sdhci: Add flag for PHY calibration
>   mmc: am654_sdhci: Add support for AM65x SR2.0
>   mmc: am654_sdhci: Add support for input tap delay
>   mmc: am654_sdhci: Add support for writing to clkbuf_sel
>   mmc: am654_sdhci: Add support for software tuning
>   mmc: am654_sdhci: Fix HISPD bit configuration in some lower speed
>     modes
>   mmc: am654_sdhci: Use sdhci_set_control_reg()
>   arm: dts: k3-am65: Fix mmc nodes
>   arm: dts: k3-j721e-main: Update otap-delay values
>   arm: dts: k3-j721e-common-proc-board: Add support for UHS modes for SD
>     card
>   arm: dts: k3-j7200-main: Add support for gpio0
>   arm: dts: k3-j7200-common-proc-board: Enable support for UHS modes
>   configs: j721e_evm: Add support for UHS modes
>   configs: j7200_evm: Add support for UHS modes
>   i2c: Makefile: Add SPL_DM_I2C_GPIO
>   arm: dts: k3-am65-main: Add itapdly and clkbuf-sel values
>   arm: dts: k3-am654-base-board: Limit Sd card to High speed modes
>   configs: am65x_evm: Add configs for UHS modes
> 
>  arch/arm/dts/k3-am65-main.dtsi                |  31 ++
>  arch/arm/dts/k3-am654-base-board-u-boot.dtsi  |  67 +--
>  arch/arm/dts/k3-am654-base-board.dts          |  26 ++
>  arch/arm/dts/k3-am654-r5-base-board.dts       |  20 +-
>  arch/arm/dts/k3-j7200-common-proc-board.dts   |  49 ++-
>  arch/arm/dts/k3-j7200-main.dtsi               |  23 ++
>  .../arm/dts/k3-j7200-r5-common-proc-board.dts |  15 +
>  arch/arm/dts/k3-j721e-common-proc-board.dts   |  32 ++
>  arch/arm/dts/k3-j721e-main.dtsi               |   8 +-
>  configs/am65x_evm_a53_defconfig               |   8 +
>  configs/am65x_evm_r5_defconfig                |   2 +
>  configs/j7200_evm_a72_defconfig               |   8 +
>  configs/j7200_evm_r5_defconfig                |   1 +
>  configs/j721e_evm_a72_defconfig               |   8 +
>  configs/j721e_evm_r5_defconfig                |   1 +
>  drivers/i2c/Makefile                          |   2 +-
>  drivers/mmc/Kconfig                           |   1 +
>  drivers/mmc/am654_sdhci.c                     | 384
> +++++++++++++-----
>  drivers/mmc/sdhci.c                           |  51 +++
>  include/sdhci.h                               |   1 +
>  20 files changed, 564 insertions(+), 174 deletions(-)
> 
> --
> 2.17.1