mbox series

[v4,0/7] wdt: Add support for watchdogs on Kendryte K210

Message ID 20200909210420.243190-1-seanga2@gmail.com
Headers show
Series wdt: Add support for watchdogs on Kendryte K210 | expand

Message

Sean Anderson Sept. 9, 2020, 9:04 p.m. UTC
This series depends on
https://patchwork.ozlabs.org/project/uboot/list/?series=200642

Changes in v4:
- Fix build error without CONFIG_CLK

Changes in v3:
- Note dependency on "time: Fix get_ticks being non-monotonic"
- Add a few signed-off-bys which were sent for version 1

Changes in v2:
- Fix fls being off-by-one when compared to log_2_n_round_up
- Move watchdog enable to k210.dtsi as it does not depend on anything
  board-specific.

Sean Anderson (7):
  wdt: dw: Switch to using fls for log2
  wdt: dw: Switch to if(CONFIG()) instead of using #if
  wdt: dw: Fix clock rate being off by 1000
  wdt: dw: Enable the clock before using it
  wdt: dw: Free the clock on error
  riscv: Add watchdog bindings for the k210
  riscv: Enable watchdog for the k210

 arch/riscv/dts/k210.dtsi          |  1 -
 board/sipeed/maix/Kconfig         |  2 ++
 drivers/watchdog/designware_wdt.c | 39 ++++++++++++++++++++-----------
 3 files changed, 27 insertions(+), 15 deletions(-)

Comments

Sean Anderson Oct. 1, 2020, 2:56 p.m. UTC | #1
On 9/9/20 5:04 PM, Sean Anderson wrote:
> This series depends on
> https://patchwork.ozlabs.org/project/uboot/list/?series=200642
> 
> Changes in v4:
> - Fix build error without CONFIG_CLK
> 
> Changes in v3:
> - Note dependency on "time: Fix get_ticks being non-monotonic"
> - Add a few signed-off-bys which were sent for version 1
> 
> Changes in v2:
> - Fix fls being off-by-one when compared to log_2_n_round_up
> - Move watchdog enable to k210.dtsi as it does not depend on anything
>   board-specific.
> 
> Sean Anderson (7):
>   wdt: dw: Switch to using fls for log2
>   wdt: dw: Switch to if(CONFIG()) instead of using #if
>   wdt: dw: Fix clock rate being off by 1000
>   wdt: dw: Enable the clock before using it
>   wdt: dw: Free the clock on error
>   riscv: Add watchdog bindings for the k210
>   riscv: Enable watchdog for the k210
> 
>  arch/riscv/dts/k210.dtsi          |  1 -
>  board/sipeed/maix/Kconfig         |  2 ++
>  drivers/watchdog/designware_wdt.c | 39 ++++++++++++++++++++-----------
>  3 files changed, 27 insertions(+), 15 deletions(-)
> 

*ping*

Marek can these go into -next?

--Sean
Sean Anderson Oct. 23, 2020, 1:30 p.m. UTC | #2
On 10/1/20 10:56 AM, Sean Anderson wrote:
> On 9/9/20 5:04 PM, Sean Anderson wrote:
>> This series depends on
>> https://patchwork.ozlabs.org/project/uboot/list/?series=200642
>>
>> Changes in v4:
>> - Fix build error without CONFIG_CLK
>>
>> Changes in v3:
>> - Note dependency on "time: Fix get_ticks being non-monotonic"
>> - Add a few signed-off-bys which were sent for version 1
>>
>> Changes in v2:
>> - Fix fls being off-by-one when compared to log_2_n_round_up
>> - Move watchdog enable to k210.dtsi as it does not depend on anything
>>   board-specific.
>>
>> Sean Anderson (7):
>>   wdt: dw: Switch to using fls for log2
>>   wdt: dw: Switch to if(CONFIG()) instead of using #if
>>   wdt: dw: Fix clock rate being off by 1000
>>   wdt: dw: Enable the clock before using it
>>   wdt: dw: Free the clock on error
>>   riscv: Add watchdog bindings for the k210
>>   riscv: Enable watchdog for the k210
>>
>>  arch/riscv/dts/k210.dtsi          |  1 -
>>  board/sipeed/maix/Kconfig         |  2 ++
>>  drivers/watchdog/designware_wdt.c | 39 ++++++++++++++++++++-----------
>>  3 files changed, 27 insertions(+), 15 deletions(-)
>>
> 
> *ping*
> 
> Marek can these go into -next?
> 
> --Sean
> 

*second ping*

It appears that an earlier version of this series [1] was assigned to
Marek Vasut, but that the current version is assigned to Rick Chen. v2
should be marked as superseded. Can this get picked up for the merge
window?

--Sean

[1] https://patchwork.ozlabs.org/project/uboot/list/?series=194673
[2] https://patchwork.ozlabs.org/project/uboot/list/?series=200657
Tom Rini Oct. 26, 2020, 9:23 p.m. UTC | #3
On Fri, Oct 23, 2020 at 09:30:24AM -0400, Sean Anderson wrote:
> 
> On 10/1/20 10:56 AM, Sean Anderson wrote:
> > On 9/9/20 5:04 PM, Sean Anderson wrote:
> >> This series depends on
> >> https://patchwork.ozlabs.org/project/uboot/list/?series=200642
> >>
> >> Changes in v4:
> >> - Fix build error without CONFIG_CLK
> >>
> >> Changes in v3:
> >> - Note dependency on "time: Fix get_ticks being non-monotonic"
> >> - Add a few signed-off-bys which were sent for version 1
> >>
> >> Changes in v2:
> >> - Fix fls being off-by-one when compared to log_2_n_round_up
> >> - Move watchdog enable to k210.dtsi as it does not depend on anything
> >>   board-specific.
> >>
> >> Sean Anderson (7):
> >>   wdt: dw: Switch to using fls for log2
> >>   wdt: dw: Switch to if(CONFIG()) instead of using #if
> >>   wdt: dw: Fix clock rate being off by 1000
> >>   wdt: dw: Enable the clock before using it
> >>   wdt: dw: Free the clock on error
> >>   riscv: Add watchdog bindings for the k210
> >>   riscv: Enable watchdog for the k210
> >>
> >>  arch/riscv/dts/k210.dtsi          |  1 -
> >>  board/sipeed/maix/Kconfig         |  2 ++
> >>  drivers/watchdog/designware_wdt.c | 39 ++++++++++++++++++++-----------
> >>  3 files changed, 27 insertions(+), 15 deletions(-)
> >>
> > 
> > *ping*
> > 
> > Marek can these go into -next?
> > 
> > --Sean
> > 
> 
> *second ping*
> 
> It appears that an earlier version of this series [1] was assigned to
> Marek Vasut, but that the current version is assigned to Rick Chen. v2
> should be marked as superseded. Can this get picked up for the merge
> window?

The v2 mess-up was me, probably, some typo or another.  For v4, it looks
fine to me.  Rick?
Rick Chen Nov. 4, 2020, 2:08 a.m. UTC | #4
<rick@andestech.com> 於 2020年11月4日 週三 上午10:01寫道:
>
>
>
> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Sean Anderson
> Sent: Friday, October 23, 2020 9:30 PM
> To: u-boot@lists.denx.de
> Cc: Bin Meng; Marek Vasut; Jagan Teki; Simon Glass; Heinrich Schuchardt
> Subject: Re: [PATCH v4 0/7] wdt: Add support for watchdogs on Kendryte K210
>
>
> On 10/1/20 10:56 AM, Sean Anderson wrote:
> > On 9/9/20 5:04 PM, Sean Anderson wrote:
> >> This series depends on
> >> https://patchwork.ozlabs.org/project/uboot/list/?series=200642
> >>
> >> Changes in v4:
> >> - Fix build error without CONFIG_CLK
> >>
> >> Changes in v3:
> >> - Note dependency on "time: Fix get_ticks being non-monotonic"
> >> - Add a few signed-off-bys which were sent for version 1
> >>
> >> Changes in v2:
> >> - Fix fls being off-by-one when compared to log_2_n_round_up
> >> - Move watchdog enable to k210.dtsi as it does not depend on anything
> >>   board-specific.
> >>
> >> Sean Anderson (7):
> >>   wdt: dw: Switch to using fls for log2
> >>   wdt: dw: Switch to if(CONFIG()) instead of using #if
> >>   wdt: dw: Fix clock rate being off by 1000
> >>   wdt: dw: Enable the clock before using it
> >>   wdt: dw: Free the clock on error
> >>   riscv: Add watchdog bindings for the k210
> >>   riscv: Enable watchdog for the k210
> >>
> >>  arch/riscv/dts/k210.dtsi          |  1 -
> >>  board/sipeed/maix/Kconfig         |  2 ++
> >>  drivers/watchdog/designware_wdt.c | 39 ++++++++++++++++++++-----------
> >>  3 files changed, 27 insertions(+), 15 deletions(-)
> >>
> >
> > *ping*
> >
> > Marek can these go into -next?
> >
> > --Sean
> >
>
> *second ping*
>
> It appears that an earlier version of this series [1] was assigned to
> Marek Vasut, but that the current version is assigned to Rick Chen. v2
> should be marked as superseded. Can this get picked up for the merge
> window?

Those patchs seem have been reviewed and tagged.
If no other comments furthermore.
I can help to pull via riscv tree later.

But it shall sync to master again:
Applying: wdt: dw: Switch to using fls for log2
Applying: wdt: dw: Switch to if(CONFIG()) instead of using #if
Applying: wdt: dw: Fix clock rate being off by 1000
error: patch failed: drivers/watchdog/designware_wdt.c:129
error: drivers/watchdog/designware_wdt.c: patch does not apply
Patch failed at 0003 wdt: dw: Fix clock rate being off by 1000

Thanks,
Rick

>
> --Sean
>
> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=194673
> [2] https://patchwork.ozlabs.org/project/uboot/list/?series=200657