mbox series

[0/3] Rename ASPEED SoC clock name

Message ID 20200828073301.27866-1-ryan_chen@aspeedtech.com
Headers show
Series Rename ASPEED SoC clock name | expand

Message

Ryan Chen Aug. 28, 2020, 7:32 a.m. UTC
This patch series refactor the exiting ASPEED clock name define sync
with Linux kernel. And also add SPDX-License

Ryan Chen (3):
  cosmetic: aspeed: ast2500: Rename clock header
  aspeed:clock: Sync with Linux kernel clock header define
  cosmetic: aspeed: Modify for SPDX-License

 arch/arm/dts/ast2500-u-boot.dtsi             | 23 ++++++-----
 arch/arm/mach-aspeed/ast2500/sdram_ast2500.c |  2 +-
 drivers/clk/aspeed/clk_ast2500.c             | 40 +++++++++----------
 include/dt-bindings/clock/aspeed-clock.h     | 42 ++++++++++++++++++++
 include/dt-bindings/clock/ast2500-scu.h      | 30 --------------
 5 files changed, 74 insertions(+), 63 deletions(-)
 create mode 100644 include/dt-bindings/clock/aspeed-clock.h
 delete mode 100644 include/dt-bindings/clock/ast2500-scu.h

Comments

Cédric Le Goater Aug. 29, 2020, 8:45 a.m. UTC | #1
Hello Ryan, 

On 8/28/20 9:32 AM, Ryan Chen wrote:
> This patch series refactor the exiting ASPEED clock name define sync
> with Linux kernel. And also add SPDX-License

All the patchset seems correct but the patch numbering is a bit 
confusing. I have received : 

 [1/3] cosmetic: aspeed: ast2500: Rename clock header
 [1/1] Remove not used export function header.
 [2/3] aspeed:clock: Sync with Linux kernel clock header define
 [3/3] cosmetic: aspeed: Modify for SPDX-License

Could you please merge the first two together maybe and resend ? 

Thanks,

C. 

> Ryan Chen (3):
>   cosmetic: aspeed: ast2500: Rename clock header
>   aspeed:clock: Sync with Linux kernel clock header define
>   cosmetic: aspeed: Modify for SPDX-License
> 
>  arch/arm/dts/ast2500-u-boot.dtsi             | 23 ++++++-----
>  arch/arm/mach-aspeed/ast2500/sdram_ast2500.c |  2 +-
>  drivers/clk/aspeed/clk_ast2500.c             | 40 +++++++++----------
>  include/dt-bindings/clock/aspeed-clock.h     | 42 ++++++++++++++++++++
>  include/dt-bindings/clock/ast2500-scu.h      | 30 --------------
>  5 files changed, 74 insertions(+), 63 deletions(-)
>  create mode 100644 include/dt-bindings/clock/aspeed-clock.h
>  delete mode 100644 include/dt-bindings/clock/ast2500-scu.h
>
Ryan Chen Aug. 31, 2020, 1:26 a.m. UTC | #2
> -----Original Message-----
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Saturday, August 29, 2020 4:46 PM
> To: Ryan Chen <ryan_chen@aspeedtech.com>; ChiaWei Wang
> <chiawei_wang@aspeedtech.com>; BMC-SW <BMC-SW@aspeedtech.com>;
> lukma@denx.de; eajames@linux.ibm.com; sjg@chromium.org;
> u-boot@lists.denx.de; Joel Stanley <jmstanle@au1.ibm.com>
> Subject: Re: [PATCH 0/3] Rename ASPEED SoC clock name
> 
> Hello Ryan,
> 
> On 8/28/20 9:32 AM, Ryan Chen wrote:
> > This patch series refactor the exiting ASPEED clock name define sync
> > with Linux kernel. And also add SPDX-License
> 
> All the patchset seems correct but the patch numbering is a bit confusing. I
> have received :
> 
>  [1/3] cosmetic: aspeed: ast2500: Rename clock header  [1/1] Remove not
> used export function header.
>  [2/3] aspeed:clock: Sync with Linux kernel clock header define  [3/3]
> cosmetic: aspeed: Modify for SPDX-License
> 
> Could you please merge the first two together maybe and resend ?
> 
> Thanks,
> 
> C.
> 
Thanks the review. I will resend it for v2. 

> > Ryan Chen (3):
> >   cosmetic: aspeed: ast2500: Rename clock header
> >   aspeed:clock: Sync with Linux kernel clock header define
> >   cosmetic: aspeed: Modify for SPDX-License
> >
> >  arch/arm/dts/ast2500-u-boot.dtsi             | 23 ++++++-----
> >  arch/arm/mach-aspeed/ast2500/sdram_ast2500.c |  2 +-
> >  drivers/clk/aspeed/clk_ast2500.c             | 40 +++++++++----------
> >  include/dt-bindings/clock/aspeed-clock.h     | 42
> ++++++++++++++++++++
> >  include/dt-bindings/clock/ast2500-scu.h      | 30 --------------
> >  5 files changed, 74 insertions(+), 63 deletions(-)  create mode
> > 100644 include/dt-bindings/clock/aspeed-clock.h
> >  delete mode 100644 include/dt-bindings/clock/ast2500-scu.h
> >