| Message ID | 20200811131755.22396-1-joaomarcos.costa@bootlin.com |
|---|---|
| Headers | show |
| Series | fs/squashfs: Add new decompression algorithms | expand |
On Tue, Aug 11, 2020 at 03:17:53PM +0200, Joao Marcos Costa wrote: > Hello, > > Following the SquashFS support, this series adds support for LZO and ZSTD > algorithms. The only compression type enabled by default is ZLIB, so LZO > and ZSTD need to be manually selected. > > Joao Marcos Costa (2): > fs/squashfs: add support for LZO decompression > fs/squashfs: add support for ZSTD decompression > > fs/squashfs/sqfs_decompressor.c | 60 +++++++++++++++++++++++++++++++-- > 1 file changed, 58 insertions(+), 2 deletions(-) Can we add tests for this to sandbox? Thanks!
On Tue, 11 Aug 2020 11:13:41 -0400 Tom Rini <trini@konsulko.com> wrote: > On Tue, Aug 11, 2020 at 03:17:53PM +0200, Joao Marcos Costa wrote: > > > Hello, > > > > Following the SquashFS support, this series adds support for LZO > > and ZSTD algorithms. The only compression type enabled by default > > is ZLIB, so LZO and ZSTD need to be manually selected. > > > > Joao Marcos Costa (2): > > fs/squashfs: add support for LZO decompression > > fs/squashfs: add support for ZSTD decompression > > > > fs/squashfs/sqfs_decompressor.c | 60 > > +++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), > > 2 deletions(-) > > Can we add tests for this to sandbox? Thanks! Sure, I will enable the lzo and zstd configs for, and I will make some actual changes to the test scripts I added, because right now they are not really "scalable" (thinking of new compression algorithms). Best regards, Joao
On Tue, 11 Aug 2020 11:13:41 -0400 Tom Rini <trini@konsulko.com> wrote: > On Tue, Aug 11, 2020 at 03:17:53PM +0200, Joao Marcos Costa wrote: > > > Hello, > > > > Following the SquashFS support, this series adds support for LZO > > and ZSTD algorithms. The only compression type enabled by default > > is ZLIB, so LZO and ZSTD need to be manually selected. > > > > Joao Marcos Costa (2): > > fs/squashfs: add support for LZO decompression > > fs/squashfs: add support for ZSTD decompression > > > > fs/squashfs/sqfs_decompressor.c | 60 > > +++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), > > 2 deletions(-) > > Can we add tests for this to sandbox? Thanks! > Hello, Is there any way to check the package version with the python API? I already use 'requiredtool' marker, but apparently it is not enough. My host machine (Ubuntu 18.04) has mksquashfs at its version 4.3, without zstd support. However, v4.4 has such support, and I had to download it and build it myself to use zstd compression. The tests will fail if the user has an older version of mksquashfs installed. Would you have any suggestion on how to proceed? Best regards, Joao
On Wed, Aug 12, 2020 at 05:13:06PM +0200, Joao Marcos Costa wrote: > On Tue, 11 Aug 2020 11:13:41 -0400 > Tom Rini <trini@konsulko.com> wrote: > > > On Tue, Aug 11, 2020 at 03:17:53PM +0200, Joao Marcos Costa wrote: > > > > > Hello, > > > > > > Following the SquashFS support, this series adds support for LZO > > > and ZSTD algorithms. The only compression type enabled by default > > > is ZLIB, so LZO and ZSTD need to be manually selected. > > > > > > Joao Marcos Costa (2): > > > fs/squashfs: add support for LZO decompression > > > fs/squashfs: add support for ZSTD decompression > > > > > > fs/squashfs/sqfs_decompressor.c | 60 > > > +++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), > > > 2 deletions(-) > > > > Can we add tests for this to sandbox? Thanks! > > > > Hello, > > Is there any way to check the package version with the python API? I > already use 'requiredtool' marker, but apparently it is not enough. My > host machine (Ubuntu 18.04) has mksquashfs at its version 4.3, without > zstd support. However, v4.4 has such support, and I had to download it > and build it myself to use zstd compression. The tests will fail if the > user has an older version of mksquashfs installed. Would you have any > suggestion on how to proceed? This sounds like the cases where we have to build the tools we need. There's an example in .travis.yml for QEMU already, and we use https://gitlab.denx.de/u-boot/gitlab-ci-runner/ for Azure/GitLab. Testing those with your own container does require setting up an Azure account or using your own GitLab + runner. That said, if you unit test things and are confident it won't blow up when I test it, that can be good enough. Thanks!