mbox series

[0/3] sunxi: produce working binaries by default

Message ID 20200323140348.26717-1-ynezz@true.cz
Headers show
Series sunxi: produce working binaries by default | expand

Message

Petr Štetiar March 23, 2020, 2:03 p.m. UTC
Hi,

currently its not possible to distinguish between normal builds and
builds performed by the build bots/CI, thus leading to a workarounds
like for example in commit 4c78028737c3 ("mksunxi_fit_atf.sh: Allow for
this to complete when bl31.bin is missing"), where producing unusable
binaries is preferred in favor of a green automatic builds.

So lets try to fix this properly, add BUILDBOT config options which
could be set on the build bots/CI and the codebase can use this new
config option to workaround the issues in more clear manner.

While at it, replace .its generator script with more generic Dust
template based approach, which should allow for more code sharing
between boards and thus reduce code duplication.

Cheers,

Petr

Ref: https://lists.denx.de/pipermail/u-boot/2020-March/403105.html
Ref: https://lists.denx.de/pipermail/u-boot/2020-March/403650.html
Ref: https://lists.denx.de/pipermail/u-boot/2019-December/393556.html
Cc: Harald Seiler <hws@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Cc: Michal Simek <michal.simek@xilinx.com>

Petr Štetiar (3):
  Kconfig: add config options for automatic builds
  tools: add Dust based .its file templating
  sunxi: replace .its file generator with Dust template

 Kconfig                        |   17 +-
 Makefile                       |    8 +
 board/sunxi/mksunxi_fit_atf.sh |   87 -
 board/sunxi/u-boot-its.mk      |   19 +
 board/sunxi/u-boot.its.dust    |   45 +
 include/u-boot-its.mk          |   37 +
 tools/ashes/ashes.py           | 2723 ++++++++++++++++++++++++++++++++
 7 files changed, 2848 insertions(+), 88 deletions(-)
 delete mode 100755 board/sunxi/mksunxi_fit_atf.sh
 create mode 100644 board/sunxi/u-boot-its.mk
 create mode 100644 board/sunxi/u-boot.its.dust
 create mode 100644 include/u-boot-its.mk
 create mode 100755 tools/ashes/ashes.py

Comments

Peter Robinson March 23, 2020, 2:14 p.m. UTC | #1
Hi Petr,

> currently its not possible to distinguish between normal builds and
> builds performed by the build bots/CI, thus leading to a workarounds
> like for example in commit 4c78028737c3 ("mksunxi_fit_atf.sh: Allow for
> this to complete when bl31.bin is missing"), where producing unusable
> binaries is preferred in favor of a green automatic builds.
>
> So lets try to fix this properly, add BUILDBOT config options which
> could be set on the build bots/CI and the codebase can use this new
> config option to workaround the issues in more clear manner.
>
> While at it, replace .its generator script with more generic Dust
> template based approach, which should allow for more code sharing
> between boards and thus reduce code duplication.

I'm not sure what Dust is but a the original script for making the
.itb files was based on python with pyelftools dep and some we're
happy with the added python deps it so it was rewritten into the
latest shell script. I'm not sure from looking what extra deps the
dust templating adds vs other options but it's worth the
consideration.

Peter

> Cheers,
>
> Petr
>
> Ref: https://lists.denx.de/pipermail/u-boot/2020-March/403105.html
> Ref: https://lists.denx.de/pipermail/u-boot/2020-March/403650.html
> Ref: https://lists.denx.de/pipermail/u-boot/2019-December/393556.html
> Cc: Harald Seiler <hws@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
>
> Petr Štetiar (3):
>   Kconfig: add config options for automatic builds
>   tools: add Dust based .its file templating
>   sunxi: replace .its file generator with Dust template
>
>  Kconfig                        |   17 +-
>  Makefile                       |    8 +
>  board/sunxi/mksunxi_fit_atf.sh |   87 -
>  board/sunxi/u-boot-its.mk      |   19 +
>  board/sunxi/u-boot.its.dust    |   45 +
>  include/u-boot-its.mk          |   37 +
>  tools/ashes/ashes.py           | 2723 ++++++++++++++++++++++++++++++++
>  7 files changed, 2848 insertions(+), 88 deletions(-)
>  delete mode 100755 board/sunxi/mksunxi_fit_atf.sh
>  create mode 100644 board/sunxi/u-boot-its.mk
>  create mode 100644 board/sunxi/u-boot.its.dust
>  create mode 100644 include/u-boot-its.mk
>  create mode 100755 tools/ashes/ashes.py
>