| Message ID | 20180725031835.5666-1-vagrant@debian.org |
|---|---|
| Headers | show |
| Series | arm: odroid: Convert to distro_bootcmd. | expand |
Hi Vagrant, > Switch odroid platform to use distro_bootcmd, adjusting to use > standardized environment variable names, and use the default > bootdelay. > > The additional environment variables from distro_bootcmd requires > increasing the default environment size, which would break backwards > compatibility with saved environments. At Marek's suggestion, I've > bumped it well over the size needed (~4.5k vs. 16k) to give room for > future growth. > > Variations on these patches have been in use in Debian's u-boot > packages since 2016. > > A variation of this patch series was originally submitted to u-boot > over a year ago, and resent a few times since, with little to no > response. Yes, the Samsung port of u-boot could work better. I think that Tom can apply those patches directly if no response is given in a reasonable time. > > Thanks for considering! I would like to emphasize this one more time - thanks for your patches. > > Changes in v2: > - Change from 16384 to SZ_16K, as suggested by Minkyu Kang. > > Vagrant Cascadian (4): > arm: odroid: Use standard environment variable names kernel_addr_r, > ramdisk_addr_r and fdt_addr_r. > arm: odroid: Increase default env size in preparation for > distro_bootcmd. > arm: odroid: Enable distro_bootcmd support. > arm: odroid: Inherit default value for bootdelay from > distro_bootcmd. > > include/configs/odroid.h | 36 ++++++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 16 deletions(-) > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Hi, 2018년 7월 25일 (수) 16:25, Lukasz Majewski <lukma@denx.de>님이 작성: > Hi Vagrant, > > > Switch odroid platform to use distro_bootcmd, adjusting to use > > standardized environment variable names, and use the default > > bootdelay. > > > > The additional environment variables from distro_bootcmd requires > > increasing the default environment size, which would break backwards > > compatibility with saved environments. At Marek's suggestion, I've > > bumped it well over the size needed (~4.5k vs. 16k) to give room for > > future growth. > > > > Variations on these patches have been in use in Debian's u-boot > > packages since 2016. > > > > A variation of this patch series was originally submitted to u-boot > > over a year ago, and resent a few times since, with little to no > > response. > > Yes, the Samsung port of u-boot could work better. > > I think that Tom can apply those patches directly if no response is > given in a reasonable time. > I was waiting v2 of this patchset. It will be accepted soon. > > > > Thanks for considering! > > I would like to emphasize this one more time - thanks for your patches. > > > > > Changes in v2: > > - Change from 16384 to SZ_16K, as suggested by Minkyu Kang. > > > > Vagrant Cascadian (4): > > arm: odroid: Use standard environment variable names kernel_addr_r, > > ramdisk_addr_r and fdt_addr_r. > > arm: odroid: Increase default env size in preparation for > > distro_bootcmd. > > arm: odroid: Enable distro_bootcmd support. > > arm: odroid: Inherit default value for bootdelay from > > distro_bootcmd. > > > > include/configs/odroid.h | 36 ++++++++++++++++++++---------------- > > 1 file changed, 20 insertions(+), 16 deletions(-) > > > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Thanks, Minkyu Kang.
Hi, 2018년 7월 25일 (수) 16:45, Minkyu Kang <promsoft@gmail.com>님이 작성: > Hi, > > 2018년 7월 25일 (수) 16:25, Lukasz Majewski <lukma@denx.de>님이 작성: > >> Hi Vagrant, >> >> > Switch odroid platform to use distro_bootcmd, adjusting to use >> > standardized environment variable names, and use the default >> > bootdelay. >> > >> > The additional environment variables from distro_bootcmd requires >> > increasing the default environment size, which would break backwards >> > compatibility with saved environments. At Marek's suggestion, I've >> > bumped it well over the size needed (~4.5k vs. 16k) to give room for >> > future growth. >> > >> > Variations on these patches have been in use in Debian's u-boot >> > packages since 2016. >> > >> > A variation of this patch series was originally submitted to u-boot >> > over a year ago, and resent a few times since, with little to no >> > response. >> >> Yes, the Samsung port of u-boot could work better. >> >> I think that Tom can apply those patches directly if no response is >> given in a reasonable time. >> > > I was waiting v2 of this patchset. > It will be accepted soon. > > >> > >> > Thanks for considering! >> >> I would like to emphasize this one more time - thanks for your patches. >> >> > >> > Changes in v2: >> > - Change from 16384 to SZ_16K, as suggested by Minkyu Kang. >> > >> > Vagrant Cascadian (4): >> > arm: odroid: Use standard environment variable names kernel_addr_r, >> > ramdisk_addr_r and fdt_addr_r. >> > arm: odroid: Increase default env size in preparation for >> > distro_bootcmd. >> > arm: odroid: Enable distro_bootcmd support. >> > arm: odroid: Inherit default value for bootdelay from >> > distro_bootcmd. >> > >> > include/configs/odroid.h | 36 ++++++++++++++++++++---------------- >> > 1 file changed, 20 insertions(+), 16 deletions(-) >> > >> >> >> >> >> Best regards, >> >> Lukasz Majewski >> >> -- >> >> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de > > > Thanks, > Minkyu Kang. > applied to u-boot-samsung. Thanks, Minkyu Kang. >
Switch odroid platform to use distro_bootcmd, adjusting to use standardized environment variable names, and use the default bootdelay. The additional environment variables from distro_bootcmd requires increasing the default environment size, which would break backwards compatibility with saved environments. At Marek's suggestion, I've bumped it well over the size needed (~4.5k vs. 16k) to give room for future growth. Variations on these patches have been in use in Debian's u-boot packages since 2016. A variation of this patch series was originally submitted to u-boot over a year ago, and resent a few times since, with little to no response. Thanks for considering! Changes in v2: - Change from 16384 to SZ_16K, as suggested by Minkyu Kang. Vagrant Cascadian (4): arm: odroid: Use standard environment variable names kernel_addr_r, ramdisk_addr_r and fdt_addr_r. arm: odroid: Increase default env size in preparation for distro_bootcmd. arm: odroid: Enable distro_bootcmd support. arm: odroid: Inherit default value for bootdelay from distro_bootcmd. include/configs/odroid.h | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-)