mbox series

[U-Boot,v1,0/5] rtc: remove redundant code in rtc_reset

Message ID 20180321024037.26393-1-judge.packham@gmail.com
Headers show
Series rtc: remove redundant code in rtc_reset | expand

Message

Chris Packham March 21, 2018, 2:40 a.m. UTC 
Someone at $dayjob pointed out some inconsistent behaviour between the
ds1307 and the ds1337 rtc drivers for an old version of u-boot.
Basically with ds1307 "date reset" changed the time whereas for the
ds1337 it did not.

I was about to send a patch to add code to ds1337 when I noticed Marek's
commit 1a1fa2406689 ("rtc: Set valid date after reset"). This meant that
newer versions of u-boot did indeed have consistent behaviour for "date
reset" regardless of the rtc driver but now there were a handful of
drivers that had redundant code to do something that is now handled in
the generic layers.

This series removes the now redundant code from the affected drivers.
I've compile tested these changes but I only have access to hardware
with ds1307/ds1337 (or variants thereof) so I haven't been able to test
the last 4 patches on actual hardware.


Chris Packham (5):
  rtc: ds1307: remove redundant code in rtc_reset
  rtc: ds1374: remove redundant code in rtc_reset
  rtc: mx27rtc: remove redundant code in rtc_reset
  rtc: rs5c372: remove redundant code in rtc_reset
  rtc: rx8025: remove redundant code in rtc_reset

 drivers/rtc/ds1307.c  | 33 ---------------------------------
 drivers/rtc/ds1374.c  | 15 ---------------
 drivers/rtc/mx27rtc.c |  6 +-----
 drivers/rtc/rs5c372.c | 24 +-----------------------
 drivers/rtc/rx8025.c  | 18 +-----------------
 5 files changed, 3 insertions(+), 93 deletions(-)