Message ID | 1584019434-45856-1-git-send-email-chee.hong.ang@intel.com |
---|---|
Headers | show |
Series | Enable ARM Trusted Firmware for U-Boot | expand |
Any comment on this v5 patchsets ? > From: "Ang, Chee Hong" <chee.hong.ang@intel.com> > > v5 changes: > This is another revision without the System Manager driver to handle the > secure/non-secure access. DW MAC and MMC drivers will make direct calls to > the high-level API to ATF if it's running in EL2 on Stratix10/Agilex otherwise these > drivers work as it is. > > [PATCH v5 08/17] arm: socfpga: Define SMC function identifiers for PSCI SiP > services > - Add documentation for high-level API supported by ATF: > - INTEL_SIP_SMC_FUNCID_HPS_SET_PHYINTF (For setting PHY interface) > - INTEL_SIP_SMC_FUNCID_HPS_SET_SDMMC_CCLK (For setting SDMMC clock > phase) > > [PATCH v5 10/17] mmc: dwmmc: socfpga: Add ATF support for MMC driver > - Call 'INTEL_SIP_SMC_FUNCID_HPS_SET_SDMMC_CCLK' if U-Boot running in > EL2 (non-secure) > > [PATCH v5 11/17] net: designware: socfpga: Add ATF support for MAC driver > - Call 'INTEL_SIP_SMC_FUNCID_HPS_SET_PHYINTF' if U-Boot running in EL2 > (non-secure) > > [PATCH v5 17/17] configs: socfpga: Add defconfig for Agilex and Stratix 10 with > ATF support > - Keep the existing Stratix10/Agilex defconfigs and add new defconfigs with ATF > support > > v4: > https://lists.denx.de/pipermail/u-boot/2020-March/402289.html > > These patchsets have dependency on: > https://lists.denx.de/pipermail/u-boot/2019-September/384906.html > > Ang, Chee Hong (1): > configs: socfpga: Add defconfig for Agilex and Stratix 10 with ATF > support > > Chee Hong Ang (16): > configs: agilex: Remove CONFIG_OF_EMBED > arm: socfpga: add fit source file for pack itb with ATF > arm: socfpga: Add function for checking description from FIT image > arm: socfpga: Load FIT image with ATF support > arm: socfpga: Override 'lowlevel_init' to support ATF > arm: socfpga: Disable "spin-table" method for booting Linux > arm: socfpga: Add SMC helper function for Intel SOCFPGA (64bits) > arm: socfpga: Define SMC function identifiers for PSCI SiP services > arm: socfpga: soc64: Remove PHY interface setup from misc arch init > mmc: dwmmc: socfpga: Add ATF support for MMC driver > net: designware: socfpga: Add ATF support for MAC driver > arm: socfpga: Add ATF support for Reset Manager driver > arm: socfpga: stratix10: Initialize timer in SPL > arm: socfpga: Add ATF support to query FPGA configuration status > arm: socfpga: stratix10: Add ATF support for FPGA reconfig driver > arm: socfpga: mailbox: Add 'SYSTEM_RESET' PSCI support to > mbox_reset_cold() > > arch/arm/mach-socfpga/Kconfig | 2 - > arch/arm/mach-socfpga/Makefile | 2 + > arch/arm/mach-socfpga/board.c | 10 + > arch/arm/mach-socfpga/include/mach/misc.h | 3 + > arch/arm/mach-socfpga/lowlevel_init_64.S | 81 ++++ > arch/arm/mach-socfpga/mailbox_s10.c | 4 + > arch/arm/mach-socfpga/misc_s10.c | 121 ++---- > arch/arm/mach-socfpga/reset_manager_s10.c | 10 + > arch/arm/mach-socfpga/timer_s10.c | 3 +- > board/altera/soc64/its/fit_spl_atf.its | 52 +++ > ...ilex_defconfig => socfpga_agilex_atf_defconfig} | 8 +- > configs/socfpga_agilex_defconfig | 1 - > ...x_defconfig => socfpga_stratix10_atf_defconfig} | 23 +- > drivers/fpga/stratix10.c | 141 ++++++- > drivers/mmc/socfpga_dw_mmc.c | 21 + > drivers/net/dwmac_socfpga.c | 43 +- > include/configs/socfpga_soc64_common.h | 4 + > include/linux/intel-smc.h | 445 +++++++++++++++++++++ > 18 files changed, 871 insertions(+), 103 deletions(-) create mode 100644 > arch/arm/mach-socfpga/lowlevel_init_64.S > create mode 100644 board/altera/soc64/its/fit_spl_atf.its > copy configs/{socfpga_agilex_defconfig => socfpga_agilex_atf_defconfig} > (87%) copy configs/{socfpga_agilex_defconfig => > socfpga_stratix10_atf_defconfig} (68%) create mode 100644 > include/linux/intel-smc.h > > -- > 2.7.4
Hi Marek/Simon, Can you please help review and comment on this patchsets ? > Any comment on this v5 patchsets ? > > > From: "Ang, Chee Hong" <chee.hong.ang@intel.com> > > > > v5 changes: > > This is another revision without the System Manager driver to handle > > the secure/non-secure access. DW MAC and MMC drivers will make direct > > calls to the high-level API to ATF if it's running in EL2 on > > Stratix10/Agilex otherwise these drivers work as it is. > > > > [PATCH v5 08/17] arm: socfpga: Define SMC function identifiers for > > PSCI SiP services > > - Add documentation for high-level API supported by ATF: > > - INTEL_SIP_SMC_FUNCID_HPS_SET_PHYINTF (For setting PHY interface) > > - INTEL_SIP_SMC_FUNCID_HPS_SET_SDMMC_CCLK (For setting SDMMC > clock > > phase) > > > > [PATCH v5 10/17] mmc: dwmmc: socfpga: Add ATF support for MMC driver > > - Call 'INTEL_SIP_SMC_FUNCID_HPS_SET_SDMMC_CCLK' if U-Boot running in > > EL2 (non-secure) > > > > [PATCH v5 11/17] net: designware: socfpga: Add ATF support for MAC > > driver > > - Call 'INTEL_SIP_SMC_FUNCID_HPS_SET_PHYINTF' if U-Boot running in EL2 > > (non-secure) > > > > [PATCH v5 17/17] configs: socfpga: Add defconfig for Agilex and > > Stratix 10 with ATF support > > - Keep the existing Stratix10/Agilex defconfigs and add new defconfigs > > with ATF support > > > > v4: > > https://lists.denx.de/pipermail/u-boot/2020-March/402289.html > > > > These patchsets have dependency on: > > https://lists.denx.de/pipermail/u-boot/2019-September/384906.html > > > > Ang, Chee Hong (1): > > configs: socfpga: Add defconfig for Agilex and Stratix 10 with ATF > > support > > > > Chee Hong Ang (16): > > configs: agilex: Remove CONFIG_OF_EMBED > > arm: socfpga: add fit source file for pack itb with ATF > > arm: socfpga: Add function for checking description from FIT image > > arm: socfpga: Load FIT image with ATF support > > arm: socfpga: Override 'lowlevel_init' to support ATF > > arm: socfpga: Disable "spin-table" method for booting Linux > > arm: socfpga: Add SMC helper function for Intel SOCFPGA (64bits) > > arm: socfpga: Define SMC function identifiers for PSCI SiP services > > arm: socfpga: soc64: Remove PHY interface setup from misc arch init > > mmc: dwmmc: socfpga: Add ATF support for MMC driver > > net: designware: socfpga: Add ATF support for MAC driver > > arm: socfpga: Add ATF support for Reset Manager driver > > arm: socfpga: stratix10: Initialize timer in SPL > > arm: socfpga: Add ATF support to query FPGA configuration status > > arm: socfpga: stratix10: Add ATF support for FPGA reconfig driver > > arm: socfpga: mailbox: Add 'SYSTEM_RESET' PSCI support to > > mbox_reset_cold() > > > > arch/arm/mach-socfpga/Kconfig | 2 - > > arch/arm/mach-socfpga/Makefile | 2 + > > arch/arm/mach-socfpga/board.c | 10 + > > arch/arm/mach-socfpga/include/mach/misc.h | 3 + > > arch/arm/mach-socfpga/lowlevel_init_64.S | 81 ++++ > > arch/arm/mach-socfpga/mailbox_s10.c | 4 + > > arch/arm/mach-socfpga/misc_s10.c | 121 ++---- > > arch/arm/mach-socfpga/reset_manager_s10.c | 10 + > > arch/arm/mach-socfpga/timer_s10.c | 3 +- > > board/altera/soc64/its/fit_spl_atf.its | 52 +++ > > ...ilex_defconfig => socfpga_agilex_atf_defconfig} | 8 +- > > configs/socfpga_agilex_defconfig | 1 - > > ...x_defconfig => socfpga_stratix10_atf_defconfig} | 23 +- > > drivers/fpga/stratix10.c | 141 ++++++- > > drivers/mmc/socfpga_dw_mmc.c | 21 + > > drivers/net/dwmac_socfpga.c | 43 +- > > include/configs/socfpga_soc64_common.h | 4 + > > include/linux/intel-smc.h | 445 +++++++++++++++++++++ > > 18 files changed, 871 insertions(+), 103 deletions(-) create mode > > 100644 arch/arm/mach-socfpga/lowlevel_init_64.S > > create mode 100644 board/altera/soc64/its/fit_spl_atf.its > > copy configs/{socfpga_agilex_defconfig => > > socfpga_agilex_atf_defconfig} > > (87%) copy configs/{socfpga_agilex_defconfig => > > socfpga_stratix10_atf_defconfig} (68%) create mode 100644 > > include/linux/intel-smc.h > > > > -- > > 2.7.4
From: "Ang, Chee Hong" <chee.hong.ang@intel.com> v5 changes: This is another revision without the System Manager driver to handle the secure/non-secure access. DW MAC and MMC drivers will make direct calls to the high-level API to ATF if it's running in EL2 on Stratix10/Agilex otherwise these drivers work as it is. [PATCH v5 08/17] arm: socfpga: Define SMC function identifiers for PSCI SiP services - Add documentation for high-level API supported by ATF: - INTEL_SIP_SMC_FUNCID_HPS_SET_PHYINTF (For setting PHY interface) - INTEL_SIP_SMC_FUNCID_HPS_SET_SDMMC_CCLK (For setting SDMMC clock phase) [PATCH v5 10/17] mmc: dwmmc: socfpga: Add ATF support for MMC driver - Call 'INTEL_SIP_SMC_FUNCID_HPS_SET_SDMMC_CCLK' if U-Boot running in EL2 (non-secure) [PATCH v5 11/17] net: designware: socfpga: Add ATF support for MAC driver - Call 'INTEL_SIP_SMC_FUNCID_HPS_SET_PHYINTF' if U-Boot running in EL2 (non-secure) [PATCH v5 17/17] configs: socfpga: Add defconfig for Agilex and Stratix 10 with ATF support - Keep the existing Stratix10/Agilex defconfigs and add new defconfigs with ATF support v4: https://lists.denx.de/pipermail/u-boot/2020-March/402289.html These patchsets have dependency on: https://lists.denx.de/pipermail/u-boot/2019-September/384906.html Ang, Chee Hong (1): configs: socfpga: Add defconfig for Agilex and Stratix 10 with ATF support Chee Hong Ang (16): configs: agilex: Remove CONFIG_OF_EMBED arm: socfpga: add fit source file for pack itb with ATF arm: socfpga: Add function for checking description from FIT image arm: socfpga: Load FIT image with ATF support arm: socfpga: Override 'lowlevel_init' to support ATF arm: socfpga: Disable "spin-table" method for booting Linux arm: socfpga: Add SMC helper function for Intel SOCFPGA (64bits) arm: socfpga: Define SMC function identifiers for PSCI SiP services arm: socfpga: soc64: Remove PHY interface setup from misc arch init mmc: dwmmc: socfpga: Add ATF support for MMC driver net: designware: socfpga: Add ATF support for MAC driver arm: socfpga: Add ATF support for Reset Manager driver arm: socfpga: stratix10: Initialize timer in SPL arm: socfpga: Add ATF support to query FPGA configuration status arm: socfpga: stratix10: Add ATF support for FPGA reconfig driver arm: socfpga: mailbox: Add 'SYSTEM_RESET' PSCI support to mbox_reset_cold() arch/arm/mach-socfpga/Kconfig | 2 - arch/arm/mach-socfpga/Makefile | 2 + arch/arm/mach-socfpga/board.c | 10 + arch/arm/mach-socfpga/include/mach/misc.h | 3 + arch/arm/mach-socfpga/lowlevel_init_64.S | 81 ++++ arch/arm/mach-socfpga/mailbox_s10.c | 4 + arch/arm/mach-socfpga/misc_s10.c | 121 ++---- arch/arm/mach-socfpga/reset_manager_s10.c | 10 + arch/arm/mach-socfpga/timer_s10.c | 3 +- board/altera/soc64/its/fit_spl_atf.its | 52 +++ ...ilex_defconfig => socfpga_agilex_atf_defconfig} | 8 +- configs/socfpga_agilex_defconfig | 1 - ...x_defconfig => socfpga_stratix10_atf_defconfig} | 23 +- drivers/fpga/stratix10.c | 141 ++++++- drivers/mmc/socfpga_dw_mmc.c | 21 + drivers/net/dwmac_socfpga.c | 43 +- include/configs/socfpga_soc64_common.h | 4 + include/linux/intel-smc.h | 445 +++++++++++++++++++++ 18 files changed, 871 insertions(+), 103 deletions(-) create mode 100644 arch/arm/mach-socfpga/lowlevel_init_64.S create mode 100644 board/altera/soc64/its/fit_spl_atf.its copy configs/{socfpga_agilex_defconfig => socfpga_agilex_atf_defconfig} (87%) copy configs/{socfpga_agilex_defconfig => socfpga_stratix10_atf_defconfig} (68%) create mode 100644 include/linux/intel-smc.h