From patchwork Sat Jan 21 20:38:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Bottomley X-Patchwork-Id: 718099 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v5TvP1Q3bz9sxN for ; Sun, 22 Jan 2017 07:39:13 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1cV2RG-0006B2-QR; Sat, 21 Jan 2017 20:39:06 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1cV2RF-0006Ax-Qx for tpmdd-devel@lists.sourceforge.net; Sat, 21 Jan 2017 20:39:05 +0000 Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of HansenPartnership.com designates 66.63.167.143 as permitted sender) client-ip=66.63.167.143; envelope-from=James.Bottomley@HansenPartnership.com; helo=bedivere.hansenpartnership.com; Received: from bedivere.hansenpartnership.com ([66.63.167.143]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1cV2RE-0007iE-M2 for tpmdd-devel@lists.sourceforge.net; Sat, 21 Jan 2017 20:39:05 +0000 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 83CB38EE0DC; Sat, 21 Jan 2017 12:38:58 -0800 (PST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CTnSSglZswWp; Sat, 21 Jan 2017 12:38:58 -0800 (PST) Received: from [153.66.254.194] (unknown [50.46.144.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id C93C68EE0CF; Sat, 21 Jan 2017 12:38:57 -0800 (PST) Message-ID: <1485031136.26703.16.camel@HansenPartnership.com> From: James Bottomley To: Jarkko Sakkinen Date: Sat, 21 Jan 2017 12:38:56 -0800 In-Reply-To: <20170120210522.glx4y4oui36oimld@intel.com> References: <20170116131215.28930-1-jarkko.sakkinen@linux.intel.com> <20170116131215.28930-6-jarkko.sakkinen@linux.intel.com> <1484751663.2717.10.camel@HansenPartnership.com> <20170119104922.vhgz4rxw6yzdrxqt@intel.com> <1484828380.3140.11.camel@HansenPartnership.com> <20170120133914.2wk43nteh2hh7n3c@intel.com> <20170120210522.glx4y4oui36oimld@intel.com> X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 X-Spam-Score: -4.8 (----) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record -3.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1cV2RE-0007iE-M2 Cc: linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, open list Subject: Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms X-BeenThere: tpmdd-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Tpm Device Driver maintainance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces@lists.sourceforge.net On Fri, 2017-01-20 at 23:05 +0200, Jarkko Sakkinen wrote: > On Fri, Jan 20, 2017 at 03:39:14PM +0200, Jarkko Sakkinen wrote: > > On Thu, Jan 19, 2017 at 07:19:40AM -0500, James Bottomley wrote: > > > On Thu, 2017-01-19 at 12:49 +0200, Jarkko Sakkinen wrote: > > > > On Wed, Jan 18, 2017 at 10:01:03AM -0500, James Bottomley > > > > wrote: > > > > > On Mon, 2017-01-16 at 15:12 +0200, Jarkko Sakkinen wrote: > > > > > > From: James Bottomley < > > > > > > James.Bottomley@HansenPartnership.com> > > > > > > > > > > > > Currently the Resource Manager (RM) is not exposed to > > > > > > userspace. > > > > > > Make this exposure via a separate device, which can now be > > > > > > opened multiple times because each read/write transaction > > > > > > goes > > > > > > separately via the RM. > > > > > > > > > > > > Concurrency is protected by the chip->tpm_mutex for each > > > > > > read/write transaction separately. The TPM is cleared of > > > > > > all > > > > > > transient objects by the time the mutex is dropped, so > > > > > > there > > > > > > should be no interference between the kernel and userspace. > > > > > > > > > > There's actually a missing kfree of context_buf on the > > > > > tpms_release > > > > > path as well. This patch fixes it up. > > > > > > > > Can you send me a fresh version of the whole patch so that I > > > > can > > > > include to v4 that includes also changes that I requested in my > > > > recent comments + all the fixes? > > > > > > Sure, I think the attached is basically it > > > > > > James > > > > Thank you! > > 'tabrm4' branch has been now rebased. It's now on top of master > branch that contains Stefan's latest patch (min body length check) > that I've reviewed and tested. It also contains your updated > /dev/tpms patch. > > I guess the 5 commits that are there now are such that we have fairly > good consensus, don't we? If so, can I add your reviewed-by and > tested-by to my commits and vice versa? It looks like there's another problem: you need a continue after the transient object is garbage collected otherwise the code falls through, does a flush which fails and then adds a ~0 as the handle meaning we'll have a mismatch between the saved contexts and the handles. James --- commit 0da3f83ce889379bd1741a11b07a30818a223924 Author: James Bottomley Date: Sat Jan 21 12:19:06 2017 -0800 continue after lazy reclaim ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm/tpm2-space.c index 8713d7f..9d87537 100644 --- a/drivers/char/tpm/tpm2-space.c +++ b/drivers/char/tpm/tpm2-space.c @@ -288,9 +288,10 @@ static int tpm2_save_space(struct tpm_chip *chip) rc = tpm2_save_context(chip, space->context_tbl[i], space->context_buf, PAGE_SIZE, &offset); - if (rc == -ENOENT) + if (rc == -ENOENT) { space->context_tbl[i] = 0; - else if (rc) { + continue; + } else if (rc) { tpm2_flush_space(chip); return rc; }