diff mbox series

[1/1] process: fix include

Message ID VI1P190MB0493A1E34DC101CFDD5DFBB59FB29@VI1P190MB0493.EURP190.PROD.OUTLOOK.COM
State Rejected
Delegated to: Stefano Babic
Headers show
Series [1/1] process: fix include | expand

Commit Message

Lang Daniel March 2, 2023, 7:48 a.m. UTC 
The header might be installed to a subdirectory of /usr/include (like
with buildroot which sets /usr/include/swupdate). swupdate_status.h will
not be found in this case.

Signed-off-by: Daniel Lang <d.lang@abatec.at>
---
 include/progress_ipc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic March 2, 2023, 5:25 p.m. UTC | #1 
On 02.03.23 08:48, 'Lang Daniel' via swupdate wrote:
> The header might be installed to a subdirectory of /usr/include (like
> with buildroot which sets /usr/include/swupdate). swupdate_status.h will
> not be found in this case.

The question is why it should be fixed here. This depends where the 
files are installed, and a often we see, there is no general solution. 
In other distros (OE and Debian), files are put into /usr/include. 
Anyway, you need this if you are using the libswupdate library into the 
SDK. If Buildroot has moved the include in own directory, isn't the 
issue solved by passing the right CFLAGS (with -J and -J) when you build 
your application ?

Best regards,
Stefano Babic

> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> ---
>   include/progress_ipc.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/progress_ipc.h b/include/progress_ipc.h
> index 5d0be1c..30e5266 100644
> --- a/include/progress_ipc.h
> +++ b/include/progress_ipc.h
> @@ -9,7 +9,7 @@
>   #define _PROGRESS_IPC_H
>   
>   #include <stdbool.h>
> -#include <swupdate_status.h>
> +#include "swupdate_status.h"
>   
>   #ifdef __cplusplus
>   extern "C" {
diff mbox series

Patch

diff --git a/include/progress_ipc.h b/include/progress_ipc.h
index 5d0be1c..30e5266 100644
--- a/include/progress_ipc.h
+++ b/include/progress_ipc.h
@@ -9,7 +9,7 @@ 
 #define _PROGRESS_IPC_H
 
 #include <stdbool.h>
-#include <swupdate_status.h>
+#include "swupdate_status.h"
 
 #ifdef __cplusplus
 extern "C" {