| Message ID | 20250514201740.686772-1-james.hilliard1@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [v2,1/1] Update cmake_minimum_required to 3.5 | expand |
Hi Stefano,
James Hilliard wrote on Wed, May 14, 2025 at 02:17:40PM -0600:
> This supports compilation with cmake-4.0.0.
Just a heads up I was bitten by this on alpine 3.23 -- the patch has
been merged for a while, perhaps it'd be time to cut a new libubootenv
release with what we have in tree?
(easily worked around for now by just applying this patch, no hurry from
me now it's done, just pointing out others might start to hit this soon)
On 12/4/25 10:39, Dominique MARTINET wrote: > Hi Stefano, > > James Hilliard wrote on Wed, May 14, 2025 at 02:17:40PM -0600: >> This supports compilation with cmake-4.0.0. > > Just a heads up I was bitten by this on alpine 3.23 -- the patch has > been merged for a while, perhaps it'd be time to cut a new libubootenv > release with what we have in tree? > > (easily worked around for now by just applying this patch, no hurry from > me now it's done, just pointing out others might start to hit this soon) Yes, agree. I released yesterday SWUpdate, and I will go on to release libubootenv and SWUgenerator. Stefano >
diff --git a/CMakeLists.txt b/CMakeLists.txt index 796d7bc..0a11730 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2,7 +2,7 @@ # # SPDX-License-Identifier: LGPL-2.1-or-later -cmake_minimum_required (VERSION 2.6) +cmake_minimum_required (VERSION 3.5) project (libubootenv C) # The version number. diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index c56d0c7..3370232 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1,7 +1,7 @@ # SPDX-FileCopyrightText: 2019-2021 Stefano Babic <stefano.babic@swupdate.org> # # SPDX-License-Identifier: LGPL-2.1-or-later -cmake_minimum_required (VERSION 2.6) +cmake_minimum_required (VERSION 3.5) # Sources and private headers SET(libubootenv_SOURCES uboot_env.c
This supports compilation with cmake-4.0.0. Fixes: CMake Error at CMakeLists.txt:5 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake. Update the VERSION argument <min> value. Or, use the <min>...<max> syntax to tell CMake that the project requires at least <min> but has been updated to work with policies introduced by <max> or earlier. Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. Signed-off-by: James Hilliard <james.hilliard1@gmail.com> --- Changes v1 -> v2: - also fix src/CMakeLists.txt --- CMakeLists.txt | 2 +- src/CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)