From patchwork Wed Oct 4 08:07:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1843032 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=eLuq9Lnr; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::337; helo=mail-wm1-x337.google.com; envelope-from=swupdate+bncbaabbmv26suamgqevwd434a@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wm1-x337.google.com (mail-wm1-x337.google.com [IPv6:2a00:1450:4864:20::337]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S0nNT681Qz1ypx for ; Wed, 4 Oct 2023 19:07:20 +1100 (AEDT) Received: by mail-wm1-x337.google.com with SMTP id 5b1f17b1804b1-40554735995sf13440495e9.1 for ; Wed, 04 Oct 2023 01:07:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1696406835; cv=pass; d=google.com; s=arc-20160816; b=FW2pNMsfrccvr/xuGqd2Y25PX7kCkZXQX3wXWePPNza2HMw234kBi34ki81c+2T/VD XM3cV07e3Ld4s5jTFvSKOOcsrXqjyiGvrKVPyzTxvPhtRIvwMEwFq4El/qpw5W5YmMeo nCpyXs0SDi/ivqDk3UXzIxRTy0rOUvbUwrED+nVEiO95BXSMSdSFTmtnPFyFFan7GgyW zxcQ+NWXDbPnLOp+qcXYlFpS5F19N/kDDOUUvaau5Tm2OmcxAN8ig+uK7ylLaQI49Glv r2uBjOl6z68WJGUPeTwoCUY0mjDEs5781JevOy51IsTXtTEF/dLVaKva4UFYzXeFY5TF NkbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:ui-outboundreport:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=6APhB5ZCAdftYAym8OtmuKTQAZE/Y5LfAHBv9tddVRY=; fh=X/WkvetxkXJEVQvrihEZhmdVICj1I0yIsucwqpQJ2QU=; b=Fjww5IGo4KE6l6zrteRzklImJ6XzFIdbcA3pqYH6pp2hN0vlm9KtbgBXLStVxNj0yB cf6WYCUD8wj75q8vdSua/okWb2vcCRVwgrwCJzQzqJJWQVSstnhPm6a+CgZ10tRT9Fkl CEMiFEE5H9IWPcW6nPcHL+S/ZiXTpGKtJhpytGtCi9HDzINwUpknOuUVj9UQEdHRylc2 AAapCEHBviz3iz9auMGdx4wfmQ20WFJN6OizwmQwC1A8cuFgRXnptG/c/Yel5ImjKM+L aaI6rKIrLx7bzjBU1rvohc801DcEMEahW3/1e9kxXWEvQQXt6GSQO2sSSCw2v7hWoDDi E8hg== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.135 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1696406835; x=1697011635; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:ui-outboundreport:mime-version:message-id:date :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=6APhB5ZCAdftYAym8OtmuKTQAZE/Y5LfAHBv9tddVRY=; b=eLuq9LnrgZoO9Ewftqj8BPEdSAnfpVyMWsHCU7Pq0OmLk/YEa0TE15o/NuqRhaBn9Z bERWY+nWbLcFxmOpeaMhkUq51b2k9YQPRJL4AFwfJKjXfN3t158xQMN8OXqLna51+3iz 76Vsr5W3MUmrSiEYoeDETTvmdFdm9GkcHEfpKXF4O4RevqoSMcQ9X9UWssn56MgGOA5f I3tzHIJLEZicMWIS9x10HZihHnEfAsmTXKbQR7rK437uvgvu08jlR0YVJE5A5z17eUm5 jWkbGk44YFGL4n8BoXguE7kRAf1G+LvxRfazNzFXMUClysJDtSjlvXhZlyFGRCpnF03+ UcDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696406835; x=1697011635; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :ui-outboundreport:mime-version:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=6APhB5ZCAdftYAym8OtmuKTQAZE/Y5LfAHBv9tddVRY=; b=eBss9L6zyaLdkheU/re9ayoU/IalsYNDwrTpOm7neFQe4L+vDQDTOzWz9b0l86/QTb ojfCQ30jaYll+7rAzB7IQVFqsM5d5OeqIMle2DsVlM3V8kmsW8S1ZmI1ui3F2fzoImOf N0XP/dqgiXx1v7XT1llzzt+t5hvPpZEsolliuj9VQCVeL4UZQrcHaTNNM+mslDWHo8jS lbZhTMIuUYtbz8jjTCmZeoHgutWbhTXoQBCGEEz6zj5htOg7ugStRHonACA1EJ1cBE6R MynGwwQahGObbxoVLnCKv/C9o2f0S4gAnw0cjoRLdvdah1cmvt7xe59Q8a14kIvNJDbe Z8YQ== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOJu0YzMaLtVciOJWb4lvX2LOJtH/V7k5837nFaseKx62fM5kq2sg/3z wIe1JRn0Epe2MSlxsjNuVBw= X-Google-Smtp-Source: AGHT+IHAuijGowmLy7Y2mPMQeWww6imegfxMdSSkVGYjAP1BBPpwvXI5U8wKRKHApstQ3qtEPP1wcA== X-Received: by 2002:a7b:c854:0:b0:401:b53e:6c3b with SMTP id c20-20020a7bc854000000b00401b53e6c3bmr1524483wml.6.1696406834868; Wed, 04 Oct 2023 01:07:14 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:600c:1c04:b0:404:75cc:62de with SMTP id j4-20020a05600c1c0400b0040475cc62dels1020627wms.0.-pod-prod-03-eu; Wed, 04 Oct 2023 01:07:13 -0700 (PDT) X-Received: by 2002:a05:600c:220b:b0:406:4242:e7df with SMTP id z11-20020a05600c220b00b004064242e7dfmr1581180wml.35.1696406833101; Wed, 04 Oct 2023 01:07:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696406833; cv=none; d=google.com; s=arc-20160816; b=GAP5jW3gg+uVTAHSt3/ajoC9Z7ZJYHOgiI1oZ8o6dTZp11+xQqvJXOknWwMzJOycG0 /1Bm3Cp8Evd4qLML0veHJrOA5NEfCUTHH9M/v0D5lOXjWReIeyCl3qaHPXZtkHOOwmG+ qRRinhD1aW9/HcyDx1qk0cdnV7/cFC9seubQm/OvYcXeCYMGOw0cLZFUJjJOjcEWXx+V eclxkig0jfggjBI5mBXvjSZOqJeajsZwLWahPuV3vILLVnxUrOBHN2QalXziTOEynzH7 OexGdvvdu9wXwnXy3R6Ipg3JxIPgUYYjmGA5hFLG97yUtx92nI87fTuqrIU7Kxii6mx+ wZ7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version:message-id :date:subject:cc:to:from; bh=/C4ff7TdMOJzU+U3NuFAhNAc6d/XOvhoLATFI7xBegs=; fh=X/WkvetxkXJEVQvrihEZhmdVICj1I0yIsucwqpQJ2QU=; b=bXehtakS948rsFWFD9b0D5nA5/SuoW9v8wbv5Fy6KBldVq6P1prYBxoePrerGrPpB1 3WGYkvubpl0Bkz0EXOxSVJoqZoMHA6U5GlqFSzNCn1sb/VBIuVqoQy8VM+EhZNNNbjQf v4xKzFP/OZH1xxFHLRKINSUIrJ+g0mrCwp0Y+89a52vLlubNbmYZu9kulm/0dUVTaLDQ WD0BQY2B6ySBJSlBMTAKZb1ZFkpmJ6f6IMbIwy/4M45W5fhCIHWkSR7PkZrFkI22Gd7V Xm2Uy9IUqxgG1oAhxlS/ZZYNrj1sh9E458OqWiNHO1HiRSR1SjHMoVIk7/SPp7BtXYeG Oyjg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.135 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.126.135]) by gmr-mx.google.com with ESMTPS id p24-20020a05600c1d9800b00406621198easi240855wms.0.2023.10.04.01.07.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 01:07:13 -0700 (PDT) Received-SPF: pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.135 as permitted sender) client-ip=212.227.126.135; Received: from paperino.fritz.box ([88.217.136.221]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MYvse-1rA29g2jz6-00UsXy; Wed, 04 Oct 2023 10:07:12 +0200 From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic , Lukas Funke Subject: [swupdate] [PATCH] Raw Handler: fix umount path after commit ff1fa4f Date: Wed, 4 Oct 2023 10:07:05 +0200 Message-Id: <20231004080705.16551-1-stefano.babic@swupdate.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:7FtL8vYCLz7/Fi5plz0/FzJ2+wNGKIziwfktoBS8GXOS0SzrjFR XZUYjHbN+0mF5NvvClXUP0W2cP7k1yWydr1rKqdqoNHV6cE+R76NAFuoU6H2zyz5Qrk4Cac AUXMGgYtDmdZjnBlJTzswIwOUPokZSn8AGQGj7oLZTKqDtg5Tjfotj9fom2SCtzbr4vPteP 30o+eSxfcqcnOJnERLYOQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:TAmA3kF7uOM=;/P1/0GapZ6PAN7x0es1GTz6vZCU zDeYxEqd8zVnO8e+qp44ldklqzzlX0q0knWarHmDFP/26rqWM026+PWpF1oSHo6zB381cAaR1 8EpdVsEoV500acpFvpQkmrariEs55fnnoqsTPpeHBQBBp/qGVZxXYxwHsi8d6ZsGipUrw8UU9 PSZ3cSH+iYkWU9NjaiW+0uZF/61DtKxWuMLf2Xka1nU9c0D4+3AK/QDEWEwOyv9Y5YlqCg8TH kxzaIHVXVq4HEJTZutU7feH6ZcKAl0IgYnFMQaBS4bV2WYvJ0x07ohkg9Q1psESk8KL0mjRnk cLX0wkwa6EP3FHj2XCrAdpSlAsBmRqbufOBMKcgfVg+l406rhFqJizfD3bm412k55Heu78iTu Minx7eJEt+NOveFWEXFMttBC08oGEOXWN/6uD3aYBtX+AXfqDfY1LnIfXXjXfz4NwlFYOX3Fo GWsSm4l4jswS6FTdABSxakHG1EJt0dK44WGuB9sDD4T1l+0g+JTnkyXNt1kXCNMAHc+Vq8nUa RVuDZQDT4yVD+aXbpm9AS6NFEAiA8LtnIYAXWnOhUv0N0mN4M1NX3eTsb+nocHRF8yjt/B+K9 6Uf/ZYZzYENuNxzk5BdtNfVizdz1JN8CgXOQ9ObQNU5LmlARDdhER3tZJAPU2ytCg18bZbTLO HsrO0BWForKj8kLudEAp+DhNmmYVdwSKADFZNvcTZpPdveP522QgMujpmCYuKKjS72cincTD7 NZB4hrOImnMkLtaO7RZC4RotlbL+MRmOZHZupRVTVZKFuOkK1etkIseasTubPhyZ2+T4VSUZS F5QyeA2otbzwek6kDgShZWSH5ZOXJv5wtFjXRr6oA75BjCugEyIeZf4Q6Br//G1PlyudJgZNp Eg/Hc+p++2in3vA== X-Original-Sender: stefano.babic@swupdate.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.135 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Commit reported above eavluates return value from mount, but forget to add paranthesys in the context. Signed-off-by: Stefano Babic CC: Lukas Funke --- handlers/raw_handler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/handlers/raw_handler.c b/handlers/raw_handler.c index cc0431e5..18195dfb 100644 --- a/handlers/raw_handler.c +++ b/handlers/raw_handler.c @@ -244,10 +244,11 @@ cleanup: if (fdout > 0) close(fdout); - if (use_mount) + if (use_mount) { ret = swupdate_umount(DATADST_DIR); if (ret) WARN("Can't unmount path %s: %s", DATADST_DIR, strerror(errno)); + } return ret; }