From patchwork Tue Sep 26 08:41:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Moessbauer X-Patchwork-Id: 1839516 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=HuVkmIfd; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::438; helo=mail-wr1-x438.google.com; envelope-from=swupdate+bncbcyiz4m3xakrb2nszkuamgqe74cjmay@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wr1-x438.google.com (mail-wr1-x438.google.com [IPv6:2a00:1450:4864:20::438]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvtXb34QFz1yp0 for ; Tue, 26 Sep 2023 18:42:21 +1000 (AEST) Received: by mail-wr1-x438.google.com with SMTP id ffacd0b85a97d-32329974dbdsf2884114f8f.0 for ; Tue, 26 Sep 2023 01:42:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1695717738; cv=pass; d=google.com; s=arc-20160816; b=mhABynfR5RmOuuMI+oObzkhGj7aERDqCEZGP5m3ZuO8RILzant+Diuq98Uuk3rOY2+ WAmoEmqFRTTNU3H2u5iXjK9HGvaVA39AT/Z97TVevne7nLcWaXJVSZeMjfrpnxWMItpW pFkyXu7VHLBMKPfnzHLpm6pSBJqXz0uuI6S+axn5XxgpbxUKRjB6/5zedEiAz83ZIAS8 xCK1oiIxDzT9EjsoPQVNv0361Zp067g7mh590qltLc719fMnP7wlJo1enPiqKjOG4VJ8 vK68ccSAMPKRZQ9UbifkoibvuE+fMjTmKShqCRCTfGytHpiVtJPEXLrrbiykZ1bGvug5 HHbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rboc+7cotLqMZYDJlgmNf1uX3ogffOcm0QWomReqq+U=; fh=8m9swjqHMa8Zs6Jtx1aOGfmf2EFoFLhXt7dY/094Q7k=; b=Monl+t0pd/VDyND+ds90Ef6E/9fk6i9SBwwHfcYaXtCPYSbE+BTm8zqEXw4UEnK3WS Yj5Clvn937BPy/gvbZSk4FqPc/lgpWmN2jMF6b/ef7uV4rp8VmpkF4SsdKvBqN8UyMRP ROSjN+qc1cvEaaK3GUEmlw9dZT77BMbUl0qa51gJj21lc7x0wnm4B6ZT1st8p13rVMul lS5e2CDiNDuOATRnTeYIwA5QePE28m3nHLzmZl9t6DrGqVNRTKC0dQo2faQ29cG++soB sjiS39SG/0QILVnxSoOn2iXV3/lEknZ3SKO6eaV6qxOXHA+Mf5zBwq5ppqmEKYgF2h2x oXwA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=UvEu4KRo; spf=pass (google.com: domain of fm-72506-20230926084215e2c01930de8ca56ff3-rtgati@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-72506-20230926084215e2c01930de8ca56ff3-rTGATi@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1695717738; x=1696322538; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=rboc+7cotLqMZYDJlgmNf1uX3ogffOcm0QWomReqq+U=; b=HuVkmIfd3lwi+EkFEuBehMmzeQAXTP7bw0g+RuYaWnfmHWY963NJ2r0UViM/DpBkD9 7+4kdVBG1tmFIMeyIDGwABdehSttrDG5Y9K6RB4EFagDvxgW6D3gQQExhDQcpwP9Uzgw hxifNhXpVu85ugfhP6wnluu2/SLhzRk6QRe9kMwP+PpCKIXrcgBYXXSWeOasqIpQGr44 vv1TGHt9BUuVRuo2ugbU8qu7IY84Y2ms25X9zBYQUZTJjNOQ001dD0p7riO155HJCLC0 QkpoNTfdq45fzZ06GWIcQoMYwxrtB/eNPQyIGHtLLLZ2h55OKwjrTx8IRJAtg4y1Zz2b BHbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695717738; x=1696322538; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rboc+7cotLqMZYDJlgmNf1uX3ogffOcm0QWomReqq+U=; b=JtVZKmvdoM/IlpKD4YhWVXI2LNf8IAfmTbQhAEVfJgleUyV8nlTottiC6oT6uKuJ5O 4rTZ9nWzsUxy/+8BVTS0sVeo8dbtd/P99I2LhgNajTNaoL2Mn3bK4vy45HgHklpVYq6N P1dv64vIrYiBsPmVIjY9u4wjrDVFuiDwaHtNHpB9D5hdEiv6eCaM85Jt5aCdXKvWGrYp YSApY4ZwL3OPpHtAHwvp4SXlRVytqmaA8xjZz1VV2VgwNZJSxr3eTcmdecnS6Sx9wRKl cFsAs1BsK1wQKt2ek0SzN5wO68ZsjJ+qO6duA8D0ZI4NrwbDOqCRk9txsCWs93FcCIyK 57dw== X-Gm-Message-State: AOJu0YwwnuH4nu/edjbQo5rwzPOQQQISxBxoJFlsOCRQ4Awv55Ijlf2O cicGVD0/gz6LxV8R5ghUzlI= X-Google-Smtp-Source: AGHT+IG8xh+3/bHorZm3Dyi1LaVG6YCiEFuEo4kjLhMHJNQ9R1Pln0+QV/8x5mK9cD9rANw4f7W5hQ== X-Received: by 2002:adf:ec42:0:b0:31f:fb63:12d8 with SMTP id w2-20020adfec42000000b0031ffb6312d8mr7453040wrn.44.1695717737693; Tue, 26 Sep 2023 01:42:17 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a5d:6a43:0:b0:317:79ec:7a0 with SMTP id t3-20020a5d6a43000000b0031779ec07a0ls730903wrw.1.-pod-prod-04-eu; Tue, 26 Sep 2023 01:42:15 -0700 (PDT) X-Received: by 2002:a05:6000:1c7:b0:31f:bdfd:5d30 with SMTP id t7-20020a05600001c700b0031fbdfd5d30mr9599340wrx.57.1695717735604; Tue, 26 Sep 2023 01:42:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695717735; cv=none; d=google.com; s=arc-20160816; b=JXzvNCnnSiYOFaBvG1G/t+jLahwHBMA6t2yJ0z17OELjn86/ELDkQDLFaH/Z4+cyXc NHrVjwSZSJ/rlwCIZWh8Zdch+Uk+CC0O9r2CD9f1F0QA+TfyWUk3OAn2bHEr+znVKrd9 vJyOiCGFgrPrO5bSz1kFkiVgjIJ5ADtfpraZ82DXtjzkPGC8rQk0PdtcqXYnxTpLTjBN FGikS3LwKGbha14EnIKxBf0H+NPJgLihhAEOtBUZyC3lxV0c6nuwHkuqx1aKJbqFF1cu G0Gd65LDGeMMedIbUwuQ27xXeF2v1x2TLHNWRQFdKUOGDkULHFEPB6nRkopI3OzgkUpM tw7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=NjWJnEdT5xJALG9aGU8C87YGCDJtzoP3g5WTckjzS1w=; fh=8m9swjqHMa8Zs6Jtx1aOGfmf2EFoFLhXt7dY/094Q7k=; b=fYK2k7kGHVsy4+EjSFrjHNSWdBnqwadr9i4P35DUzx7X8rRM4ipnslItV2FtdgJMRh 5s7VZhEH+xwEbi0+iyaRLQ9p1oBn4XHyAmDfm2RXFdFu/lXMJPTOG3WAl0czTAp6i9uB 5c0KbDwD73qteoSTCVZmIpaNEaTXJXYICwnAwChiNRl6+eYtg+r9wmTUwbJOn8SKuCvy WXUy12HNI/nIvSzvYXcbKt0WiyXNJG4T3DRErLUJZ6L8b9AnzJwjiIE5m8qiuBjHjyss o86IA2ovws+Iw69O7fOenfERaA3mzdmJRo0B8r4dumqgV8gM5fIm/aZaUAHBExdRtHS5 gYfg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=UvEu4KRo; spf=pass (google.com: domain of fm-72506-20230926084215e2c01930de8ca56ff3-rtgati@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-72506-20230926084215e2c01930de8ca56ff3-rTGATi@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-228.siemens.flowmailer.net (mta-64-228.siemens.flowmailer.net. [185.136.64.228]) by gmr-mx.google.com with ESMTPS id e3-20020adffc43000000b0031ac9fda4c5si748551wrs.8.2023.09.26.01.42.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Sep 2023 01:42:15 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-20230926084215e2c01930de8ca56ff3-rtgati@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) client-ip=185.136.64.228; Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 20230926084215e2c01930de8ca56ff3 for ; Tue, 26 Sep 2023 10:42:15 +0200 X-Patchwork-Original-From: "'Felix Moessbauer' via swupdate" From: Felix Moessbauer To: swupdate@googlegroups.com Cc: bage@debian.org, quirin.gylstorff@siemens.com, christian.storm@siemens.com, Felix Moessbauer Subject: [swupdate] [PATCH 1/2] core: fail if running under systemd but not sockets Date: Tue, 26 Sep 2023 16:41:50 +0800 Message-Id: <20230926084151.966511-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-Original-Sender: felix.moessbauer@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=UvEu4KRo; spf=pass (google.com: domain of fm-72506-20230926084215e2c01930de8ca56ff3-rtgati@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-72506-20230926084215e2c01930de8ca56ff3-rTGATi@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Felix Moessbauer Reply-To: Felix Moessbauer Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , When running with CONFIG_SYSTEMD on a systemd bootet system, fail in case no sockets were created by systemd. This solves the following issues: - improper cleanup of sockets: previously the self-created sockets were not properly removed in this case - fail fast instead of silently: Duplicated sockets were created in different paths. Signed-off-by: Felix Moessbauer --- core/network_thread.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/network_thread.c b/core/network_thread.c index a5b6901..bd973ab 100644 --- a/core/network_thread.c +++ b/core/network_thread.c @@ -235,7 +235,8 @@ int listener_create(const char *path, int type) } } if (listenfd == -1) { - TRACE("got no socket at %s from systemd", path); + ERROR("got no socket at %s from systemd", path); + return -1; } else { TRACE("got socket fd=%d at %s from systemd", listenfd, path); }