diff mbox series

raw_handler: evaluate return value of unmount

Message ID 20230920080506.1854468-1-lukas.funke-oss@weidmueller.com
State Accepted
Delegated to: Stefano Babic
Headers show
Series raw_handler: evaluate return value of unmount | expand

Commit Message

Lukas Funke Sept. 20, 2023, 8:05 a.m. UTC 
From: Lukas Funke <lukas.funke@weidmueller.com>

If unmount fails for whatever reason, this should
be reported.

Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
---
 handlers/raw_handler.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Stefano Babic Sept. 20, 2023, 8:34 a.m. UTC | #1 
On 20.09.23 10:05, lukas.funke-oss@weidmueller.com wrote:
> From: Lukas Funke <lukas.funke@weidmueller.com>
> 
> If unmount fails for whatever reason, this should
> be reported.
> 
> Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
> ---
>   handlers/raw_handler.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/handlers/raw_handler.c b/handlers/raw_handler.c
> index 87445e8..cc0431e 100644
> --- a/handlers/raw_handler.c
> +++ b/handlers/raw_handler.c
> @@ -245,7 +245,9 @@ cleanup:
>   		close(fdout);
>   
>   	if (use_mount)
> -		swupdate_umount(DATADST_DIR);
> +		ret = swupdate_umount(DATADST_DIR);
> +		if (ret)
> +			WARN("Can't unmount path %s: %s", DATADST_DIR, strerror(errno));
>   
>   	return ret;
>   }

Reviewed-by: Stefano Babic <stefano.babic@swupdate.org>
diff mbox series

Patch

diff --git a/handlers/raw_handler.c b/handlers/raw_handler.c
index 87445e8..cc0431e 100644
--- a/handlers/raw_handler.c
+++ b/handlers/raw_handler.c
@@ -245,7 +245,9 @@  cleanup:
 		close(fdout);
 
 	if (use_mount)
-		swupdate_umount(DATADST_DIR);
+		ret = swupdate_umount(DATADST_DIR);
+		if (ret)
+			WARN("Can't unmount path %s: %s", DATADST_DIR, strerror(errno));
 
 	return ret;
 }