diff mbox series

[1/2] fix(Makefile): correct argument count for trylink invocation

Message ID 20230728091906.660334-1-michael.adler@siemens.com
State Accepted
Delegated to: Stefano Babic
Headers show
Series [1/2] fix(Makefile): correct argument count for trylink invocation | expand

Commit Message

Michael Adler July 28, 2023, 9:19 a.m. UTC 
The trylink function expects to receive 7 arguments, with LDLIBS as the
last one. Previously, the Makefile was erroneously passing 8 arguments,
which included an empty string followed by LDLIBS. This commit rectifies
this off-by-one error by eliminating the unnecessary empty string,
ensuring that LDLIBS is accurately passed as the seventh argument.

Signed-off-by: Michael Adler <michael.adler@siemens.com>
Signed-off-by: Christian Storm <christian.storm@siemens.com>
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Stefano Babic Aug. 2, 2023, 3:22 p.m. UTC | #1 
On 28.07.23 11:19, 'Michael Adler' via swupdate wrote:
> The trylink function expects to receive 7 arguments, with LDLIBS as the
> last one. Previously, the Makefile was erroneously passing 8 arguments,
> which included an empty string followed by LDLIBS. This commit rectifies
> this off-by-one error by eliminating the unnecessary empty string,
> ensuring that LDLIBS is accurately passed as the seventh argument.
> 
> Signed-off-by: Michael Adler <michael.adler@siemens.com>
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
>   Makefile | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 09d03a3..c693635 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -438,7 +438,6 @@ quiet_cmd_shared = LD      $@
>         "$(KBUILD_CFLAGS) $(CFLAGS_swupdate)" \
>         "$(LDFLAGS) $(EXTRA_LDFLAGS) $(LDFLAGS_swupdate) -L$(objtree)" \
>         "$(2)" \
> -	  "" \
>   	  "$(LDLIBS)"
>   
>   lua_swupdate.so.0.1: $(bindings-libs) ${swupdate-ipc-lib}

Applied to -master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 09d03a3..c693635 100644
--- a/Makefile
+++ b/Makefile
@@ -438,7 +438,6 @@  quiet_cmd_shared = LD      $@
       "$(KBUILD_CFLAGS) $(CFLAGS_swupdate)" \
       "$(LDFLAGS) $(EXTRA_LDFLAGS) $(LDFLAGS_swupdate) -L$(objtree)" \
       "$(2)" \
-	  "" \
 	  "$(LDLIBS)"
 
 lua_swupdate.so.0.1: $(bindings-libs) ${swupdate-ipc-lib}