Message ID | 20230526114253.399337-1-sbabic@denx.de |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBCXPLOXJ6IKRBRFWYKRQMGQEAI4ENLA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::53c; helo=mail-ed1-x53c.google.com; envelope-from=swupdate+bncbcxploxj6ikrbrfwykrqmgqeai4enla@googlegroups.com; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20221208 header.b=QX4FrnzF; dkim-atps=neutral Received: from mail-ed1-x53c.google.com (mail-ed1-x53c.google.com [IPv6:2a00:1450:4864:20::53c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QSNMw4x4zz20Pb for <incoming@patchwork.ozlabs.org>; Fri, 26 May 2023 21:43:06 +1000 (AEST) Received: by mail-ed1-x53c.google.com with SMTP id 4fb4d7f45d1cf-513e9c14adbsf602923a12.3 for <incoming@patchwork.ozlabs.org>; Fri, 26 May 2023 04:43:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1685101381; cv=pass; d=google.com; s=arc-20160816; b=IyWmpaf9a3WyCLdY68i30AS9vI8IP1UohW1GEKwn/bYW12tIA94APGg1EzH64QRZDL LsGuROBwSIVZWg5g/ko2ZQ1B4WbwsvEnOxBS4zGS/oCrvkOLHx4ga7zSjADzVrv0zALf PKwrEL5kvkJHnaqrpa2b0JW4m+cbC1uI3wLNqgSsXbbzi+FPJ0kgMRrqal5W5xhkf/93 vzfjfdwDBbKs694Jv6a0LZfnhSNpW4isZBuhMvH6cFulsKwOHck23Lco5tavfbxfE2j/ KY1tv8hPR/eYCQMYqKz9OE6kEFN0SyeP704mY5BbTAxUmbzLEFWuSNbMT1+tKIlh8HUp EiFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=VrNoQcP9hV8vaw8vRhB+U8XE4Vqv5okaDQQrRo4v3BM=; b=WMKTfwaG/fYM6vA6Q2R+JIsG8XrcyyXN4wWrZwIhBVuLNNSspTUZgiIfO4K4T51YJq zocUnmdlvRqlt519VCZ4BgtGGeusWzlSSxpL1w3EfKDiDXJcCrEdnXZtARMtmm8H1fJN DzYBMknx4Vbr3mSOBntI8HRMUqD2CGhYY2he3+XPAFSO2ue2riZpuhyf2t4GIP+zkjj7 3NBZj962SclbAqbqwoZ+7PqkI6PFA4MMCP/7GkZ/wYFUzuM/RdVAXTke1nzA19jbQ/qe Fs0d0bzXYPQI9jFJAjZj49vWa+8a777qgSJZ6CUaEkHVJD7UOSnicLxTlcjng2eCDW6w Sfdw== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1685101381; x=1687693381; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc:subject:date:message-id:reply-to; bh=VrNoQcP9hV8vaw8vRhB+U8XE4Vqv5okaDQQrRo4v3BM=; b=QX4FrnzF9/yfA8DBpMSzX/VoYr8Ho2FG6gPC6huFWD0gnBSdLBHUsAlcMe983vN7No Wr1v873ZOHoCUmDnyEQ26/0ygf3CwrEbf2jt7JsSRrIVy3qRlxN7ZO55lAyN90qxqzBF ZZ8hphE2pUjOZW0JYlibf3zM0DdjxxjVdzMNMJIMMzNqeLpHcTG8ehv7pmaKnGlsiZ8P AQ5/cZdU1GNB12loHmqbzvzYspbYogqoex3Y+qhfvB0Lf851rHFMi1Mu80kwAUouWJeK cWruqudiQD/gi/TTQ/rG0PpchdPy1CI/aH7SvWvdzgJz7Rxyguj864Csw2btRgIDKt9Z g9OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685101381; x=1687693381; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :sender:from:to:cc:subject:date:message-id:reply-to; bh=VrNoQcP9hV8vaw8vRhB+U8XE4Vqv5okaDQQrRo4v3BM=; b=e/RNVOdX4KEPCQpV3OwoVTK9Za4N1E1iYRu1H8jDOLUMzryEC/NUUHdX26Xx7mXWGs 4n9CmOuPIfnljtSkAxV+T90AtsI0gDi8DJM+wPw5c5GUCDo6TzMET2sDjf90EoXM+Wr9 5E3dgJAx5N7QfXsz0+pQ114BkX11eLo1zb8/92Ly6WlWr7pb348ptceVvqzR7poBs342 x+YOcEaVj9ecMiCE7yK5myVIe7QIcUnQqvgDidrmQ5SeLZ7eWWLqzChBhTtablsS1eXv tef69T4uvDPqzGXmOKhp/hhh+qPqS+svasGiYLtS9pDCzohBCX7cvDGqFEuBccFzFhp+ Soew== Sender: swupdate@googlegroups.com X-Gm-Message-State: AC+VfDxd2V7G0t1KySnNSbaQ8Hrcq7LTunNEafHfjUG4SJNqsPAsdWtV sqhW+MPGPPo0rozrnLkF5JM= X-Google-Smtp-Source: ACHHUZ6sT0543UbXgdwN4iTtAKqvEuAGIL1db+SHc1czEyKAFI4ytcFMWebJlnlReYYO8vGdIalomg== X-Received: by 2002:a50:ed8e:0:b0:50b:c94c:a48 with SMTP id h14-20020a50ed8e000000b0050bc94c0a48mr1050364edr.30.1685101380903; Fri, 26 May 2023 04:43:00 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:aa7:d44d:0:b0:512:2392:3720 with SMTP id q13-20020aa7d44d000000b0051223923720ls286364edr.0.-pod-prod-02-eu; Fri, 26 May 2023 04:42:59 -0700 (PDT) X-Received: by 2002:aa7:c0cf:0:b0:509:bf63:a97e with SMTP id j15-20020aa7c0cf000000b00509bf63a97emr976471edp.16.1685101379310; Fri, 26 May 2023 04:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685101379; cv=none; d=google.com; s=arc-20160816; b=qidj39K89i1ix2lsItDlx9vlL1eDFyy54wqa2jBMS/ve9GBO4HAzUEoqcZxR7xKMTf YkUv0Eoqe6Vb4eo/dw3GrbkDW4OMLD+yVkH18WOxf8eHY6Sul041z3T4YyClH6TdtY8u hb35mPqs7qdJDHpMqDkbsHYiDNBXP8Y+nEDRrRRywoMBKc5UEC9VI+OJQEt2cJL0uQtM GaRePDykk4oD271WehnZ8HLiiWZCYygPp8A2dTRQ3D/IhmXZCHd8T+2uuCxFpNCMmMQv DmYxYJu5okHGPFVQkwUbbNqttlZVKNYY05cXbse15wvhOs4kRgWnkt5cSkrYRSm4+6lQ j0Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=pynoe8qwKV1nufjo3YhDOrgG7BVReHLPxKsCvENTXRA=; b=Bw88dme169TPZrpBAH8sovb/P173stfg50Zhmjy1bkNU/9D+6C3hqewUMTzEXe9OTj dM/A+NA82Uy7dRjeyP8Nf0J3SpbyvsALrS0MJKLvIr4Q1XhzB0j8Efx5qKWDvxu8LB57 BLv3MGjnEBfnwRjrkHMXsSU0cxur46Jl9aJRaE63SCsGRMik6FOJ1VTzN/t1Yf2ySE51 ZBYqzCZsNmscXB4LKGsARPmMyQbt+Jmnb/SVvij5bFtN4LQyJkA6yyWng8RwkX2xiPDJ gEkONmmnTChdzmyFCJn1ewULQOvsCC4eKfRLYo/8jO6bTZc8AH09kiCuDIGU7xiRW5KC jtrQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id i8-20020a0564020f0800b00510d963132csi277347eda.0.2023.05.26.04.42.59 for <swupdate@googlegroups.com> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 May 2023 04:42:59 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4QSNMl0bMBz1sHPT; Fri, 26 May 2023 13:42:59 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4QSNMk74gHz1qqlS; Fri, 26 May 2023 13:42:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id PQ07FzNtwGAi; Fri, 26 May 2023 13:42:58 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Fri, 26 May 2023 13:42:57 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 4C250454065D; Fri, 26 May 2023 13:42:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([127.0.0.1]) by localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WptHpTWA02JC; Fri, 26 May 2023 13:42:54 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.48]) by babic.homelinux.org (Postfix) with ESMTP id CE266454052D; Fri, 26 May 2023 13:42:54 +0200 (CEST) From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [PATCH] parser: log syntax error in sw-description Date: Fri, 26 May 2023 13:42:53 +0200 Message-Id: <20230526114253.399337-1-sbabic@denx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=denx.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
parser: log syntax error in sw-description
|
expand
|
diff --git a/parser/parser.c b/parser/parser.c index f2d4948b..4c0a8f2f 100644 --- a/parser/parser.c +++ b/parser/parser.c @@ -976,11 +976,7 @@ int parse_cfg (struct swupdate_cfg *swcfg, const char *filename) /* Read the file. If there is an error, report it and exit. */ DEBUG("Parsing config file %s", filename); if(config_read_file(&cfg, filename) != CONFIG_TRUE) { - printf("%s ", config_error_file(&cfg)); - printf("%d ", config_error_line(&cfg)); - printf("%s ", config_error_text(&cfg)); - - fprintf(stderr, "%s:%d - %s\n", config_error_file(&cfg), + ERROR("%s:%d - %s\n", config_error_file(&cfg), config_error_line(&cfg), config_error_text(&cfg)); config_destroy(&cfg); return -1;
Error code and line are rather just printed to stderr instead of putting in the log, and this makes debugging more difficult. Signed-off-by: Stefano Babic <sbabic@denx.de> --- parser/parser.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)