Message ID | 20230405123319.335294-1-sbabic@denx.de |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <swupdate+bncBCXPLOXJ6IKRBGGVWWQQMGQEFWHP7GY@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::537; helo=mail-ed1-x537.google.com; envelope-from=swupdate+bncbcxploxj6ikrbggvwwqqmgqefwhp7gy@googlegroups.com; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=Nh2MMOt3; dkim-atps=neutral Received: from mail-ed1-x537.google.com (mail-ed1-x537.google.com [IPv6:2a00:1450:4864:20::537]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ps3vf6bd4z1yY8 for <incoming@patchwork.ozlabs.org>; Wed, 5 Apr 2023 22:33:33 +1000 (AEST) Received: by mail-ed1-x537.google.com with SMTP id r19-20020a50aad3000000b005002e950cd3sf50352324edc.11 for <incoming@patchwork.ozlabs.org>; Wed, 05 Apr 2023 05:33:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1680698008; cv=pass; d=google.com; s=arc-20160816; b=UJxIzNREi2dNrxtwye1WPEI3p5DNeH8w7lUhrwOxvCzUYhYtORiOmfAu0jD7+yyHiD o6euFMGVFHyHKS/+Z9ucI6SpbMnONnzkofRkXHS1FPGUMfFgxvYiOJtHkT3SNkFz+x4F kTsIPm/qLbPCBxB2ZujlQaUcRNnLTN70TK36HE2di38gURe04Am/UfggWRPbVSgz/dI8 jr+OPyxZpuzDA2RLGHOMC6jxHqHO3NpMGSvtlLfOIuG5H/gltxkZ/qVdcW8UmXU44lbR zZxnAImcZK+4NyhikrK0DA6gM4txCpduR5iEO1QW/tR9r4wMfy+BJ0oCqGBAUF02tEkc 29MQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=GngcavmeXFJza9zVFu2KfdXiAEwtiidrBUGjlbDfQ+k=; b=fIdx/KG73X21OguBDRrLqoeqZ/Qrwg1cxvxN3z/JOOMR5Hp2QbVVndCEMzD/XHmYoX Uz0zhQG4qGTqXRJQRjetLoLc3v6OSlxMnNgnGqv4Eoo464HWQutQabeadUW6I9M8p3JW rzFdMudQV61SA/3SHRusW4U0d4FeXrh6znkTrexHX3Mb6u6Mm5Qdm89W3gKk33WTvmRh WJzdPuSvwVjVAzljEO9UVvq/T3NEo3ywclwXkhPMKfzc50ovquSRC35BFnMLEjpnFKEp Stw8KlusbfYYXEdP/HdEeVNah9Jjy92dlN30CRyPKFxY8JAv9ejKAEB9w8YaMarOMHtN k+6g== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; t=1680698008; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc:subject:date:message-id:reply-to; bh=GngcavmeXFJza9zVFu2KfdXiAEwtiidrBUGjlbDfQ+k=; b=Nh2MMOt3H8wOtFEtfO6i2QptoXl5gKoFdFCe36H7s1yr/qZqldG0ERSl33ScEaEFef l+SxMw/a0aZAyOSXrkTF3tlzIG7Q/M484OrSdxmCk0u/8XQ8v/o4jjvx0QT/nMboPGY8 RfU0KnnSCyG8N00Xoxub5RzZS5jo80LgDwBaO5tlYgcYB85x3Nq2ah8G7KxMNr+tcrAK kS1N6XNPhfc+LXGmul/aUB24wNRTIbx3k+OsEQU7KfxCJquw6OND2UhXgNScLS6/3y41 NLTgho1RLl042SrvgZk/OcwJSz0DPmssTfk87yuaUyE510+1jeegxBBUbV0hoCcBc+4D TljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680698008; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=GngcavmeXFJza9zVFu2KfdXiAEwtiidrBUGjlbDfQ+k=; b=HibyAufw8H9mgdnMuzBuba0CCZryrqLkGjs1EhIOV9yBJJ3j28ey1Iw9CBjnQgNht9 hDe9VydNK0x8l+QVA3RZVJnJyyVQ7QmaSzHzXaO3PIbuOPAakACQiZlO+lE9trwFE0Ut JdcpM7GZzfD94WLxcrcvxZ9V0xaIrbVQsTVEZTF/GX7hRcQLLs/m+VULHd6VmN489PPm bcar9dZjVQxQL8BcEtUMUdgdEB3VnpOCuEl3MQO3B3SUs6eWCKLLC9mk/x+BgEXqijVw HGmJmlYzrHHze5O40WSJ50vYqPspHYYAX7jptTZuwsH542/sOgyVVCK1l2fzmReQI2Rd GPpg== Sender: swupdate@googlegroups.com X-Gm-Message-State: AAQBX9fXMnUa2ickeQLFdIT9VO5AFPCPopomU03RJqWPQum6pCBsdncA tcb7T+O47POVuaWkNQH1UcI= X-Google-Smtp-Source: AKy350YzeYG+YV0GTi895p1tHPbBhaT9wd0xIapL1cohupeApHQxdDMxxi21Fo3PkTozQqh1KZEf7A== X-Received: by 2002:a17:907:8c17:b0:931:6921:bdbb with SMTP id ta23-20020a1709078c1700b009316921bdbbmr489065ejc.2.1680698008541; Wed, 05 Apr 2023 05:33:28 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:6402:3203:b0:502:26b1:64e0 with SMTP id g3-20020a056402320300b0050226b164e0ls8182094eda.1.-pod-prod-gmail; Wed, 05 Apr 2023 05:33:27 -0700 (PDT) X-Received: by 2002:aa7:cd6a:0:b0:502:23a2:6739 with SMTP id ca10-20020aa7cd6a000000b0050223a26739mr1603314edb.28.1680698006951; Wed, 05 Apr 2023 05:33:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680698006; cv=none; d=google.com; s=arc-20160816; b=zfHYfNB49hOLBU72BPdD83P4d4CWyInclVGAhkwq5x+XCBfXCcFTUQZ3s2S/UvlgL1 XyaguyHJRqycQ6bOvkoN4fXrZNe5mbWLqvALjEGidymrPX9qHmKWawdv9En5n3Be2MOs ntlzTWO04QxScfEQ0YaHqaZbaY1xxNBcDxNYgfhFeyoT3obEMiByopxMby+3dj1/g3pk Js/6D9XEbxtB47uH/zZBtAoW+88ngfxBGlgH67D/sBxk67eZyV1/8KvJpP3HL3jlUFKa fTa96akB2GeWzB2oBP7ZnZjnk86XL06UXcfXZvAtLUuHIz3dm8dC4Qqf4ZWIPAmLvhTi L8eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=DU+8Ewsdy5/VwryMiakwn4Qaa/oFJe0MIlBJe4stXCM=; b=qXa/NWYNH1NvIEMEvk4ZGt8OpbSal+ovgHWtre2agZiNIw/zqL4Oai7EEGSplS+31v i4FLJduWQI4Iw6ouoaI8GY3wVgs2rA94zcC5pR/hY3+8K9UNBmnsH+yshCs2RgeLtnam SaCO6XfvE8O86xdTdo7qIEFn3sY5xneYSz2qWoSFSlg1YW96ygj/Og731QwrgCjosPq/ v4oZCzpcm7Yk8OvB1wriBWuVzLPhq3tDtJhXIKD67PRIqcZrFZh8REqC4AsG6NN98OBB PKZ/X4AjFCdFEyo/XIVpnrC07FJELcWtk0RhJpQiBMiyPcKREcNQY2An/Y+McrRTGySA Gziw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id y8-20020a056402440800b004bbea073a82si661975eda.5.2023.04.05.05.33.26 for <swupdate@googlegroups.com> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2023 05:33:26 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) client-ip=212.18.0.9; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Ps3vV5WZmz1r1Mf; Wed, 5 Apr 2023 14:33:26 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Ps3vV5Frvz1qqlS; Wed, 5 Apr 2023 14:33:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id SRvXhR8nsi_6; Wed, 5 Apr 2023 14:33:25 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Wed, 5 Apr 2023 14:33:25 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 251DB4540B85; Wed, 5 Apr 2023 14:33:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id ls_D0QWhZRbM; Wed, 5 Apr 2023 14:33:22 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.48]) by babic.homelinux.org (Postfix) with ESMTP id D32E84540853; Wed, 5 Apr 2023 14:33:22 +0200 (CEST) From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [PATCH 1/2] copy handler: drop dead code Date: Wed, 5 Apr 2023 14:33:18 +0200 Message-Id: <20230405123319.335294-1-sbabic@denx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
[1/2] copy handler: drop dead code
|
expand
|
diff --git a/handlers/copy_handler.c b/handlers/copy_handler.c index 27f6caf..872724c 100644 --- a/handlers/copy_handler.c +++ b/handlers/copy_handler.c @@ -36,6 +36,11 @@ static void copy_handler(void); static void raw_copyimage_handler(void); +static bool copy_single_file(const char *path) +{ + +} + static int copy_image_file(struct img_type *img, void *data) { int ret; @@ -133,12 +138,6 @@ static int copy_image_file(struct img_type *img, void *data) free(path); - if (!size) { - ERROR("Size cannot be detected, please set it, exiting..."); - close(fdin); - return -EFAULT; - } - if (pipe(pipes) < 0) { ERROR("Could not create pipes for chained handler, existing..."); close(fdin);
Second check about size value cannot be hit, removed. Signed-off-by: Stefano Babic <sbabic@denx.de> --- handlers/copy_handler.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)