diff mbox

examples/client: use default foreground color for log messages

Message ID 20230221090707.31436-1-daniel@braunwarth.dev
State Accepted
Headers show

Commit Message

Daniel Braunwarth Feb. 21, 2023, 9:07 a.m. UTC
As reported changing the foreground color to black / grey results
in hard to read log messages.

Signed-off-by: Daniel Braunwarth <daniel@braunwarth.dev>
---
 examples/client/swupdate_client.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.39.2

Comments

Fabio Estevam Feb. 21, 2023, 11:10 a.m. UTC | #1
Hi Daniel,

On Tue, Feb 21, 2023 at 6:07 AM Daniel Braunwarth <daniel@braunwarth.dev> wrote:
>
> As reported changing the foreground color to black / grey results
> in hard to read log messages.
>
> Signed-off-by: Daniel Braunwarth <daniel@braunwarth.dev>

Thanks for doing this.

Reported-by: Fabio Estevam <festevam@denx.de>
Tested-by: Fabio Estevam <festevam@denx.de>
Stefano Babic Feb. 22, 2023, 8:04 a.m. UTC | #2
On 21.02.23 10:07, Daniel Braunwarth wrote:
> As reported changing the foreground color to black / grey results
> in hard to read log messages.
> 
> Signed-off-by: Daniel Braunwarth <daniel@braunwarth.dev>
> ---
>   examples/client/swupdate_client.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/client/swupdate_client.py b/examples/client/swupdate_client.py
> index 8763283..b45adf7 100755
> --- a/examples/client/swupdate_client.py
> +++ b/examples/client/swupdate_client.py
> @@ -29,8 +29,8 @@ class ColorFormatter(logging.Formatter):
>       """Custom logging formatter with colorized output"""
> 
>       COLORS = {
> -        logging.DEBUG: "dark_grey",
> -        logging.INFO: "black",
> +        logging.DEBUG: None,
> +        logging.INFO: None,
>           logging.WARNING: "yellow",
>           logging.ERROR: "red",
>       }
> --
> 2.39.2
> 

Applied to -master, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/examples/client/swupdate_client.py b/examples/client/swupdate_client.py
index 8763283..b45adf7 100755
--- a/examples/client/swupdate_client.py
+++ b/examples/client/swupdate_client.py
@@ -29,8 +29,8 @@  class ColorFormatter(logging.Formatter):
     """Custom logging formatter with colorized output"""

     COLORS = {
-        logging.DEBUG: "dark_grey",
-        logging.INFO: "black",
+        logging.DEBUG: None,
+        logging.INFO: None,
         logging.WARNING: "yellow",
         logging.ERROR: "red",
     }