diff mbox series

[swugenerator,12/13] main.py: Refactor variable names that overrode built-ins

Message ID 20230110181237.410579-13-colin.mcallister@garmin.com
State Accepted
Headers show
Series Refactoring Python code | expand

Commit Message

McAllister, Colin Jan. 10, 2023, 6:12 p.m. UTC 
From: Colin McAllister <colinmca242@gmail.com>

Renamed variables that shadowed built-in names. This fixes pylint error
W0622 and ensures that the build-in names still work as desired.

Signed-off-by: Colin McAllister <colinmca242@gmail.com>
---
 swugenerator/main.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/swugenerator/main.py b/swugenerator/main.py
index b4cf989..8a8c6e3 100644
--- a/swugenerator/main.py
+++ b/swugenerator/main.py
@@ -150,7 +150,7 @@  def main() -> None:
             logging.basicConfig(level=logging.CRITICAL)
 
     # Read configuration file if any
-    vars = {}
+    config_vars = {}
     if args.config and args.config != "":
         logging.info("Reading configuration file %s", args.config)
 
@@ -160,7 +160,7 @@  def main() -> None:
                 if key == "variables":
                     for varname, varvalue in keydict.items():
                         logging.debug("VAR = %s VAL = %s", varname, varvalue)
-                        vars[varname] = varvalue
+                        config_vars[varname] = varvalue
             f.close()
 
     # Signing
@@ -210,15 +210,15 @@  def main() -> None:
     artidirs.append(os.getcwd())
     if args.artifactory:
         dirs = args.artifactory.split(",")
-        for dir in dirs:
-            deploy = Path(dir).resolve()
+        for directory in dirs:
+            deploy = Path(directory).resolve()
             artidirs.append(deploy)
 
     if args.command == "create":
         swu = generator.SWUGenerator(
             args.sw_description,
             args.swu_file,
-            vars,
+            config_vars,
             artidirs,
             sign_option,
             key,