diff mbox series

channel_curl: reduce log level

Message ID 20221128134517.892749-1-michael.adler@siemens.com
State Accepted
Headers show
Series channel_curl: reduce log level | expand

Commit Message

Michael Adler Nov. 28, 2022, 1:45 p.m. UTC 
Printing each HTTP header is rather verbose and spams the logs/journal.
Since this kind of information is rarely needed, I'm suggesting to
increase the log level.

Signed-off-by: Michael Adler <michael.adler@siemens.com>
---
 corelib/channel_curl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Babic Nov. 28, 2022, 2:37 p.m. UTC | #1 
On 28.11.22 14:45, Michael Adler wrote:
> Printing each HTTP header is rather verbose and spams the logs/journal.
> Since this kind of information is rarely needed, I'm suggesting to
> increase the log level.
> 
> Signed-off-by: Michael Adler <michael.adler@siemens.com>
> ---
>   corelib/channel_curl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/corelib/channel_curl.c b/corelib/channel_curl.c
> index 1426390..81808f8 100644
> --- a/corelib/channel_curl.c
> +++ b/corelib/channel_curl.c
> @@ -492,9 +492,9 @@ static size_t channel_callback_headers(char *buffer, size_t size, size_t nitems,
>   			*strchrnul(val, '\n') = '\0';
>   			/* For multiple same-key headers, only the last is saved. */
>   			dict_set_value(dict, key, val);
> -			TRACE("Header processed: %s : %s", key, val);
> +			DEBUG("Header processed: %s : %s", key, val);
>   		} else {
> -			TRACE("Header not processed: '%s'", info);
> +			DEBUG("Header not processed: '%s'", info);
>   		}
>   
>   		free(info);

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/corelib/channel_curl.c b/corelib/channel_curl.c
index 1426390..81808f8 100644
--- a/corelib/channel_curl.c
+++ b/corelib/channel_curl.c
@@ -492,9 +492,9 @@  static size_t channel_callback_headers(char *buffer, size_t size, size_t nitems,
 			*strchrnul(val, '\n') = '\0';
 			/* For multiple same-key headers, only the last is saved. */
 			dict_set_value(dict, key, val);
-			TRACE("Header processed: %s : %s", key, val);
+			DEBUG("Header processed: %s : %s", key, val);
 		} else {
-			TRACE("Header not processed: '%s'", info);
+			DEBUG("Header not processed: '%s'", info);
 		}
 
 		free(info);