| Message ID | 20220815165151.16775-2-peter@berginkonsult.se |
|---|---|
| State | Accepted |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [meta-swupdate,1/2] swupdate.bbclass: drop suffix from class name | expand |
Hi Peter, On 15.08.22 18:51, Peter Bergin wrote: > To match the new feature of bitbake [1] to set scope for classes all classes > of this layer is moved and set to recipe scope. > > [1] https://git.openembedded.org/bitbake/commit/?id=f33ce7e742f46635658c400b82558cf822690b5e > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > --- > {classes => classes-recipe}/swupdate-common.bbclass | 0 > {classes => classes-recipe}/swupdate-enc.bbclass | 0 > {classes => classes-recipe}/swupdate-image.bbclass | 0 > {classes => classes-recipe}/swupdate-lib.bbclass | 0 > {classes => classes-recipe}/swupdate.bbclass | 0 > 5 files changed, 0 insertions(+), 0 deletions(-) > rename {classes => classes-recipe}/swupdate-common.bbclass (100%) > rename {classes => classes-recipe}/swupdate-enc.bbclass (100%) > rename {classes => classes-recipe}/swupdate-image.bbclass (100%) > rename {classes => classes-recipe}/swupdate-lib.bbclass (100%) > rename {classes => classes-recipe}/swupdate.bbclass (100%) > > diff --git a/classes/swupdate-common.bbclass b/classes-recipe/swupdate-common.bbclass > similarity index 100% > rename from classes/swupdate-common.bbclass > rename to classes-recipe/swupdate-common.bbclass > diff --git a/classes/swupdate-enc.bbclass b/classes-recipe/swupdate-enc.bbclass > similarity index 100% > rename from classes/swupdate-enc.bbclass > rename to classes-recipe/swupdate-enc.bbclass > diff --git a/classes/swupdate-image.bbclass b/classes-recipe/swupdate-image.bbclass > similarity index 100% > rename from classes/swupdate-image.bbclass > rename to classes-recipe/swupdate-image.bbclass > diff --git a/classes/swupdate-lib.bbclass b/classes-recipe/swupdate-lib.bbclass > similarity index 100% > rename from classes/swupdate-lib.bbclass > rename to classes-recipe/swupdate-lib.bbclass > diff --git a/classes/swupdate.bbclass b/classes-recipe/swupdate.bbclass > similarity index 100% > rename from classes/swupdate.bbclass > rename to classes-recipe/swupdate.bbclass The result of this is that further fixes for classes should be addressed with different patches. I support OE LTS versions (+honister as Bonus, currently), the oldest is dunfell. This patch can be applied only to -master (future Langdale release) because older bitbake does not support this. After applying this patch, the consequence is: - for any fix in meta-swupdate I will need separate patches for the supported branches. - patches should be surrounded with branch name to help me to apply them, like: [meta-swupdate][kirkstone][PATCH ...] - patches should be complete, that is it cannot be that a supported branch is not fixed / updated and left behind. Of course, this is the way in future - but we have a transition, and applying this means to add some further work also for the contributors. I want just to make aware of this before applying and waiting for comments. Best regards, Stefano Babic
Hi Stefano, On 2022-08-17 10:29, Stefano Babic wrote: > Hi Peter, > > On 15.08.22 18:51, Peter Bergin wrote: >> To match the new feature of bitbake [1] to set scope for classes all >> classes >> of this layer is moved and set to recipe scope. >> >> [1] >> https://git.openembedded.org/bitbake/commit/?id=f33ce7e742f46635658c400b82558cf822690b5e >> >> Signed-off-by: Peter Bergin <peter@berginkonsult.se> >> --- >> {classes => classes-recipe}/swupdate-common.bbclass | 0 >> {classes => classes-recipe}/swupdate-enc.bbclass | 0 >> {classes => classes-recipe}/swupdate-image.bbclass | 0 >> {classes => classes-recipe}/swupdate-lib.bbclass | 0 >> {classes => classes-recipe}/swupdate.bbclass | 0 >> 5 files changed, 0 insertions(+), 0 deletions(-) >> rename {classes => classes-recipe}/swupdate-common.bbclass (100%) >> rename {classes => classes-recipe}/swupdate-enc.bbclass (100%) >> rename {classes => classes-recipe}/swupdate-image.bbclass (100%) >> rename {classes => classes-recipe}/swupdate-lib.bbclass (100%) >> rename {classes => classes-recipe}/swupdate.bbclass (100%) >> >> diff --git a/classes/swupdate-common.bbclass >> b/classes-recipe/swupdate-common.bbclass >> similarity index 100% >> rename from classes/swupdate-common.bbclass >> rename to classes-recipe/swupdate-common.bbclass >> diff --git a/classes/swupdate-enc.bbclass >> b/classes-recipe/swupdate-enc.bbclass >> similarity index 100% >> rename from classes/swupdate-enc.bbclass >> rename to classes-recipe/swupdate-enc.bbclass >> diff --git a/classes/swupdate-image.bbclass >> b/classes-recipe/swupdate-image.bbclass >> similarity index 100% >> rename from classes/swupdate-image.bbclass >> rename to classes-recipe/swupdate-image.bbclass >> diff --git a/classes/swupdate-lib.bbclass >> b/classes-recipe/swupdate-lib.bbclass >> similarity index 100% >> rename from classes/swupdate-lib.bbclass >> rename to classes-recipe/swupdate-lib.bbclass >> diff --git a/classes/swupdate.bbclass b/classes-recipe/swupdate.bbclass >> similarity index 100% >> rename from classes/swupdate.bbclass >> rename to classes-recipe/swupdate.bbclass > > The result of this is that further fixes for classes should be > addressed with different patches. I support OE LTS versions (+honister > as Bonus, currently), the oldest is dunfell. This patch can be applied > only to -master (future Langdale release) because older bitbake does > not support this. After applying this patch, the consequence is: > > - for any fix in meta-swupdate I will need separate patches for the > supported branches. > - patches should be surrounded with branch name to help me to apply > them, like: > [meta-swupdate][kirkstone][PATCH ...] > - patches should be complete, that is it cannot be that a supported > branch is not fixed / updated and left behind. > > Of course, this is the way in future - but we have a transition, and > applying this means to add some further work also for the > contributors. I want just to make aware of this before applying and > waiting for comments. > I fully understand this and I know I was early with this patch. But as I was in the area I also sent it. No problem if you stay with the classes in 'classes' directory to make maintenance easier. This does not block anything at the moment. Best regards, /Peter
Hi Peter, On 17.08.22 10:54, Peter Bergin wrote: > Hi Stefano, > > On 2022-08-17 10:29, Stefano Babic wrote: >> Hi Peter, >> >> On 15.08.22 18:51, Peter Bergin wrote: >>> To match the new feature of bitbake [1] to set scope for classes all >>> classes >>> of this layer is moved and set to recipe scope. >>> >>> [1] >>> https://git.openembedded.org/bitbake/commit/?id=f33ce7e742f46635658c400b82558cf822690b5e >>> >>> Signed-off-by: Peter Bergin <peter@berginkonsult.se> >>> --- >>> {classes => classes-recipe}/swupdate-common.bbclass | 0 >>> {classes => classes-recipe}/swupdate-enc.bbclass | 0 >>> {classes => classes-recipe}/swupdate-image.bbclass | 0 >>> {classes => classes-recipe}/swupdate-lib.bbclass | 0 >>> {classes => classes-recipe}/swupdate.bbclass | 0 >>> 5 files changed, 0 insertions(+), 0 deletions(-) >>> rename {classes => classes-recipe}/swupdate-common.bbclass (100%) >>> rename {classes => classes-recipe}/swupdate-enc.bbclass (100%) >>> rename {classes => classes-recipe}/swupdate-image.bbclass (100%) >>> rename {classes => classes-recipe}/swupdate-lib.bbclass (100%) >>> rename {classes => classes-recipe}/swupdate.bbclass (100%) >>> >>> diff --git a/classes/swupdate-common.bbclass >>> b/classes-recipe/swupdate-common.bbclass >>> similarity index 100% >>> rename from classes/swupdate-common.bbclass >>> rename to classes-recipe/swupdate-common.bbclass >>> diff --git a/classes/swupdate-enc.bbclass >>> b/classes-recipe/swupdate-enc.bbclass >>> similarity index 100% >>> rename from classes/swupdate-enc.bbclass >>> rename to classes-recipe/swupdate-enc.bbclass >>> diff --git a/classes/swupdate-image.bbclass >>> b/classes-recipe/swupdate-image.bbclass >>> similarity index 100% >>> rename from classes/swupdate-image.bbclass >>> rename to classes-recipe/swupdate-image.bbclass >>> diff --git a/classes/swupdate-lib.bbclass >>> b/classes-recipe/swupdate-lib.bbclass >>> similarity index 100% >>> rename from classes/swupdate-lib.bbclass >>> rename to classes-recipe/swupdate-lib.bbclass >>> diff --git a/classes/swupdate.bbclass b/classes-recipe/swupdate.bbclass >>> similarity index 100% >>> rename from classes/swupdate.bbclass >>> rename to classes-recipe/swupdate.bbclass >> >> The result of this is that further fixes for classes should be >> addressed with different patches. I support OE LTS versions (+honister >> as Bonus, currently), the oldest is dunfell. This patch can be applied >> only to -master (future Langdale release) because older bitbake does >> not support this. After applying this patch, the consequence is: >> >> - for any fix in meta-swupdate I will need separate patches for the >> supported branches. >> - patches should be surrounded with branch name to help me to apply >> them, like: >> [meta-swupdate][kirkstone][PATCH ...] >> - patches should be complete, that is it cannot be that a supported >> branch is not fixed / updated and left behind. >> >> Of course, this is the way in future - but we have a transition, and >> applying this means to add some further work also for the >> contributors. I want just to make aware of this before applying and >> waiting for comments. >> > I fully understand this and I know I was early with this patch. But as I > was in the area I also sent it. No problem if you stay with the classes > in 'classes' directory to make maintenance easier. This does not block > anything at the moment. With next OE release approaching, I have applied this to -master and langdale, mickledore branch will be created, too. Best regards, Stefano Babic
diff --git a/classes/swupdate-common.bbclass b/classes-recipe/swupdate-common.bbclass similarity index 100% rename from classes/swupdate-common.bbclass rename to classes-recipe/swupdate-common.bbclass diff --git a/classes/swupdate-enc.bbclass b/classes-recipe/swupdate-enc.bbclass similarity index 100% rename from classes/swupdate-enc.bbclass rename to classes-recipe/swupdate-enc.bbclass diff --git a/classes/swupdate-image.bbclass b/classes-recipe/swupdate-image.bbclass similarity index 100% rename from classes/swupdate-image.bbclass rename to classes-recipe/swupdate-image.bbclass diff --git a/classes/swupdate-lib.bbclass b/classes-recipe/swupdate-lib.bbclass similarity index 100% rename from classes/swupdate-lib.bbclass rename to classes-recipe/swupdate-lib.bbclass diff --git a/classes/swupdate.bbclass b/classes-recipe/swupdate.bbclass similarity index 100% rename from classes/swupdate.bbclass rename to classes-recipe/swupdate.bbclass
To match the new feature of bitbake [1] to set scope for classes all classes of this layer is moved and set to recipe scope. [1] https://git.openembedded.org/bitbake/commit/?id=f33ce7e742f46635658c400b82558cf822690b5e Signed-off-by: Peter Bergin <peter@berginkonsult.se> --- {classes => classes-recipe}/swupdate-common.bbclass | 0 {classes => classes-recipe}/swupdate-enc.bbclass | 0 {classes => classes-recipe}/swupdate-image.bbclass | 0 {classes => classes-recipe}/swupdate-lib.bbclass | 0 {classes => classes-recipe}/swupdate.bbclass | 0 5 files changed, 0 insertions(+), 0 deletions(-) rename {classes => classes-recipe}/swupdate-common.bbclass (100%) rename {classes => classes-recipe}/swupdate-enc.bbclass (100%) rename {classes => classes-recipe}/swupdate-image.bbclass (100%) rename {classes => classes-recipe}/swupdate-lib.bbclass (100%) rename {classes => classes-recipe}/swupdate.bbclass (100%)