| Message ID | 20220530235717.2181849-1-festevam@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | cpio_utils: Improve warning message | expand |
On 31.05.22 01:57, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > When the deprecated 'compressed = true' is used in sw-description, > a warning is generated to suggest the user to use the string form. > > Improve the warning message by stating what is the recommended > string format. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > core/cpio_utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/core/cpio_utils.c b/core/cpio_utils.c > index e338e4d88df5..917935200cb9 100644 > --- a/core/cpio_utils.c > +++ b/core/cpio_utils.c > @@ -503,7 +503,7 @@ static int __swupdate_copy(int fdin, unsigned char *inbuf, void *out, size_t nby > > if (compressed) { > if (compressed == COMPRESSED_TRUE) { > - WARN("compressed argument: boolean form is deprecated, use the string form"); > + WARN("compressed argument: boolean form is deprecated, use compressed = "zlib";"); Of course this is not compiled clean, but I escaped myself "zlib" by applying. Best regards, Stefano > } > #ifdef CONFIG_GUNZIP > if (compressed == COMPRESSED_ZLIB || compressed == COMPRESSED_TRUE) {
diff --git a/core/cpio_utils.c b/core/cpio_utils.c index e338e4d88df5..917935200cb9 100644 --- a/core/cpio_utils.c +++ b/core/cpio_utils.c @@ -503,7 +503,7 @@ static int __swupdate_copy(int fdin, unsigned char *inbuf, void *out, size_t nby if (compressed) { if (compressed == COMPRESSED_TRUE) { - WARN("compressed argument: boolean form is deprecated, use the string form"); + WARN("compressed argument: boolean form is deprecated, use compressed = "zlib";"); } #ifdef CONFIG_GUNZIP if (compressed == COMPRESSED_ZLIB || compressed == COMPRESSED_TRUE) {