| Message ID | 20220509150325.73591-1-christian.storm@siemens.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | bootloader: Tie U-Boot & EBG to specific interface versions | expand |
On 09.05.22 17:03, Christian Storm wrote: > Explicitly require particular interface versions of the EFI > Boot Guard and libubootenv shared libraries, namely currently > libebgenv.so.0 and libubootenv.so.0. > > The rationale is that if the interface version is increased, > most likely SWUpdate has to be adapted with code changes due > to the interface change. Being explicit about the interface > version supported by SWUpdate helps integrators / packagers. > > Note that at least EFI Boot Guard v0.11 (released 2022-05-04) > is required as it has changed its versioning scheme accordingly. > > Signed-off-by: Christian Storm <christian.storm@siemens.com> > --- > bootloader/ebg.c | 2 +- > bootloader/uboot.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bootloader/ebg.c b/bootloader/ebg.c > index 2cd6a65..bb369d0 100644 > --- a/bootloader/ebg.c > +++ b/bootloader/ebg.c > @@ -198,7 +198,7 @@ static bootloader ebg = { > > static bootloader* probe(void) > { > - void* handle = dlopen("libebgenv.so", RTLD_NOW | RTLD_GLOBAL); > + void* handle = dlopen("libebgenv.so.0", RTLD_NOW | RTLD_GLOBAL); > if (!handle) { > return NULL; > } > diff --git a/bootloader/uboot.c b/bootloader/uboot.c > index 729cf16..ed4c516 100644 > --- a/bootloader/uboot.c > +++ b/bootloader/uboot.c > @@ -123,7 +123,7 @@ static bootloader uboot = { > > static bootloader* probe(void) > { > - void* handle = dlopen("libubootenv.so", RTLD_NOW | RTLD_GLOBAL); > + void* handle = dlopen("libubootenv.so.0", RTLD_NOW | RTLD_GLOBAL); > if (!handle) { > return NULL; > } Reviewed-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
On 09.05.22 17:03, Christian Storm wrote: > Explicitly require particular interface versions of the EFI > Boot Guard and libubootenv shared libraries, namely currently > libebgenv.so.0 and libubootenv.so.0. > > The rationale is that if the interface version is increased, > most likely SWUpdate has to be adapted with code changes due > to the interface change. Being explicit about the interface > version supported by SWUpdate helps integrators / packagers. > > Note that at least EFI Boot Guard v0.11 (released 2022-05-04) > is required as it has changed its versioning scheme accordingly. > > Signed-off-by: Christian Storm <christian.storm@siemens.com> > --- > bootloader/ebg.c | 2 +- > bootloader/uboot.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bootloader/ebg.c b/bootloader/ebg.c > index 2cd6a65..bb369d0 100644 > --- a/bootloader/ebg.c > +++ b/bootloader/ebg.c > @@ -198,7 +198,7 @@ static bootloader ebg = { > > static bootloader* probe(void) > { > - void* handle = dlopen("libebgenv.so", RTLD_NOW | RTLD_GLOBAL); > + void* handle = dlopen("libebgenv.so.0", RTLD_NOW | RTLD_GLOBAL); > if (!handle) { > return NULL; > } > diff --git a/bootloader/uboot.c b/bootloader/uboot.c > index 729cf16..ed4c516 100644 > --- a/bootloader/uboot.c > +++ b/bootloader/uboot.c > @@ -123,7 +123,7 @@ static bootloader uboot = { > > static bootloader* probe(void) > { > - void* handle = dlopen("libubootenv.so", RTLD_NOW | RTLD_GLOBAL); > + void* handle = dlopen("libubootenv.so.0", RTLD_NOW | RTLD_GLOBAL); > if (!handle) { > return NULL; > } Applied to -master, thanks ! Best regards, Stefano Babic
diff --git a/bootloader/ebg.c b/bootloader/ebg.c index 2cd6a65..bb369d0 100644 --- a/bootloader/ebg.c +++ b/bootloader/ebg.c @@ -198,7 +198,7 @@ static bootloader ebg = { static bootloader* probe(void) { - void* handle = dlopen("libebgenv.so", RTLD_NOW | RTLD_GLOBAL); + void* handle = dlopen("libebgenv.so.0", RTLD_NOW | RTLD_GLOBAL); if (!handle) { return NULL; } diff --git a/bootloader/uboot.c b/bootloader/uboot.c index 729cf16..ed4c516 100644 --- a/bootloader/uboot.c +++ b/bootloader/uboot.c @@ -123,7 +123,7 @@ static bootloader uboot = { static bootloader* probe(void) { - void* handle = dlopen("libubootenv.so", RTLD_NOW | RTLD_GLOBAL); + void* handle = dlopen("libubootenv.so.0", RTLD_NOW | RTLD_GLOBAL); if (!handle) { return NULL; }
Explicitly require particular interface versions of the EFI Boot Guard and libubootenv shared libraries, namely currently libebgenv.so.0 and libubootenv.so.0. The rationale is that if the interface version is increased, most likely SWUpdate has to be adapted with code changes due to the interface change. Being explicit about the interface version supported by SWUpdate helps integrators / packagers. Note that at least EFI Boot Guard v0.11 (released 2022-05-04) is required as it has changed its versioning scheme accordingly. Signed-off-by: Christian Storm <christian.storm@siemens.com> --- bootloader/ebg.c | 2 +- bootloader/uboot.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)