Message ID | 20220331152431.152931-1-bstruempfel@ultratronik.de |
---|---|
State | Accepted |
Headers | show |
Series | Fixed compiler error for delta updates | expand |
Hi Börge, On 31.03.22 17:24, Börge Strümpfel wrote: > Compiling swupdate with CONFIG_DELTA enabled but CONFIG_MONGOOSE > disabled led to a compiler error. > You're right. > The variables ac and av are not being declared when not using > mongoose. This resulted in compile-time errors. Switched to using > dwlav and dwlac instead, since both variables in question are unused by > start_delta_downloader and dwlav and dwlac are always declared. > At the moment, the downloader process does not need any paramter. We can do as you propose, but it looks like that the same parameters are used. To make this more explicit, I propose: > Signed-off-by: Börge Strümpfel <bstruempfel@ultratronik.de> > --- > core/swupdate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/core/swupdate.c b/core/swupdate.c > index b59e0eb..4db098e 100644 > --- a/core/swupdate.c > +++ b/core/swupdate.c > @@ -860,7 +860,7 @@ int main(int argc, char **argv) > gid_t gid; > read_settings_user_id(&handle, "download", &uid, &gid); > start_subprocess(SOURCE_CHUNKS_DOWNLOADER, "chunks_downloader", uid, gid, > - cfgfname, ac, av, > + cfgfname, dwlac, dwlav, + cfgfname, 0, NULL, Best regards, Stefano Babic
diff --git a/core/swupdate.c b/core/swupdate.c index b59e0eb..4db098e 100644 --- a/core/swupdate.c +++ b/core/swupdate.c @@ -860,7 +860,7 @@ int main(int argc, char **argv) gid_t gid; read_settings_user_id(&handle, "download", &uid, &gid); start_subprocess(SOURCE_CHUNKS_DOWNLOADER, "chunks_downloader", uid, gid, - cfgfname, ac, av, + cfgfname, dwlac, dwlav, start_delta_downloader); } #endif
Compiling swupdate with CONFIG_DELTA enabled but CONFIG_MONGOOSE disabled led to a compiler error. The variables ac and av are not being declared when not using mongoose. This resulted in compile-time errors. Switched to using dwlav and dwlac instead, since both variables in question are unused by start_delta_downloader and dwlav and dwlac are always declared. Signed-off-by: Börge Strümpfel <bstruempfel@ultratronik.de> --- core/swupdate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)