diff mbox series

[1/2] server_hawkbit: fix NULL dereference

Message ID 20211220121516.191447-1-christian.storm@siemens.com
State Accepted
Headers show
Series [1/2] server_hawkbit: fix NULL dereference | expand

Commit Message

Storm, Christian Dec. 20, 2021, 12:15 p.m. UTC 
Don't dereference the returned NULL pointer if
channel_new()'s malloc() failed.

Signed-off-by: Christian Storm <christian.storm@siemens.com>
---
 suricatta/server_hawkbit.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c
index fdb7595..4f742eb 100644
--- a/suricatta/server_hawkbit.c
+++ b/suricatta/server_hawkbit.c
@@ -699,6 +699,8 @@  static size_t server_check_during_dwl(char  __attribute__ ((__unused__)) *stream
 	 * a connection parallel to the download
 	 */
 	channel_t *channel = channel_new();
+	if (!channel)
+		return ret;
 
 	if (channel->open(channel, &channel_data_defaults) != CHANNEL_OK) {
 		/*
@@ -953,6 +955,9 @@  static void *process_notification_thread(void *data)
 	 * used to download the SWU
 	 */
 	channel_t *channel = channel_new();
+	if (!channel)
+		return NULL;
+
 	if (channel->open(channel, &channel_data) != CHANNEL_OK) {
 		free(channel);
 		return NULL;