diff mbox series

Correct type of conversion of HEX .flags

Message ID 20211103133924.66866-1-bartel.eerdekens@constell8.be
State Accepted
Headers show
Series Correct type of conversion of HEX .flags | expand

Commit Message

Bartel Eerdekens Nov. 3, 2021, 1:39 p.m. UTC 
From: Bartel Eerdekens <bartel.eerdekens@constell8.be>

The attribute of the a hex flag is 'x' iso 'h'.
	The type attributes are:
		s - String (default)
		d - Decimal
		x - Hexadecimal
		b - Boolean ([1yYtT|0nNfF])
		i - IP address
		m - MAC address
It's correct though throughout the rest of the code.

Signed-off-by: Bartel Eerdekens <bartel.eerdekens@constell8.be>
---
 src/uboot_env.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bartel Eerdekens Nov. 15, 2021, 11:43 a.m. UTC | #1 
This is libubootenv btw.
Hopefully the patch applies correctly now? Sent with git send-email this 
time...

Op woensdag 3 november 2021 om 14:39:44 UTC+1 schreef 
bartel.e...@constell8.be:

> From: Bartel Eerdekens <bartel.e...@constell8.be>
>
> The attribute of the a hex flag is 'x' iso 'h'.
> The type attributes are:
> s - String (default)
> d - Decimal
> x - Hexadecimal
> b - Boolean ([1yYtT|0nNfF])
> i - IP address
> m - MAC address
> It's correct though throughout the rest of the code.
>
> Signed-off-by: Bartel Eerdekens <bartel.e...@constell8.be>
> ---
> src/uboot_env.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/uboot_env.c b/src/uboot_env.c
> index 223a300..af415c1 100644
> --- a/src/uboot_env.c
> +++ b/src/uboot_env.c
> @@ -94,7 +94,7 @@ static char attr_tostring(type_attribute a)
> case TYPE_ATTR_DECIMAL:
> return 'd';
> case TYPE_ATTR_HEX:
> - return 'h';
> + return 'x';
> case TYPE_ATTR_BOOL:
> return 'b';
> case TYPE_ATTR_IP:
> -- 
> 2.24.3 (Apple Git-128)
>
>
Stefano Babic Nov. 17, 2021, 10:53 a.m. UTC | #2 
On 03.11.21 14:39, bartel.eerdekens@constell8.be wrote:
> From: Bartel Eerdekens <bartel.eerdekens@constell8.be>
> 
> The attribute of the a hex flag is 'x' iso 'h'.
> 	The type attributes are:
> 		s - String (default)
> 		d - Decimal
> 		x - Hexadecimal
> 		b - Boolean ([1yYtT|0nNfF])
> 		i - IP address
> 		m - MAC address
> It's correct though throughout the rest of the code.
> 
> Signed-off-by: Bartel Eerdekens <bartel.eerdekens@constell8.be>
> ---
>   src/uboot_env.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/uboot_env.c b/src/uboot_env.c
> index 223a300..af415c1 100644
> --- a/src/uboot_env.c
> +++ b/src/uboot_env.c
> @@ -94,7 +94,7 @@ static char attr_tostring(type_attribute a)
>   	case TYPE_ATTR_DECIMAL:
>   		return 'd';
>   	case TYPE_ATTR_HEX:
> -		return 'h';
> +		return 'x';
>   	case TYPE_ATTR_BOOL:
>   		return 'b';
>   	case TYPE_ATTR_IP:
> 

Applied to -master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/src/uboot_env.c b/src/uboot_env.c
index 223a300..af415c1 100644
--- a/src/uboot_env.c
+++ b/src/uboot_env.c
@@ -94,7 +94,7 @@  static char attr_tostring(type_attribute a)
 	case TYPE_ATTR_DECIMAL:
 		return 'd';
 	case TYPE_ATTR_HEX:
-		return 'h';
+		return 'x';
 	case TYPE_ATTR_BOOL:
 		return 'b';
 	case TYPE_ATTR_IP: