[09/29] channel_curl: statify entry points functions

Message ID	20211011112156.44192-10-sbabic@denx.de
State	Changes Requested
Headers	show Return-Path: <swupdate+bncBCXPLOXJ6IKRB3V4SCFQMGQEFEGUT7Q@googlegroups.com> Sender: swupdate@googlegroups.com Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [PATCH 09/29] channel_curl: statify entry points functions Date: Mon, 11 Oct 2021 13:21:36 +0200 Message-Id: <20211011112156.44192-10-sbabic@denx.de> In-Reply-To: <20211011112156.44192-1-sbabic@denx.de> References: <20211011112156.44192-1-sbabic@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com
Series	DELTA Update \| expand [00/29] DELTA Update [01/29] Doc for delta update [02/29] Handlers: sort list of handlers in menuconfig [03/29] Add utility function to detect filesystem [04/29] util: add function to convert string to lowercase [05/29] Hide copyfile() implementation to add more input [06/29] Introduce copybuffer to copy from memory [07/29] Import small multipart library [08/29] Fix warning in multipart code [09/29] channel_curl: statify entry points functions [10/29] channel_curl: fix wrong usage of pointer in assert [11/29] channel_curl: do not automatically add charset header [12/29] curl: change signature of write data callback [13/29] curl: add a noipc parameter [14/29] channel_curl: pass channel_data to headers callback [15/29] channel_curl: allow an external callback for headers [16/29] channel_curl: add optional pointer for callbacks [17/29] channel_curl: pass channel pointer to internal callbacks [18/29] channel_curl: add the possibility to request a range [19/29] channel_curl: do not check download size if range requested [20/29] channel_curl: store HTTP return code before callbacks [21/29] Be sure to initialize channel_data_t by users [22/29] delta: add process to download chunks [23/29] tools: fix warning due to new SOURCE type [24/29] example: userid and groupid in case of downloader [25/29] Start chunks downloader if delta is enabled [26/29] delta: add handler for delta update [27/29] doc: add documentation for delta handler [28/29] doc: drop delta update from roadmap [29/29] delta: add the option to limit size for source

Message ID

20211011112156.44192-10-sbabic@denx.de

State

Changes Requested

Headers

Sender: swupdate@googlegroups.com
Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted
 nor denied by domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1;
From: Stefano Babic <sbabic@denx.de>
To: swupdate@googlegroups.com
Cc: Stefano Babic <sbabic@denx.de>
Subject: [swupdate] [PATCH 09/29] channel_curl: statify entry points functions
Date: Mon, 11 Oct 2021 13:21:36 +0200
Message-Id: <20211011112156.44192-10-sbabic@denx.de>
In-Reply-To: <20211011112156.44192-1-sbabic@denx.de>
References: <20211011112156.44192-1-sbabic@denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list swupdate@googlegroups.com;
 contact swupdate+owners@googlegroups.com

Series

DELTA Update | expand

Commit Message

Stefano Babic Oct. 11, 2021, 11:21 a.m. UTC

Functions are defined as part of a generic channel and initialized via a
channel_new() call. Scope can be set inside the module and not global.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 corelib/channel_curl.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/corelib/channel_curl.c b/corelib/channel_curl.c
index ff2053d..62009de 100644
--- a/corelib/channel_curl.c
+++ b/corelib/channel_curl.c
@@ -75,12 +75,12 @@  char *channel_get_redirect_url(channel_t *this);
 static void channel_log_effective_url(channel_t *this);
 
 /* Prototypes for "public" functions */
+static channel_op_res_t channel_close(channel_t *this);
+static channel_op_res_t channel_open(channel_t *this, void *cfg);
+static channel_op_res_t channel_get(channel_t *this, void *data);
+static channel_op_res_t channel_get_file(channel_t *this, void *data);
+static channel_op_res_t channel_put(channel_t *this, void *data);
 channel_op_res_t channel_curl_init(void);
-channel_op_res_t channel_close(channel_t *this);
-channel_op_res_t channel_open(channel_t *this, void *cfg);
-channel_op_res_t channel_get(channel_t *this, void *data);
-channel_op_res_t channel_get_file(channel_t *this, void *data);
-channel_op_res_t channel_put(channel_t *this, void *data);
 channel_t *channel_new(void);

[09/29] channel_curl: statify entry points functions

Commit Message

Patch