Message ID | 20210724150714.567177-2-festevam@gmail.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBDULZYNR2QMRBLWZ6CDQMGQE44MOVAA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::f3c; helo=mail-qv1-xf3c.google.com; envelope-from=swupdate+bncbdulzynr2qmrblwz6cdqmgqe44movaa@googlegroups.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=suheHOe0; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=XlQuHjPw; dkim-atps=neutral Received: from mail-qv1-xf3c.google.com (mail-qv1-xf3c.google.com [IPv6:2607:f8b0:4864:20::f3c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GX8gP3QHyz9sX1 for <incoming@patchwork.ozlabs.org>; Sun, 25 Jul 2021 01:07:29 +1000 (AEST) Received: by mail-qv1-xf3c.google.com with SMTP id ff14-20020a0562140bceb02902fc3fd31414sf3565850qvb.16 for <incoming@patchwork.ozlabs.org>; Sat, 24 Jul 2021 08:07:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1627139247; cv=pass; d=google.com; s=arc-20160816; b=sf1fHX/7Bi2ze/ceyOEEZFzL+e9kcNsaPumQ/a3yq18ZtmLUQ5fkhDpM//6o0BtuPu u3DT+qU56WjZqvuBUKLaadb7i+/JaKbabr53FPpiz6Uifp6OqGWhS1VESle/ZuNbuEGt yLYRS8IwU5P7ozHUndgAscEcdBIKwG7GuuCPT3BF3Thlscc+XzcY1UaAh6jdYbd9mXo4 TRQZCFKUMMBjHquef+V2h/7NqH9DpF5ldPccq3ce2cTVNpnKVK2DM4ZgYHUUpmFqFrG6 ScfN5a+Z4u7MypYwmpQDmCIhTWkmFM057kY48eiMII9TykqY/Rkt22aMxmP4X7vrqcQX Ao+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature :dkim-signature; bh=NJ+vLEEoVdKfvXRNEQzD/ToiDLQvu0SUd10L+V85hkY=; b=btKOsMcYQM97f6wNVHVk4oNpE9t2/t9CCrTGgzYC0rQAW28VWaf/DW1eMHf7pmTd82 4dWNoU4Ww+JHsgaVffdilTrPm5iqo+A5sZsKkDLtRRx/iJxLnhsubyBjEjIIM394DREE Jj28iTRzYxd1Rt8TdY5BP7BmQpvxZcp7Y7LlmKbMIT+XMTbWwHEo7iO2rPDU4zgPUBry XVDqngwj5zZnrk8K04nIuzMNelb9KMV/Rf24w7PuS0MIf2TQcfjn2DR94Ziv36okK2x6 C9bdJ2ZE+T9gZis8CKFjnWlM7aNq4YFhuN/qlD1i+FDYIAkOBe4M5xUq3f9GgyVsZabW yBgw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FuM16JVs; spf=pass (google.com: domain of festevam@gmail.com designates 2607:f8b0:4864:20::62f as permitted sender) smtp.mailfrom=festevam@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=NJ+vLEEoVdKfvXRNEQzD/ToiDLQvu0SUd10L+V85hkY=; b=suheHOe0Z3C9KuG2+HWN1CDqRoAyF9wrHWkygoy0bLEBqCtdJKUj0iSSCUV/8C9iaH HH3rf/nEx87v0KmKq+S6C+Y5EKs7MxmnikadTqor3zI+4eV9Rpmsfp1Zq1jupfCqr5g4 B1XUn29y1jt1iQ/+iReq7VjeJIDo1e2zLWO3EVGoWaW7ygGPtuRVO5X+5LwvdLP+mwNU 3fsbWfTXkS0tMlsevbHPV/gG7X9zFQi+Pu+F6gkt/46cB7dx5q26sXO4euoa/P3UP1SZ 8pYhMdGud2UmHfceUB0h3qPkqM976xf926OLHbcEKVOJ5oSNssWri/Ecqbs/3+g1grn5 83lQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=NJ+vLEEoVdKfvXRNEQzD/ToiDLQvu0SUd10L+V85hkY=; b=XlQuHjPwexHiK0VaK6KPKM9cw6+o/gBmvgDxviJBTJvswW6T/er1r5J8Y3edfbnl5J G9jKZzDnibNtrIqH575F4PzTgJTqDQAKHlDI15WiCUU+tvUFiPcmvWgJ2amk5Pv1V7M/ +w4c1mEGfqxDiynKluRY00J5M2ZuR57JywOXv7c1RZXMzk7bcpldLyXi4cd9o1WQggv9 324z0HRMgtLCiIOBD0/JGklbv6stDhy+tzwDC914gWmtXvNcAKDv6Vr1epxj1UvRc4c/ 24+YjxLhPJcllHZIAozaAMAUZ8UOEguUp57BvEc3QRhak9OuUAzG3EFZ5mcmX0I8cijY GLgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=NJ+vLEEoVdKfvXRNEQzD/ToiDLQvu0SUd10L+V85hkY=; b=o9fQge+D+TCwAzeghuBmGsjq+5l+IiJgoGsXTuHnnmtOz9avk4XG58+6hTnnEz+zOj 3NfBp5KbM0dYnnqJDnx1pnC+XYqczEBoAfE2yISNI1J01oEeA6QqJ8nHxiiUMIeB+BEp 2d8muSLojoBt8Fvq2nolPd7llM8a7fazaRK1XUzOg2MaE8dXxPPHzssp8CsRgP0+Ps49 gKWXaYb2cPo8JxnEW5Pe46zRd8b81oiY0jqP1ZF+oqrBpGJgCGsNVF5YSQJVIf9RYejH 3Yn/c5Zr2/w+GhaRkY4dI+evofF5dLNfcHgIM5CHNKsG5+YgZsC+Gg4RozJ0A9QLnWC0 6ykw== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM531C0ELvZdssAkx3D+mspq4e7U0AkfDX7wNyoZjVPzP9u6hWpC8q dGnr+Hq4XK+dnKWwckdqvJQ= X-Google-Smtp-Source: ABdhPJxv0E6F5eNFXiywDk76+f8MM0z0QYGb0P+ckraxd9C7zA5iWs2LE03HJf1nosIiwq3GGG2oQA== X-Received: by 2002:a05:620a:a5a:: with SMTP id j26mr9886281qka.42.1627139247057; Sat, 24 Jul 2021 08:07:27 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:620a:2485:: with SMTP id i5ls8986935qkn.2.gmail; Sat, 24 Jul 2021 08:07:26 -0700 (PDT) X-Received: by 2002:ae9:e30d:: with SMTP id v13mr9844983qkf.332.1627139246702; Sat, 24 Jul 2021 08:07:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627139246; cv=none; d=google.com; s=arc-20160816; b=nhKVdyWNHmd9StcAYR0KdFAqmvyBj5N/u+zOxCZAPsjgj7O7BRno/8+/0eMPp6XYZi yOhKUd2y1c2FeLxOu7abNF/ZdcrYCOu32WX6p/l+CcJv0fAAaZ+20Lc5oFh8NkvWD66L /CXioDJveGIB9wTj9OyaM4cY63NRyH9rJT2qV/jpddMJASzvmVHr/b/pc7a4HB6DsQbq MtYUt56m8dzjXxV9623mJBxtY/E/qMeLyuZfvrqC61JxX3HN0W3dDXPR4ycAScB/7FpC 203wB7V3PAsQ+M1xJ2TvjmiW8NXykXUEqhqAfJdVdJpY6PzxfZQbWWX5tv2OOvqFQimU Ta/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=IGYCbxQzUMAd4W9uDAEYljg4Gp+16hmBJ4we3QuS8Kc=; b=RPniPeYuNxk8+nqS/WVG1hZMELgIle7UawujrXMOk9cJo/h/Bg2xNjlZ61KnEQy87J z1TwQf8a+1CrE0qaiT3/w2XkpwotYFRqB/4ZOPlef9eGCVNPsC3YJTKGYIO0H6uyRCQm mSpDv3ayTIrooo7qU21X/Hvt2x1qgHmbPW7Q8gmfbHe/lg+dx2/lNwrXa3zo0oWdUEOf sfRGmbPM3dHAj3/dv4rKnh0MyZuRk64E92RyP9Q5vYP+zr9aTEJlgKkQWq7neeinlIiE v8dAih/C2VEDMvLlO55XHKY540sQTxBepSJ/uLVDABdtJ/B3kpv4etATsJirCrwwwbd+ 0i7g== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FuM16JVs; spf=pass (google.com: domain of festevam@gmail.com designates 2607:f8b0:4864:20::62f as permitted sender) smtp.mailfrom=festevam@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com. [2607:f8b0:4864:20::62f]) by gmr-mx.google.com with ESMTPS id f10si2950084qkm.7.2021.07.24.08.07.26 for <swupdate@googlegroups.com> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jul 2021 08:07:26 -0700 (PDT) Received-SPF: pass (google.com: domain of festevam@gmail.com designates 2607:f8b0:4864:20::62f as permitted sender) client-ip=2607:f8b0:4864:20::62f; Received: by mail-pl1-x62f.google.com with SMTP id k1so6419999plt.12 for <swupdate@googlegroups.com>; Sat, 24 Jul 2021 08:07:26 -0700 (PDT) X-Received: by 2002:aa7:9216:0:b029:2e5:6989:4f1a with SMTP id 22-20020aa792160000b02902e569894f1amr9498967pfo.50.1627139245586; Sat, 24 Jul 2021 08:07:25 -0700 (PDT) Received: from localhost.localdomain ([2804:431:d77f:26f1:1bce:1fc6:1476:4c5f]) by smtp.gmail.com with ESMTPSA id u16sm41783477pgh.53.2021.07.24.08.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 08:07:25 -0700 (PDT) From: Fabio Estevam <festevam@gmail.com> To: swupdate@googlegroups.com Cc: sbabic@denx.de, Fabio Estevam <festevam@gmail.com> Subject: [swupdate] [PATCH 2/3] boot_handler: Check for openfileoutput() failure Date: Sat, 24 Jul 2021 12:07:13 -0300 Message-Id: <20210724150714.567177-2-festevam@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210724150714.567177-1-festevam@gmail.com> References: <20210724150714.567177-1-festevam@gmail.com> MIME-Version: 1.0 X-Original-Sender: festevam@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FuM16JVs; spf=pass (google.com: domain of festevam@gmail.com designates 2607:f8b0:4864:20::62f as permitted sender) smtp.mailfrom=festevam@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
None
|
expand
|
diff --git a/handlers/boot_handler.c b/handlers/boot_handler.c index 4e14135cc0a7..e476c41db928 100644 --- a/handlers/boot_handler.c +++ b/handlers/boot_handler.c @@ -48,6 +48,8 @@ static int install_boot_environment(struct img_type *img, ret = stat(filename, &statbuf); if (ret) { fdout = openfileoutput(filename); + if (fdout < 0) + return fdout; ret = copyimage(&fdout, img, NULL); close(fdout); }
openfileoutput() may fail, so check its return value and propagate it in the case of failure. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- handlers/boot_handler.c | 2 ++ 1 file changed, 2 insertions(+)