From patchwork Sat Jul 10 13:10:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Hilliard X-Patchwork-Id: 1503470 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::439; helo=mail-pf1-x439.google.com; envelope-from=swupdate+bncbcl4hcw73qcbbnfyu2dqmgqe2leuloa@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=JsBpcYOZ; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=rXLYIzcV; dkim-atps=neutral Received: from mail-pf1-x439.google.com (mail-pf1-x439.google.com [IPv6:2607:f8b0:4864:20::439]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GMVkc3xM8z9t1r for ; Sat, 10 Jul 2021 23:10:15 +1000 (AEST) Received: by mail-pf1-x439.google.com with SMTP id d22-20020a056a0024d6b0290304cbae6fdcsf8538564pfv.21 for ; Sat, 10 Jul 2021 06:10:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1625922612; cv=pass; d=google.com; s=arc-20160816; b=Pt1CRsYqC1231N2Lufpt/Q5B+rd8riZJ3PSFo7S5XYLorj74vxRr62FylKKgRU8yra qI1GWUbHLZybS+tLwE+tnmTdmZqbBxK93GoPN9tkj6Z/opmCWWSA0vdB/e4JxSOOpHJ+ N3CftWeswVDSVb81PF81aSEibbw5XhPFdimslFMyxZr+cfXYkMAITgPSTwfWgkSYv5GS XbXR1aOje4bo5RvyOnfApNzh+hNCnXR+YwZZE0j3PtlZyQkgMjFk1UMaC9vbpfVHa0/9 0Qsy3sRyGVPIdXGNWw/hmtj6EYer9l4bv5TShLnneZKL/tjbN8AchSlxHwu/p5v82Cys fmYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature:dkim-signature; bh=pNguYUXfkCLMK0xFHAx0znRUGehr+J3H2ac8KqX9OME=; b=eTmorMKAj4KBI1EHY6AqSOWCrT9MBOXYtxPmXdWYoTFW5bOsrXyTmCrztZ3UkJMwBR j1VcS32wOX9sRMDmrCjcInETC2gtXEaKdFDqBeEoJgBFQiPypyKRlXDrqx8IUjRztIkg 7GzHYKg3qUtDO60AbARkVfxZcd/5H/gGo7+qOovsdb5OoC9dsOUgdOTnmjLXzPKBgOvF ZBFL5YtqI5A/7adBpmHRYOH3HqM7N6FuavBs0KzcbSTjkT96ZA7YyNeza1yglshUPtbA 6nLJ++qxa8WhD+jzhIksf3XaKcA/e/Bh+DkncRuWuK4hlhTHwlbmQBUshYHgtlq/aj4H J7mA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=df0h90xJ; spf=pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::32c as permitted sender) smtp.mailfrom=james.hilliard1@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=pNguYUXfkCLMK0xFHAx0znRUGehr+J3H2ac8KqX9OME=; b=JsBpcYOZvf3bm0+2EdaYQJ6vf/UkhKCGIDjC2sYle/7nnkjQgdSlGbRSCCR0hHG2H8 g2YG/pqP7uGS7WW8EECihj36B3gnt8w5fU+MhHCWe8qgSVDA81sg2941CfEGGsVdkd/Z 4qCzuEJBt4EVYIHAomZBsoG2ypaDNr1iAum5vtONjPj03k3E8aBaqc3Dir7iyYqXVDI9 R0vFfhEHF7GWdpsGPdDxAjgES3VeVBFPozEeXrA/opTP7jvfQP7cqsXUUI6YAh1OxdMb Tjrf5sPV3mgt4jp9xlYwbjnoKskllfVnmBLYDko9sitE632HE23QVvk0SbWtsuM9wXEI rIRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=pNguYUXfkCLMK0xFHAx0znRUGehr+J3H2ac8KqX9OME=; b=rXLYIzcV5SxqQqFeJbgifF52u5WjSttGFCbtxb7DgqfcutUA9wDj427LNrP7m8eICW VvzdEon81Qe8Q4QrtlPpqb3yOdhLz+Jjj9WUqBrKUHRd8eQjbb4+DnvSRquP/YrRFOG/ 18YPr/HbMhYtfejPGn8uP249tExYOi8/kzVjlbiZStA3IGifuDpggrIqDlZM6CB5umYG 3WgMueErD1WugackSrFZ1j1NCRg/8r15xY/r3LLd1npiaMQXLJChyp9ImNVgxKH3mMYE Mfh88sr7XR/sHFFY+Fqdw+0UQR5ciPg6MxKNjJQQUMLTuhOM1HR/3Z9RK3IIYS4yHIyL CYzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=pNguYUXfkCLMK0xFHAx0znRUGehr+J3H2ac8KqX9OME=; b=CxN/zwyTHW3Qt1T4XE5w3CmvV08UvBqN35t632ONJoUjyIf8pgX2SdwI8IGDZX3g26 KkjricB0884bYvQhNLm/xnbUyzU4jD9MyOmVcIcV/4qRQSImNuon6JemBesez5s9CZOz ZpXkAZlIkBllxyDTPiYY/cTnbOBf1UUdmGI6Eq3gSFJn5/W2WxgWeeuGr//2WOj1A2Jz JXxausXc3CdW4sj9RbPP6a9f9s1GzYuNI7MywISUm3mLyHgep0rUxoVEAuRvNyzT3NOW ZCl15qdvMwMyJLRvjvocO/eKL6QoW1SsXJfkTt/HBIswBcTR3JYxH9TUiE6udAhLsjdN GN9A== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM5335b+c8ib9UCoIrsk8o3VmYTgGWjvMFoxAaMOYWDkwtCg7nvCVM TwGXcis7FOewSuoGkavJRkI= X-Google-Smtp-Source: ABdhPJzc/fZnrrs464aZhohSxjLE53RvSYv9CDEcUenF2nUdIY7lmd9u+OmuYsjVTuwk0TxyU2WzFw== X-Received: by 2002:a17:90a:3d47:: with SMTP id o7mr4414632pjf.68.1625922612453; Sat, 10 Jul 2021 06:10:12 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a17:90a:6fc4:: with SMTP id e62ls5073553pjk.0.gmail; Sat, 10 Jul 2021 06:10:11 -0700 (PDT) X-Received: by 2002:a17:90a:9411:: with SMTP id r17mr43389976pjo.49.1625922611745; Sat, 10 Jul 2021 06:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625922611; cv=none; d=google.com; s=arc-20160816; b=ycKozyUhAmBLlmaTj25iRdj8XvvPYXswBPwCdY8ETQ6B42AibudO9bBzo1Pgfk8RdX dey/CDkfcGCgAu/Fuj2wfB5FkIrvy4qk0XE8qdtViF+KSb2k9vY8KdWqdS711jjhH5Wq xC95k4qOI9K8vRoCf2CAliE1dPVgpGa+GqDwTT2t0Jb4pTbEpWhY0am7gCUbxxRk93sH pZIUfcAyH22x460BbXe2+ChmE3s19/ZmAEBK7ySl0veJRNdXzV1erOzPHtxuAUhlspXA 2Pkwa/D/8+Fzw+NZmk6MbHkagOIOGLGXN5Ye5bjTj51GmTHK88EsXgqFdD0bmkotiJLX fmWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=eQY51W6yUWyk39IjWbB3kbICq1dajTqbkW0IdpzkPj0=; b=mEl3VFph8c1N8IpCajlu863TjYvUIbTZ4CoV3PmrM1HEcWk297zr/vtEjrem+55N4m GuJrAvvavXm7XoAaXQkmsqwZdyDvSxEsbvQA15ofXjJnB5p/4gBu5joCrgujXKmiSdrN H62hm6BWn0BmSPgbqALXU1OmELGXFP9reYDAgCt6jIWRaDFJcjppSvb0g3gEztcj71yZ FUhLYbQ1jnePtLWxQBRdAp9ha6Uwt1g4SK+DxtY3jIvKGl86TxN1fKzAcmzk7DxHQD9s gOZOT9KW0E0M2FDoTI1mvymRIKXMX8k0w9ZGLJPKPK1NYVX8MaMSUR0ymOpD5h6Qq0/G p80Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=df0h90xJ; spf=pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::32c as permitted sender) smtp.mailfrom=james.hilliard1@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com. [2607:f8b0:4864:20::32c]) by gmr-mx.google.com with ESMTPS id t1si1329152pgj.4.2021.07.10.06.10.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Jul 2021 06:10:11 -0700 (PDT) Received-SPF: pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::32c as permitted sender) client-ip=2607:f8b0:4864:20::32c; Received: by mail-ot1-x32c.google.com with SMTP id w8-20020a0568304108b02904b3da3d49e5so8611970ott.1 for ; Sat, 10 Jul 2021 06:10:11 -0700 (PDT) X-Received: by 2002:a9d:7f0d:: with SMTP id j13mr9383699otq.322.1625922610889; Sat, 10 Jul 2021 06:10:10 -0700 (PDT) Received: from MacBook-Pro-2.localdomain (97-118-178-184.hlrn.qwest.net. [97.118.178.184]) by smtp.gmail.com with ESMTPSA id k24sm1883936oig.13.2021.07.10.06.10.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jul 2021 06:10:10 -0700 (PDT) From: James Hilliard To: swupdate@googlegroups.com Cc: James Hilliard Subject: [swupdate] [PATCH 1/1] Lua: Ignore EROFS errors in lua umount. Date: Sat, 10 Jul 2021 07:10:01 -0600 Message-Id: <20210710131001.6165-1-james.hilliard1@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: james.hilliard1@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=df0h90xJ; spf=pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::32c as permitted sender) smtp.mailfrom=james.hilliard1@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , It's expected that one can't delete a directory on a read only filesystem, don't consider umount to have failed if that is the only error. Signed-off-by: James Hilliard --- corelib/lua_interface.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/corelib/lua_interface.c b/corelib/lua_interface.c index 86e95bd..a6da6f2 100644 --- a/corelib/lua_interface.c +++ b/corelib/lua_interface.c @@ -793,8 +793,10 @@ static int l_umount(lua_State *L) { } if (rmdir(target) == -1) { - TRACE("Unable to remove directory %s: %s", target, strerror(errno)); - goto l_umount_exit; + if (errno != EROFS) { + TRACE("Unable to remove directory %s: %s", target, strerror(errno)); + goto l_umount_exit; + } } lua_pop(L, 1);