From patchwork Tue Jul 6 18:00:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francis Laniel X-Patchwork-Id: 1501437 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::43e; helo=mail-wr1-x43e.google.com; envelope-from=swupdate+bncbdnphdvbz4jbbufuskdqmgqey2fvgea@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=FUSB9vHz; dkim-atps=neutral Received: from mail-wr1-x43e.google.com (mail-wr1-x43e.google.com [IPv6:2a00:1450:4864:20::43e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GK9Mq0fv1z9sXM for ; Wed, 7 Jul 2021 04:00:54 +1000 (AEST) Received: by mail-wr1-x43e.google.com with SMTP id y5-20020adfe6c50000b02901258bf1d760sf7443549wrm.14 for ; Tue, 06 Jul 2021 11:00:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1625594448; cv=pass; d=google.com; s=arc-20160816; b=hG0g4eiokXsrFGaxq3OxZBXWkCXwe1U95L7s2gZnE9B/SniHsX2jc6U4V56U3Lb2yn C3/WRcXmh6QU3M3UwtpqdgDHglj5zGjFTCUP/F+/yTNPWXU9XOgmY4usZdgiQywNFHZQ mIM8QXflo3tYXXp9JTlIm/jadBJk0st2s1G0Cxn9BmlBebIARGytOPrxQFV29uSn9FWq G7R8jwIM+PqSOAiSP0HiQXMzB1xxSW3Deyw7siI6owR+3EpZjX+QItPMz8MruYh8OZ7l KJmh3YREOYn27loofhqrscoUCa506cJWCNhB6dkVG3V0Iob1yrnYN8003DSU/a9p2MGu EhSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=8Sv1ktlImEZNbKsc0Gq4854T70CbXfzSeydM7MhvDDE=; b=AmHJxmt2mfRLRiELY5/wYcQ8ZzjyuOAe9ydNrrFBXirzkF+Ba6KusTAYSWuYAhio6+ ZFpSofFPiRlhG3bxYMIeku6Jea3HljMb1dzqXL95K0nawIRicxWSdfwWlW4kcX9UgY48 czwPyHOnBLQW1UvcNhd1U7l5SIjuWGhMe23Q3iPGq6ZDcn/7SCtSq4GsFrUD/aS47Idw mUAHp6coyTY4j79c8R2u8S+tfPIQGYsJc2BoOaOcqrrxaxCpSiDcmBCyP+0t3xDf4GrX ncTpxXf1Cn4mayFR+tv+Oa4awOcvfLdnyjAxPMNTNEtTn53dPW9oXIgRKqXGTw2W8JEc wiVg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Iw/AI8KV"; spf=pass (google.com: domain of francis.laniel@amarulasolutions.com designates 2a00:1450:4864:20::429 as permitted sender) smtp.mailfrom=francis.laniel@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=8Sv1ktlImEZNbKsc0Gq4854T70CbXfzSeydM7MhvDDE=; b=FUSB9vHzmW80tYwZh8F2h8Kh8HkBW/Ou80IPLiZmrKAXNeNVElUP5Ftf+5e3ndMtZ3 C7VeqsMi4Ey4irPjBFZ/VGuFl9i9CVUsEzXQJp0KKRBVrMVmQi0/8YC7tY3JMYBO3ATe zT8Z338d3sWnx+fTWJOWMLIU09ToM+ea1iLxzIIGdbq03n7TKB0CLTarNiwmS3BZwhZr uonRf6RNhMBmev9QapQ8VJxYgGDZtkkyHEX27cbNqmdZntw1Ze80EqZHKzm4jt79kkB4 dig/uOTjgojIqHp9Dgb08RFvLQ/QSg29IweqgkcoRDVAbtKY9HvzB5leJlAdXPvHSmJW kQ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=8Sv1ktlImEZNbKsc0Gq4854T70CbXfzSeydM7MhvDDE=; b=TiO5/daIgF7RIqpRfIksMjvVWMsrzk1/SnkfCSvfm8eSDpMG6qNNDnc7aBNDMCMUup 9Kr7+lHDmH8Bod5fyLt9ufu84pP0fzPIEXZpt0+Xt7eAdWOAN46tuEaz6rMiSv+VvWba 18SADpocv5oegQrT/NqDUbHuBytvclna0kIK5XGx3dciHjohymJefOCQ6cgkRITQxpii ZpF02M6Yip5czQwoFW6OZJYsGa0L2Tdj9D4shxkmHH7F7VkYgNZ1vpATwJAXe0sE9d4/ Xwd6g9PjcQj2t/E+ft9S0pSF86FmPn9JM92xsZMmGD6c80uGwnZrCqmAHefx5quxzeJl e7cA== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM531h5RQbFzZ3Zt9W99Yen0+nj5RdMuE01CypnimNYCb5xTzOcYg+ X88DnVAJBA0YSEtWXfVdbI0= X-Google-Smtp-Source: ABdhPJxTNundtnXsOovs4kSi1XLBc1SCtmNUiejzq5NTlockKFa/CM7vBwdISWuyaejvoPhcMrCMuQ== X-Received: by 2002:a05:600c:a45:: with SMTP id c5mr2194963wmq.153.1625594448638; Tue, 06 Jul 2021 11:00:48 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:adf:a141:: with SMTP id r1ls276969wrr.3.gmail; Tue, 06 Jul 2021 11:00:47 -0700 (PDT) X-Received: by 2002:a5d:4dd0:: with SMTP id f16mr22491984wru.44.1625594447723; Tue, 06 Jul 2021 11:00:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625594447; cv=none; d=google.com; s=arc-20160816; b=t/k22tHSrN9p1nWIwLAcmQ2nN2f6HztgoEQdAkwjT5fCeLj0Vm/nSpUBxJi2m2AKUj LL061VBwAZw+amLdG963NO+ePz88tC3JTpDiX4jsmpBvnWk+Szl82SF4onPhTPyI/frJ OmEXPgI/n5SJnnCZwmR6edRRSxllLvPpnIiSsEvxF0tExkl6KiyMRm3ISpcWb3WWxZvD H0eL3iRsjLfx9rkQdARIR1+mscmEOHO38ZPuW/Yw9kyFcO/sHCUtVOi9XaACSWFXPyZ1 EkLvjwftM1jg4oHXtNIixhuQkV5cYpjrOtavEy+bgMxS52aVHKG6e3nQzzlJ9Y+8LNA1 GNzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=xZzj5uR+EWLgl+4KLy6NC0F70jFy//xlWZnSWssPk0Q=; b=YF376w97r82eu6UNH/+T5Be7pLgFj8nG8vanzoISUYwRnSIC6vUW78yAcDYPHkJYVP g0d3cKKaz0iK9iDXw+U4faL9IyJaDF/v5NMYFe4QDzIQmHZC2gUtK5Tiv9DdtNQ5ewDw CYEBf7s4SEYYvc+gxY+qgdq0tr336MeyaPtMSOIv6uOs+cWeiJ6EFV/oUblKrVN+pmFj fq9u+WUHrmLGlC98zVpuyU80Tjpbcntoy8C884oUglHKixmI4Y/6TvEUnBSG0+QqqJUM u16+Z57JWHxtsCS/1PKRpxzF4KI3pxWPlK4TATAMqDx8vwT9UybiMmQ27fGmNBRo3XRF pWNQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Iw/AI8KV"; spf=pass (google.com: domain of francis.laniel@amarulasolutions.com designates 2a00:1450:4864:20::429 as permitted sender) smtp.mailfrom=francis.laniel@amarulasolutions.com Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com. [2a00:1450:4864:20::429]) by gmr-mx.google.com with ESMTPS id g22si197875wmh.0.2021.07.06.11.00.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 11:00:47 -0700 (PDT) Received-SPF: pass (google.com: domain of francis.laniel@amarulasolutions.com designates 2a00:1450:4864:20::429 as permitted sender) client-ip=2a00:1450:4864:20::429; Received: by mail-wr1-x429.google.com with SMTP id t6so17158244wrm.9 for ; Tue, 06 Jul 2021 11:00:47 -0700 (PDT) X-Received: by 2002:a5d:5985:: with SMTP id n5mr17329337wri.63.1625594447493; Tue, 06 Jul 2021 11:00:47 -0700 (PDT) Received: from pwmachine.home ([2a01:cb14:983:1f00:9e94:185:dd8d:7317]) by smtp.gmail.com with ESMTPSA id o8sm15838573wrx.28.2021.07.06.11.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 11:00:46 -0700 (PDT) From: Francis Laniel To: swupdate@googlegroups.com, sbabic@denx.de Cc: michael@amarulasolutions.com, ondrej@amarulasolutions.com, Francis Laniel Subject: [swupdate] [RFC PATCH v2 1/3] main: Check libuboot_set_env() result. Date: Tue, 6 Jul 2021 20:00:16 +0200 Message-Id: <20210706180018.342553-2-francis.laniel@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210706180018.342553-1-francis.laniel@amarulasolutions.com> References: <20210706180018.342553-1-francis.laniel@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: francis.laniel@amarulasolutions.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Iw/AI8KV"; spf=pass (google.com: domain of francis.laniel@amarulasolutions.com designates 2a00:1450:4864:20::429 as permitted sender) smtp.mailfrom=francis.laniel@amarulasolutions.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , If function failed, an error message is printed with returned error code. Signed-off-by: Francis Laniel --- src/fw_printenv.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/fw_printenv.c b/src/fw_printenv.c index bf9951b..436b8fb 100644 --- a/src/fw_printenv.c +++ b/src/fw_printenv.c @@ -167,12 +167,26 @@ int main (int argc, char **argv) { value = libuboot_get_env(ctx, argv[i]); if (i + 1 == argc) { if (value != NULL) { - libuboot_set_env(ctx, argv[i], NULL); + int ret; + + ret = libuboot_set_env(ctx, argv[i], NULL); + if (ret) { + fprintf(stderr, "libuboot_set_env failed: %d\n", ret); + exit(-ret); + } + need_store = true; } } else { if (value == NULL || strcmp(value, argv[i+1]) != 0) { - libuboot_set_env(ctx, argv[i], argv[i+1]); + int ret; + + ret = libuboot_set_env(ctx, argv[i], argv[i+1]); + if (ret) { + fprintf(stderr, "libuboot_set_env failed: %d\n", ret); + exit(-ret); + } + need_store = true; } }