diff mbox series

[v2] correct missing goto in swuforward_handler causing curl failure to be overwritten as successful

Message ID 20210621135148.12333-1-mike@baseforsale.com
State Accepted
Headers show
Series [v2] correct missing goto in swuforward_handler causing curl failure to be overwritten as successful | expand

Commit Message

Michael Donahoe June 21, 2021, 1:51 p.m. UTC 
Signed-off-by: Michael Donahoe <mike@baseforsale.com>
---
 handlers/swuforward_handler.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Babic June 21, 2021, 2:05 p.m. UTC | #1 
On 21.06.21 15:51, Michael Donahoe wrote:
> Signed-off-by: Michael Donahoe <mike@baseforsale.com>
> ---
>   handlers/swuforward_handler.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/handlers/swuforward_handler.c b/handlers/swuforward_handler.c
> index c9df541..3135afc 100644
> --- a/handlers/swuforward_handler.c
> +++ b/handlers/swuforward_handler.c
> @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p)
>   		ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, curlrc,
>   		      curl_easy_strerror(curlrc));
>   		conn->exitval = FAILURE;
> +		goto curl_thread_exit;
>   	}
>   
>   	conn->exitval = SUCCESS;
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/handlers/swuforward_handler.c b/handlers/swuforward_handler.c
index c9df541..3135afc 100644
--- a/handlers/swuforward_handler.c
+++ b/handlers/swuforward_handler.c
@@ -211,6 +211,7 @@  static void *curl_transfer_thread(void *p)
 		ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, curlrc,
 		      curl_easy_strerror(curlrc));
 		conn->exitval = FAILURE;
+		goto curl_thread_exit;
 	}
 
 	conn->exitval = SUCCESS;