| Message ID | 20210619163710.182921-1-mike@baseforsale.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | correct missing goto in swuforward_handler causing curl failure to be overwritten as successful | expand |
On 19.06.21 18:37, Michael Donahoe wrote: > --- > handlers/swuforward_handler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/handlers/swuforward_handler.c b/handlers/swuforward_handler.c > index c9df541..3135afc 100644 > --- a/handlers/swuforward_handler.c > +++ b/handlers/swuforward_handler.c > @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p) > ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, curlrc, > curl_easy_strerror(curlrc)); > conn->exitval = FAILURE; > + goto curl_thread_exit; > } > > conn->exitval = SUCCESS; > Patch is correct, but your Signed-off-by is missing. Please add it. Best regards, Stefano Babic
On 6/21/21 5:13 AM, Stefano Babic wrote: > On 19.06.21 18:37, Michael Donahoe wrote: >> --- >> handlers/swuforward_handler.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/handlers/swuforward_handler.c >> b/handlers/swuforward_handler.c >> index c9df541..3135afc 100644 >> --- a/handlers/swuforward_handler.c >> +++ b/handlers/swuforward_handler.c >> @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p) >> ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, >> curlrc, >> curl_easy_strerror(curlrc)); >> conn->exitval = FAILURE; >> + goto curl_thread_exit; >> } >> conn->exitval = SUCCESS; >> > > Patch is correct, but your Signed-off-by is missing. Please add it. > > Best regards, > Stefano Babic > Signed-off-by: Michael Donahoe <mike@baseforsale.com> --- handlers/swuforward_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/handlers/swuforward_handler.c b/handlers/swuforward_handler.c index c9df541..3135afc 100644 --- a/handlers/swuforward_handler.c +++ b/handlers/swuforward_handler.c @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p) ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, curlrc, curl_easy_strerror(curlrc)); conn->exitval = FAILURE; + goto curl_thread_exit; } conn->exitval = SUCCESS;
On 21.06.21 14:15, Michael Donahoe wrote: > On 6/21/21 5:13 AM, Stefano Babic wrote: >> On 19.06.21 18:37, Michael Donahoe wrote: >>> --- >>> handlers/swuforward_handler.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/handlers/swuforward_handler.c >>> b/handlers/swuforward_handler.c >>> index c9df541..3135afc 100644 >>> --- a/handlers/swuforward_handler.c >>> +++ b/handlers/swuforward_handler.c >>> @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p) >>> ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, >>> curlrc, >>> curl_easy_strerror(curlrc)); >>> conn->exitval = FAILURE; >>> + goto curl_thread_exit; >>> } >>> conn->exitval = SUCCESS; >>> >> >> Patch is correct, but your Signed-off-by is missing. Please add it. >> >> Best regards, >> Stefano Babic >> > Signed-off-by: Michael Donahoe <mike@baseforsale.com> > --- > handlers/swuforward_handler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/handlers/swuforward_handler.c b/handlers/swuforward_handler.c > index c9df541..3135afc 100644 > --- a/handlers/swuforward_handler.c > +++ b/handlers/swuforward_handler.c > @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p) > ERROR("SWU transfer to %s failed (%d) : '%s'", > conn->url, curlrc, > curl_easy_strerror(curlrc)); > conn->exitval = FAILURE; > + goto curl_thread_exit; > } > > conn->exitval = SUCCESS; No, this is wrong - you have to reissue the patch with Signed-off-by. What you added here is just a comment, and it won't be taken by Patchwork. See: http://patchwork.ozlabs.org/project/swupdate/patch/20210619163710.182921-1-mike@baseforsale.com/ You have to send a V2 version of the patch. Best regards, Stefano Babic
diff --git a/handlers/swuforward_handler.c b/handlers/swuforward_handler.c index c9df541..3135afc 100644 --- a/handlers/swuforward_handler.c +++ b/handlers/swuforward_handler.c @@ -211,6 +211,7 @@ static void *curl_transfer_thread(void *p) ERROR("SWU transfer to %s failed (%d) : '%s'", conn->url, curlrc, curl_easy_strerror(curlrc)); conn->exitval = FAILURE; + goto curl_thread_exit; } conn->exitval = SUCCESS;