diff mbox series

[meta-swupdate] Fix broken LIC_FILES_CHKSUM

Message ID 20210502111929.25402-1-llewellyn.fernandes@evologics.de
State New
Headers show
Series [meta-swupdate] Fix broken LIC_FILES_CHKSUM | expand

Commit Message

llewellyn Fernandes May 2, 2021, 11:19 a.m. UTC
Signed-off-by: LLewellyn Fernandes <llewellyn.fernandes@evologics.de>
---
 recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Stefano Babic May 3, 2021, 4:12 p.m. UTC | #1
Hi LLewellyn,

On 02.05.21 13:19, LLewellyn Fernandes wrote:
> Signed-off-by: LLewellyn Fernandes <llewellyn.fernandes@evologics.de>
> ---
>   recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/recipes-support/swupdate/swupdate_2020.11.bb b/recipes-support/swupdate/swupdate_2020.11.bb
> index 515ee88..8ba832f 100644
> --- a/recipes-support/swupdate/swupdate_2020.11.bb
> +++ b/recipes-support/swupdate/swupdate_2020.11.bb
> @@ -1,3 +1,8 @@
>   require swupdate.inc
>   
>   SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
> +                    file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \
> +                    file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
> +                    file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"
> 

This is not generally broken - do I interprete this correct as this is 
just for -hardknoot / -master ?

Best regards,
Stefano Babic
llewellyn Fernandes May 3, 2021, 4:14 p.m. UTC | #2
Hi Stefano,

This is for -thud. 

Regards
Llewellyn Fernandes

Sent from Mail for Windows 10

From: Stefano Babic
Sent: Monday, May 3, 2021 6:12 PM
To: LLewellyn Fernandes; swupdate@googlegroups.com
Subject: Re: [swupdate] [meta-swupdate][PATCH] Fix broken LIC_FILES_CHKSUM

Hi LLewellyn,

On 02.05.21 13:19, LLewellyn Fernandes wrote:
> Signed-off-by: LLewellyn Fernandes <llewellyn.fernandes@evologics.de>
> ---
>   recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/recipes-support/swupdate/swupdate_2020.11.bb b/recipes-support/swupdate/swupdate_2020.11.bb
> index 515ee88..8ba832f 100644
> --- a/recipes-support/swupdate/swupdate_2020.11.bb
> +++ b/recipes-support/swupdate/swupdate_2020.11.bb
> @@ -1,3 +1,8 @@
>   require swupdate.inc
>   
>   SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
> +                    file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \
> +                    file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
> +                    file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"
> 

This is not generally broken - do I interprete this correct as this is 
just for -hardknoot / -master ?

Best regards,
Stefano Babic
Stefano Babic May 3, 2021, 4:21 p.m. UTC | #3
Hi Llewellyn,

On 03.05.21 18:14, Llewellyn Fernandes wrote:
> Hi Stefano,
> 
> This is for -thud.
> 

No, then there is something wrong. You are touching recipe for 2020.11, 
that is commit 976334220 and the files are set correctly in 
swupdate.inc. Changes to new schema is done in poky since hardknott and 
in SWUpdate in recent 2021.04. The patch seems wrong.

Best regards,
Stefano Babic

> Regards
> 
> Llewellyn Fernandes
> 
> Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for 
> Windows 10
> 
> *From: *Stefano Babic <mailto:sbabic@denx.de>
> *Sent: *Monday, May 3, 2021 6:12 PM
> *To: *LLewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>; 
> swupdate@googlegroups.com <mailto:swupdate@googlegroups.com>
> *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken LIC_FILES_CHKSUM
> 
> Hi LLewellyn,
> 
> On 02.05.21 13:19, LLewellyn Fernandes wrote:
> 
>  > Signed-off-by: LLewellyn Fernandes <llewellyn.fernandes@evologics.de>
> 
>  > ---
> 
>  >   recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
> 
>  >   1 file changed, 5 insertions(+)
> 
>  >
> 
>  > diff --git a/recipes-support/swupdate/swupdate_2020.11.bb 
> b/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  > index 515ee88..8ba832f 100644
> 
>  > --- a/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  > +++ b/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  > @@ -1,3 +1,8 @@
> 
>  >   require swupdate.inc
> 
>  >
> 
>  >   SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
> 
>  > +
> 
>  > +LIC_FILES_CHKSUM = 
> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
> 
>  > +                    
> file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \
> 
>  > +                    
> file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
> 
>  > +                    
> file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"
> 
>  >
> 
> This is not generally broken - do I interprete this correct as this is
> 
> just for -hardknoot / -master ?
> 
> Best regards,
> 
> Stefano Babic
> 
> -- 
> 
> =====================================================================
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> 
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> 
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> 
> =====================================================================
> 
> -- 
> You received this message because you are subscribed to the Google 
> Groups "swupdate" group.
> To unsubscribe from this group and stop receiving emails from it, send 
> an email to swupdate+unsubscribe@googlegroups.com 
> <mailto:swupdate+unsubscribe@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de 
> <https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>.
llewellyn Fernandes May 3, 2021, 4:25 p.m. UTC | #4
Hi Stefano, 

I detected the failure in my build which is based on thud. I will confirm this again if you are skeptical about it. 
I will be able to test this tomorrow.

Just for my clarification, why is LIC_FILES_CHKSUM changed in branch thud? 
https://github.com/sbabic/meta-swupdate/blob/thud/recipes-support/swupdate/swupdate_git.bb


Regards
Llewellyn Fernandes

Sent from Mail for Windows 10

From: Stefano Babic
Sent: Monday, May 3, 2021 6:21 PM
To: Llewellyn Fernandes; Stefano Babic; swupdate@googlegroups.com
Subject: Re: [swupdate] [meta-swupdate][PATCH] Fix broken LIC_FILES_CHKSUM

Hi Llewellyn,

On 03.05.21 18:14, Llewellyn Fernandes wrote:
> Hi Stefano,
> 
> This is for -thud.
> 

No, then there is something wrong. You are touching recipe for 2020.11, 
that is commit 976334220 and the files are set correctly in 
swupdate.inc. Changes to new schema is done in poky since hardknott and 
in SWUpdate in recent 2021.04. The patch seems wrong.

Best regards,
Stefano Babic

> Regards
> 
> Llewellyn Fernandes
> 
> Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for 
> Windows 10
> 
> *From: *Stefano Babic <mailto:sbabic@denx.de>
> *Sent: *Monday, May 3, 2021 6:12 PM
> *To: *LLewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>; 
> swupdate@googlegroups.com <mailto:swupdate@googlegroups.com>
> *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken LIC_FILES_CHKSUM
> 
> Hi LLewellyn,
> 
> On 02.05.21 13:19, LLewellyn Fernandes wrote:
> 
>  > Signed-off-by: LLewellyn Fernandes <llewellyn.fernandes@evologics.de>
> 
>  > ---
> 
>  >   recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
> 
>  >   1 file changed, 5 insertions(+)
> 
>  >
> 
>  > diff --git a/recipes-support/swupdate/swupdate_2020.11.bb 
> b/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  > index 515ee88..8ba832f 100644
> 
>  > --- a/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  > +++ b/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  > @@ -1,3 +1,8 @@
> 
>  >   require swupdate.inc
> 
>  >
> 
>  >   SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
> 
>  > +
> 
>  > +LIC_FILES_CHKSUM = 
> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
> 
>  > +                    
> file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \
> 
>  > +                    
> file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
> 
>  > +                    
> file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"
> 
>  >
> 
> This is not generally broken - do I interprete this correct as this is
> 
> just for -hardknoot / -master ?
> 
> Best regards,
> 
> Stefano Babic
> 
> -- 
> 
> =====================================================================
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> 
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> 
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> 
> =====================================================================
> 
> -- 
> You received this message because you are subscribed to the Google 
> Groups "swupdate" group.
> To unsubscribe from this group and stop receiving emails from it, send 
> an email to swupdate+unsubscribe@googlegroups.com 
> <mailto:swupdate+unsubscribe@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de 
> <https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>.
Stefano Babic May 3, 2021, 4:37 p.m. UTC | #5
Hi Llewellyn,

On 03.05.21 18:25, Llewellyn Fernandes wrote:
> Hi Stefano,
> 
> I detected the failure in my build which is based on thud. I will 
> confirm this again if you are skeptical about it.
> 
> I will be able to test this tomorrow.
> 

Please do it, there is something unclear. You are changing the recipe 
for 2020.11, but there are no changes for old release.

> Just for my clarification, why is LIC_FILES_CHKSUM changed in branch thud?
> 
> https://github.com/sbabic/meta-swupdate/blob/thud/recipes-support/swupdate/swupdate_git.bb 
> <https://github.com/sbabic/meta-swupdate/blob/thud/recipes-support/swupdate/swupdate_git.bb>
> 

Please consider that this is the _git version.


There is work to be REUSE compliant (https://reuse.software/), and this 
means to rename licenses according to a schema. It is still WIP, but 
work is partially done and flew in 2021.04, and then of course in the 
_git version.

Best regards,
Stefano Babic


> Regards
> 
> Llewellyn Fernandes
> 
> Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for 
> Windows 10
> 
> *From: *Stefano Babic <mailto:sbabic@denx.de>
> *Sent: *Monday, May 3, 2021 6:21 PM
> *To: *Llewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>; 
> Stefano Babic <mailto:sbabic@denx.de>; swupdate@googlegroups.com 
> <mailto:swupdate@googlegroups.com>
> *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken LIC_FILES_CHKSUM
> 
> Hi Llewellyn,
> 
> On 03.05.21 18:14, Llewellyn Fernandes wrote:
> 
>  > Hi Stefano,
> 
>  >
> 
>  > This is for -thud.
> 
>  >
> 
> No, then there is something wrong. You are touching recipe for 2020.11,
> 
> that is commit 976334220 and the files are set correctly in
> 
> swupdate.inc. Changes to new schema is done in poky since hardknott and
> 
> in SWUpdate in recent 2021.04. The patch seems wrong.
> 
> Best regards,
> 
> Stefano Babic
> 
>  > Regards
> 
>  >
> 
>  > Llewellyn Fernandes
> 
>  >
> 
>  > Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for
> 
>  > Windows 10
> 
>  >
> 
>  > *From: *Stefano Babic <mailto:sbabic@denx.de>
> 
>  > *Sent: *Monday, May 3, 2021 6:12 PM
> 
>  > *To: *LLewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>;
> 
>  > swupdate@googlegroups.com <mailto:swupdate@googlegroups.com>
> 
>  > *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken 
> LIC_FILES_CHKSUM
> 
>  >
> 
>  > Hi LLewellyn,
> 
>  >
> 
>  > On 02.05.21 13:19, LLewellyn Fernandes wrote:
> 
>  >
> 
>  >  > Signed-off-by: LLewellyn Fernandes <llewellyn.fernandes@evologics.de>
> 
>  >
> 
>  >  > ---
> 
>  >
> 
>  >  >   recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
> 
>  >
> 
>  >  >   1 file changed, 5 insertions(+)
> 
>  >
> 
>  >  >
> 
>  >
> 
>  >  > diff --git a/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  > b/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  >
> 
>  >  > index 515ee88..8ba832f 100644
> 
>  >
> 
>  >  > --- a/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  >
> 
>  >  > +++ b/recipes-support/swupdate/swupdate_2020.11.bb
> 
>  >
> 
>  >  > @@ -1,3 +1,8 @@
> 
>  >
> 
>  >  >   require swupdate.inc
> 
>  >
> 
>  >  >
> 
>  >
> 
>  >  >   SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
> 
>  >
> 
>  >  > +
> 
>  >
> 
>  >  > +LIC_FILES_CHKSUM =
> 
>  > "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
> 
>  >
> 
>  >  > +
> 
>  > 
> file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \
> 
>  >
> 
>  >  > +
> 
>  > file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
> 
>  >
> 
>  >  > +
> 
>  > 
> file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"
> 
>  >
> 
>  >  >
> 
>  >
> 
>  > This is not generally broken - do I interprete this correct as this is
> 
>  >
> 
>  > just for -hardknoot / -master ?
> 
>  >
> 
>  > Best regards,
> 
>  >
> 
>  > Stefano Babic
> 
>  >
> 
>  > --
> 
>  >
> 
>  > =====================================================================
> 
>  >
> 
>  > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> 
>  >
> 
>  > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> 
>  >
> 
>  > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> 
>  >
> 
>  > =====================================================================
> 
>  >
> 
>  > --
> 
>  > You received this message because you are subscribed to the Google
> 
>  > Groups "swupdate" group.
> 
>  > To unsubscribe from this group and stop receiving emails from it, send
> 
>  > an email to swupdate+unsubscribe@googlegroups.com
> 
>  > <mailto:swupdate+unsubscribe@googlegroups.com>.
> 
>  > To view this discussion on the web visit
> 
>  > 
> https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de 
> 
> 
>  > 
> <https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>.
> 
> -- 
> 
> =====================================================================
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> 
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> 
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> 
> =====================================================================
> 
> -- 
> You received this message because you are subscribed to the Google 
> Groups "swupdate" group.
> To unsubscribe from this group and stop receiving emails from it, send 
> an email to swupdate+unsubscribe@googlegroups.com 
> <mailto:swupdate+unsubscribe@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/swupdate/U0484cx43GPd0DX.RZmta%40mo4-p00-ob.smtp.rzone.de 
> <https://groups.google.com/d/msgid/swupdate/U0484cx43GPd0DX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>.
llewellyn Fernandes May 3, 2021, 7:19 p.m. UTC | #6
Hi Stefano,


After a preliminary look it seems to be that  SRCREV = 
"9763342203e32d58cbfed36550b3986b5cf0e52e"   doesnt work.

It takes the latest  version.

But SRCREV_pn-${PN} = "9763342203e32d58cbfed36550b3986b5cf0e52e" works.

I dont understand why this is happening. I will investigate further and 
let you know.


Regards

Llewellyn Fernandes

On 03.05.21 18:37, Stefano Babic wrote:
> Hi Llewellyn,
>
> On 03.05.21 18:25, Llewellyn Fernandes wrote:
>> Hi Stefano,
>>
>> I detected the failure in my build which is based on thud. I will 
>> confirm this again if you are skeptical about it.
>>
>> I will be able to test this tomorrow.
>>
>
> Please do it, there is something unclear. You are changing the recipe 
> for 2020.11, but there are no changes for old release.
>
>> Just for my clarification, why is LIC_FILES_CHKSUM changed in branch 
>> thud?
>>
>> https://github.com/sbabic/meta-swupdate/blob/thud/recipes-support/swupdate/swupdate_git.bb 
>> <https://github.com/sbabic/meta-swupdate/blob/thud/recipes-support/swupdate/swupdate_git.bb> 
>>
>>
>
> Please consider that this is the _git version.
>
>
> There is work to be REUSE compliant (https://reuse.software/), and 
> this means to rename licenses according to a schema. It is still WIP, 
> but work is partially done and flew in 2021.04, and then of course in 
> the _git version.
>
> Best regards,
> Stefano Babic
>
>
>> Regards
>>
>> Llewellyn Fernandes
>>
>> Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for 
>> Windows 10
>>
>> *From: *Stefano Babic <mailto:sbabic@denx.de>
>> *Sent: *Monday, May 3, 2021 6:21 PM
>> *To: *Llewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>; 
>> Stefano Babic <mailto:sbabic@denx.de>; swupdate@googlegroups.com 
>> <mailto:swupdate@googlegroups.com>
>> *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken 
>> LIC_FILES_CHKSUM
>>
>> Hi Llewellyn,
>>
>> On 03.05.21 18:14, Llewellyn Fernandes wrote:
>>
>>  > Hi Stefano,
>>
>>  >
>>
>>  > This is for -thud.
>>
>>  >
>>
>> No, then there is something wrong. You are touching recipe for 2020.11,
>>
>> that is commit 976334220 and the files are set correctly in
>>
>> swupdate.inc. Changes to new schema is done in poky since hardknott and
>>
>> in SWUpdate in recent 2021.04. The patch seems wrong.
>>
>> Best regards,
>>
>> Stefano Babic
>>
>>  > Regards
>>
>>  >
>>
>>  > Llewellyn Fernandes
>>
>>  >
>>
>>  > Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for
>>
>>  > Windows 10
>>
>>  >
>>
>>  > *From: *Stefano Babic <mailto:sbabic@denx.de>
>>
>>  > *Sent: *Monday, May 3, 2021 6:12 PM
>>
>>  > *To: *LLewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>;
>>
>>  > swupdate@googlegroups.com <mailto:swupdate@googlegroups.com>
>>
>>  > *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken 
>> LIC_FILES_CHKSUM
>>
>>  >
>>
>>  > Hi LLewellyn,
>>
>>  >
>>
>>  > On 02.05.21 13:19, LLewellyn Fernandes wrote:
>>
>>  >
>>
>>  >  > Signed-off-by: LLewellyn Fernandes 
>> <llewellyn.fernandes@evologics.de>
>>
>>  >
>>
>>  >  > ---
>>
>>  >
>>
>>  >  >   recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
>>
>>  >
>>
>>  >  >   1 file changed, 5 insertions(+)
>>
>>  >
>>
>>  >  >
>>
>>  >
>>
>>  >  > diff --git a/recipes-support/swupdate/swupdate_2020.11.bb
>>
>>  > b/recipes-support/swupdate/swupdate_2020.11.bb
>>
>>  >
>>
>>  >  > index 515ee88..8ba832f 100644
>>
>>  >
>>
>>  >  > --- a/recipes-support/swupdate/swupdate_2020.11.bb
>>
>>  >
>>
>>  >  > +++ b/recipes-support/swupdate/swupdate_2020.11.bb
>>
>>  >
>>
>>  >  > @@ -1,3 +1,8 @@
>>
>>  >
>>
>>  >  >   require swupdate.inc
>>
>>  >
>>
>>  >  >
>>
>>  >
>>
>>  >  >   SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
>>
>>  >
>>
>>  >  > +
>>
>>  >
>>
>>  >  > +LIC_FILES_CHKSUM =
>>
>>  > "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>
>>  >
>>
>>  >  > +
>>
>>  > 
>> file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c 
>> \
>>
>>  >
>>
>>  >  > +
>>
>>  > file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
>>
>>  >
>>
>>  >  > +
>>
>>  > 
>> file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"
>>
>>  >
>>
>>  >  >
>>
>>  >
>>
>>  > This is not generally broken - do I interprete this correct as 
>> this is
>>
>>  >
>>
>>  > just for -hardknoot / -master ?
>>
>>  >
>>
>>  > Best regards,
>>
>>  >
>>
>>  > Stefano Babic
>>
>>  >
>>
>>  > --
>>
>>  >
>>
>>  > =====================================================================
>>
>>  >
>>
>>  > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>
>>  >
>>
>>  > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>
>>  >
>>
>>  > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
>>
>>  >
>>
>>  > =====================================================================
>>
>>  >
>>
>>  > --
>>
>>  > You received this message because you are subscribed to the Google
>>
>>  > Groups "swupdate" group.
>>
>>  > To unsubscribe from this group and stop receiving emails from it, 
>> send
>>
>>  > an email to swupdate+unsubscribe@googlegroups.com
>>
>>  > <mailto:swupdate+unsubscribe@googlegroups.com>.
>>
>>  > To view this discussion on the web visit
>>
>>  > 
>> https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de 
>>
>>
>>  > 
>> <https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>.
>>
>> -- 
>>
>> =====================================================================
>>
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>
>> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
>>
>> =====================================================================
>>
>> -- 
>> You received this message because you are subscribed to the Google 
>> Groups "swupdate" group.
>> To unsubscribe from this group and stop receiving emails from it, 
>> send an email to swupdate+unsubscribe@googlegroups.com 
>> <mailto:swupdate+unsubscribe@googlegroups.com>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/swupdate/U0484cx43GPd0DX.RZmta%40mo4-p00-ob.smtp.rzone.de 
>> <https://groups.google.com/d/msgid/swupdate/U0484cx43GPd0DX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>. 
>>
>
>
Stefano Babic May 3, 2021, 7:43 p.m. UTC | #7
Hi llewellyn,

On 03.05.21 21:19, llewellyn Fernandes wrote:
> Hi Stefano,
> 
> 
> After a preliminary look it seems to be that  SRCREV = 
> "9763342203e32d58cbfed36550b3986b5cf0e52e"   doesnt work.
> 
> It takes the latest  version.
> 
> But SRCREV_pn-${PN} = "9763342203e32d58cbfed36550b3986b5cf0e52e" works.
> 
> I dont understand why this is happening.

This means you have probably a swupdate_.bbappend in your layer and you 
overwrite SRCREV. If you had used PREFERRED_VERSION_swupdate, you should 
not have the issue because the git recipe is coherent.

> I will investigate further and 
> let you know.

Fine.

Best regards,
Stefano Babic

> 
> 
> Regards
> 
> Llewellyn Fernandes
> 
> On 03.05.21 18:37, Stefano Babic wrote:
>> Hi Llewellyn,
>>
>> On 03.05.21 18:25, Llewellyn Fernandes wrote:
>>> Hi Stefano,
>>>
>>> I detected the failure in my build which is based on thud. I will 
>>> confirm this again if you are skeptical about it.
>>>
>>> I will be able to test this tomorrow.
>>>
>>
>> Please do it, there is something unclear. You are changing the recipe 
>> for 2020.11, but there are no changes for old release.
>>
>>> Just for my clarification, why is LIC_FILES_CHKSUM changed in branch 
>>> thud?
>>>
>>> https://github.com/sbabic/meta-swupdate/blob/thud/recipes-support/swupdate/swupdate_git.bb 
>>> <https://github.com/sbabic/meta-swupdate/blob/thud/recipes-support/swupdate/swupdate_git.bb> 
>>>
>>>
>>
>> Please consider that this is the _git version.
>>
>>
>> There is work to be REUSE compliant (https://reuse.software/), and 
>> this means to rename licenses according to a schema. It is still WIP, 
>> but work is partially done and flew in 2021.04, and then of course in 
>> the _git version.
>>
>> Best regards,
>> Stefano Babic
>>
>>
>>> Regards
>>>
>>> Llewellyn Fernandes
>>>
>>> Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for 
>>> Windows 10
>>>
>>> *From: *Stefano Babic <mailto:sbabic@denx.de>
>>> *Sent: *Monday, May 3, 2021 6:21 PM
>>> *To: *Llewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>; 
>>> Stefano Babic <mailto:sbabic@denx.de>; swupdate@googlegroups.com 
>>> <mailto:swupdate@googlegroups.com>
>>> *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken 
>>> LIC_FILES_CHKSUM
>>>
>>> Hi Llewellyn,
>>>
>>> On 03.05.21 18:14, Llewellyn Fernandes wrote:
>>>
>>>  > Hi Stefano,
>>>
>>>  >
>>>
>>>  > This is for -thud.
>>>
>>>  >
>>>
>>> No, then there is something wrong. You are touching recipe for 2020.11,
>>>
>>> that is commit 976334220 and the files are set correctly in
>>>
>>> swupdate.inc. Changes to new schema is done in poky since hardknott and
>>>
>>> in SWUpdate in recent 2021.04. The patch seems wrong.
>>>
>>> Best regards,
>>>
>>> Stefano Babic
>>>
>>>  > Regards
>>>
>>>  >
>>>
>>>  > Llewellyn Fernandes
>>>
>>>  >
>>>
>>>  > Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for
>>>
>>>  > Windows 10
>>>
>>>  >
>>>
>>>  > *From: *Stefano Babic <mailto:sbabic@denx.de>
>>>
>>>  > *Sent: *Monday, May 3, 2021 6:12 PM
>>>
>>>  > *To: *LLewellyn Fernandes <mailto:llewellyn.fernandes@evologics.de>;
>>>
>>>  > swupdate@googlegroups.com <mailto:swupdate@googlegroups.com>
>>>
>>>  > *Subject: *Re: [swupdate] [meta-swupdate][PATCH] Fix broken 
>>> LIC_FILES_CHKSUM
>>>
>>>  >
>>>
>>>  > Hi LLewellyn,
>>>
>>>  >
>>>
>>>  > On 02.05.21 13:19, LLewellyn Fernandes wrote:
>>>
>>>  >
>>>
>>>  >  > Signed-off-by: LLewellyn Fernandes 
>>> <llewellyn.fernandes@evologics.de>
>>>
>>>  >
>>>
>>>  >  > ---
>>>
>>>  >
>>>
>>>  >  >   recipes-support/swupdate/swupdate_2020.11.bb | 5 +++++
>>>
>>>  >
>>>
>>>  >  >   1 file changed, 5 insertions(+)
>>>
>>>  >
>>>
>>>  >  >
>>>
>>>  >
>>>
>>>  >  > diff --git a/recipes-support/swupdate/swupdate_2020.11.bb
>>>
>>>  > b/recipes-support/swupdate/swupdate_2020.11.bb
>>>
>>>  >
>>>
>>>  >  > index 515ee88..8ba832f 100644
>>>
>>>  >
>>>
>>>  >  > --- a/recipes-support/swupdate/swupdate_2020.11.bb
>>>
>>>  >
>>>
>>>  >  > +++ b/recipes-support/swupdate/swupdate_2020.11.bb
>>>
>>>  >
>>>
>>>  >  > @@ -1,3 +1,8 @@
>>>
>>>  >
>>>
>>>  >  >   require swupdate.inc
>>>
>>>  >
>>>
>>>  >  >
>>>
>>>  >
>>>
>>>  >  >   SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
>>>
>>>  >
>>>
>>>  >  > +
>>>
>>>  >
>>>
>>>  >  > +LIC_FILES_CHKSUM =
>>>
>>>  > "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>>
>>>  >
>>>
>>>  >  > +
>>>
>>>  > 
>>> file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c 
>>> \
>>>
>>>  >
>>>
>>>  >  > +
>>>
>>>  > file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
>>>
>>>  >
>>>
>>>  >  > +
>>>
>>>  > 
>>> file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a" 
>>>
>>>
>>>  >
>>>
>>>  >  >
>>>
>>>  >
>>>
>>>  > This is not generally broken - do I interprete this correct as 
>>> this is
>>>
>>>  >
>>>
>>>  > just for -hardknoot / -master ?
>>>
>>>  >
>>>
>>>  > Best regards,
>>>
>>>  >
>>>
>>>  > Stefano Babic
>>>
>>>  >
>>>
>>>  > --
>>>
>>>  >
>>>
>>>  > =====================================================================
>>>
>>>  >
>>>
>>>  > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>>
>>>  >
>>>
>>>  > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>>
>>>  >
>>>
>>>  > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
>>>
>>>  >
>>>
>>>  > =====================================================================
>>>
>>>  >
>>>
>>>  > --
>>>
>>>  > You received this message because you are subscribed to the Google
>>>
>>>  > Groups "swupdate" group.
>>>
>>>  > To unsubscribe from this group and stop receiving emails from it, 
>>> send
>>>
>>>  > an email to swupdate+unsubscribe@googlegroups.com
>>>
>>>  > <mailto:swupdate+unsubscribe@googlegroups.com>.
>>>
>>>  > To view this discussion on the web visit
>>>
>>>  > 
>>> https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de 
>>>
>>>
>>>  > 
>>> <https://groups.google.com/d/msgid/swupdate/U0484cx43GE90AX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>. 
>>>
>>>
>>> -- 
>>>
>>> =====================================================================
>>>
>>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>>
>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>>
>>> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
>>>
>>> =====================================================================
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "swupdate" group.
>>> To unsubscribe from this group and stop receiving emails from it, 
>>> send an email to swupdate+unsubscribe@googlegroups.com 
>>> <mailto:swupdate+unsubscribe@googlegroups.com>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/swupdate/U0484cx43GPd0DX.RZmta%40mo4-p00-ob.smtp.rzone.de 
>>> <https://groups.google.com/d/msgid/swupdate/U0484cx43GPd0DX.RZmta%40mo4-p00-ob.smtp.rzone.de?utm_medium=email&utm_source=footer>. 
>>>
>>
>>
diff mbox series

Patch

diff --git a/recipes-support/swupdate/swupdate_2020.11.bb b/recipes-support/swupdate/swupdate_2020.11.bb
index 515ee88..8ba832f 100644
--- a/recipes-support/swupdate/swupdate_2020.11.bb
+++ b/recipes-support/swupdate/swupdate_2020.11.bb
@@ -1,3 +1,8 @@ 
 require swupdate.inc
 
 SRCREV = "9763342203e32d58cbfed36550b3986b5cf0e52e"
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
+                    file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \
+                    file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \
+                    file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"